* [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument
@ 2021-12-29 10:58 Jianguo Wu
2021-12-29 14:16 ` Willem de Bruijn
0 siblings, 1 reply; 3+ messages in thread
From: Jianguo Wu @ 2021-12-29 10:58 UTC (permalink / raw)
To: willemb, Jakub Kicinski; +Cc: netdev
From: wujianguo <wujianguo@chinatelecom.cn>
udpgso_bench_tx call setup_sockaddr() for dest address before
parsing all arguments, if we specify "-p ${dst_port}" after "-D ${dst_ip}",
then ${dst_port} will be ignored, and using default cfg_port 8000.
This will cause test case "multiple GRO socks" failed in udpgro.sh.
Setup sockaddr after after parsing all arguments.
Fixes: 3a687bef148d ("selftests: udp gso benchmark")
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
---
tools/testing/selftests/net/udpgso_bench_tx.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/udpgso_bench_tx.c b/tools/testing/selftests/net/udpgso_bench_tx.c
index 17512a4..f1fdaa2 100644
--- a/tools/testing/selftests/net/udpgso_bench_tx.c
+++ b/tools/testing/selftests/net/udpgso_bench_tx.c
@@ -419,6 +419,7 @@ static void usage(const char *filepath)
static void parse_opts(int argc, char **argv)
{
+ const char *bind_addr = NULL;
int max_len, hdrlen;
int c;
@@ -446,7 +447,7 @@ static void parse_opts(int argc, char **argv)
cfg_cpu = strtol(optarg, NULL, 0);
break;
case 'D':
- setup_sockaddr(cfg_family, optarg, &cfg_dst_addr);
+ bind_addr = optarg;
break;
case 'l':
cfg_runtime_ms = strtoul(optarg, NULL, 10) * 1000;
@@ -492,6 +493,11 @@ static void parse_opts(int argc, char **argv)
}
}
+ if (!bind_addr)
+ bind_addr = cfg_family == PF_INET6 ? "::" : "0.0.0.0";
+
+ setup_sockaddr(cfg_family, bind_addr, &cfg_dst_addr);
+
if (optind != argc)
usage(argv[0]);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument
2021-12-29 10:58 [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument Jianguo Wu
@ 2021-12-29 14:16 ` Willem de Bruijn
2021-12-30 2:25 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Willem de Bruijn @ 2021-12-29 14:16 UTC (permalink / raw)
To: Jianguo Wu; +Cc: Jakub Kicinski, netdev
On Wed, Dec 29, 2021 at 5:58 AM Jianguo Wu <wujianguo106@163.com> wrote:
>
> From: wujianguo <wujianguo@chinatelecom.cn>
>
> udpgso_bench_tx call setup_sockaddr() for dest address before
> parsing all arguments, if we specify "-p ${dst_port}" after "-D ${dst_ip}",
> then ${dst_port} will be ignored, and using default cfg_port 8000.
>
> This will cause test case "multiple GRO socks" failed in udpgro.sh.
>
> Setup sockaddr after after parsing all arguments.
>
> Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Reviewed-by: Willem de Bruijn <willemb@google.com>
The udpgso_bench_tx equivalent to commit d336509cb9d0 ("selftests/net:
udpgso_bench_rx: fix port argument"). Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument
2021-12-29 14:16 ` Willem de Bruijn
@ 2021-12-30 2:25 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-12-30 2:25 UTC (permalink / raw)
To: Willem de Bruijn, Jianguo Wu; +Cc: netdev
On Wed, 29 Dec 2021 09:16:37 -0500 Willem de Bruijn wrote:
> On Wed, Dec 29, 2021 at 5:58 AM Jianguo Wu <wujianguo106@163.com> wrote:
> >
> > From: wujianguo <wujianguo@chinatelecom.cn>
> >
> > udpgso_bench_tx call setup_sockaddr() for dest address before
> > parsing all arguments, if we specify "-p ${dst_port}" after "-D ${dst_ip}",
> > then ${dst_port} will be ignored, and using default cfg_port 8000.
> >
> > This will cause test case "multiple GRO socks" failed in udpgro.sh.
> >
> > Setup sockaddr after after parsing all arguments.
s/after after/after/
> >
> > Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> > Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> The udpgso_bench_tx equivalent to commit d336509cb9d0 ("selftests/net:
> udpgso_bench_rx: fix port argument"). Thanks.
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-30 2:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-29 10:58 [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument Jianguo Wu
2021-12-29 14:16 ` Willem de Bruijn
2021-12-30 2:25 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.