[Buildroot] [PATCH 1/1] package/vlc: needs host-gettext

[Buildroot] [PATCH 1/1] package/vlc: needs host-gettext

[Bernd Kuhls]

Build fails on systems without /usr/bin/msgfmt

Fixes:
http://autobuild.buildroot.net/results/3c9/3c9893dd92d784a0520a287c4d4a5e760393c95f/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/vlc/vlc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index 06fc650f6f..fe338fcbe8 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -11,7 +11,7 @@ VLC_LICENSE = GPL-2.0+, LGPL-2.1+
 VLC_LICENSE_FILES = COPYING COPYING.LIB
 VLC_CPE_ID_VENDOR = videolan
 VLC_CPE_ID_PRODUCT = vlc_media_player
-VLC_DEPENDENCIES = host-pkgconf
+VLC_DEPENDENCIES = host-gettext host-pkgconf
 VLC_AUTORECONF = YES
 
 # Install vlc libraries in staging.
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/vlc: needs host-gettext

[Thomas Petazzoni]

On Tue, 28 Dec 2021 23:03:02 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Build fails on systems without /usr/bin/msgfmt
> 
> Fixes:
> http://autobuild.buildroot.net/results/3c9/3c9893dd92d784a0520a287c4d4a5e760393c95f/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Since when is this failure happening? If I understand correctly, it
manifests itself as follows:

/usr/bin/install: cannot stat './vlc.appdata.xml': No such file or directory

I can trace back one such failure at

  http://autobuild.buildroot.net/results/652/652055f4f517e5056d35495fa5e52d72a5e61b6e/build-end.log

which was with vlc 3.0.12, back in February 2021.

Also,

  http://autobuild.buildroot.net/results/fb1/fb12d981f7ebb859618bc17ed5f18a9fee1e98ee/build-end.log

which was with vlc 3.0.11, back in January 2021.

http://autobuild.buildroot.net/results/7e6/7e6f07179ddf3b4cab1445214c064921f2b6f8bd/build-end.log

Same vlc release, September 2020.

http://autobuild.buildroot.net/results/e2b/e2b670ab75e980ab27955c3759854faa9985731b/build-end.log

This is with vlc 3.0.10, in June 2020.

http://autobuild.buildroot.net/results/f80/f80e6c1d7e11144fba8cbcde491c28554e710d06/build-end.log

This is with vlc 3.0.8 in April 2020.

http://autobuild.buildroot.net/results/e9a/e9acb796dd062d7829db9754e209bf349bf459ea/build-end.log

This is with vlc 3.0.7 in August 2019.

This is the kind of research that is needed when fixing such build
failures. We don't need to just fix it, but also figure out since when
the problem has been around, so that we know if we need to backport to
our LTS branch.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/vlc: needs host-gettext

[Thomas Petazzoni]

On Tue, 28 Dec 2021 23:03:02 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Build fails on systems without /usr/bin/msgfmt
> 
> Fixes:
> http://autobuild.buildroot.net/results/3c9/3c9893dd92d784a0520a287c4d4a5e760393c95f/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/vlc/vlc.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master with an extended commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/vlc: needs host-gettext

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Build fails on systems without /usr/bin/msgfmt
 > Fixes:
 > http://autobuild.buildroot.net/results/3c9/3c9893dd92d784a0520a287c4d4a5e760393c95f/

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed to 2021.02.x and 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot