From: Keith Busch <kbusch@kernel.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
axboe@kernel.dk, sagi@grimberg.me
Subject: Re: [PATCHv2 1/3] block: introduce rq_list_for_each_safe macro
Date: Thu, 30 Dec 2021 07:30:18 -0800 [thread overview]
Message-ID: <20211230153018.GD2493133@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <99b389d6-b18b-7c3b-decb-66c4563dd37b@nvidia.com>
On Thu, Dec 30, 2021 at 04:38:57PM +0200, Max Gurtovoy wrote:
>
> On 12/29/2021 10:57 PM, Keith Busch wrote:
> > On Wed, Dec 29, 2021 at 06:39:02PM +0100, Christoph Hellwig wrote:
> > > (except for the fact that it, just like the other rq_list helpers
> > > really should go into blk-mq.h, where all request related bits moved
> > > early in this cycle)
> > Agreed, I just put it here because it's where the other macros live. But
> > 'struct request' doesn't exist in this header, so it does seem out of
> > place. For v3, I'll add a preceding patch to move them all to blk-mq.h.
>
> Did you see the discussion I had with Jens ?
I did, yes. That's when I noticed the error handling wasn't right, and
doing it correctly was a bit clunky. This series was supposed to make it
easier for drivers to use the new interface.
> Seems it works only for non-shared tagsets and it means that it will work
> only for NVMe devices that have 1 namespace and will not work for NVMf
> drivers.
I am aware shared tags don't get to use the batched queueing, but that's
orthogonal to this series.
Most PCIe NVMe SSDs only have 1 namespace, so it generally works out for
those.
> Unless, we'll do some changes in the block layer and/or remove this
> condition.
I think it just may work if we export blk_mq_get_driver_tag().
next prev parent reply other threads:[~2021-12-30 15:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 16:41 [PATCHv2 1/3] block: introduce rq_list_for_each_safe macro Keith Busch
2021-12-27 16:41 ` [PATCHv2 2/3] block: introduce rq_list_move Keith Busch
2021-12-27 18:49 ` kernel test robot
2021-12-27 18:49 ` kernel test robot
2021-12-29 17:41 ` Christoph Hellwig
2021-12-29 20:59 ` Keith Busch
2021-12-27 16:41 ` [PATCHv2 3/3] nvme-pci: fix queue_rqs list splitting Keith Busch
2021-12-29 17:46 ` Christoph Hellwig
2021-12-29 21:04 ` Keith Busch
2021-12-30 7:53 ` Christoph Hellwig
2022-01-04 19:38 ` Keith Busch
2022-01-05 7:35 ` Christoph Hellwig
2021-12-29 17:39 ` [PATCHv2 1/3] block: introduce rq_list_for_each_safe macro Christoph Hellwig
2021-12-29 20:57 ` Keith Busch
2021-12-30 14:38 ` Max Gurtovoy
2021-12-30 15:30 ` Keith Busch [this message]
2022-01-03 15:23 ` Max Gurtovoy
2022-01-03 18:15 ` Keith Busch
2022-01-04 12:15 ` Max Gurtovoy
2022-01-05 17:26 ` Keith Busch
2022-01-06 11:54 ` Max Gurtovoy
2022-01-06 13:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230153018.GD2493133@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.