From: kernel test robot <lkp@intel.com> To: Keith Busch <kbusch@kernel.org>, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, axboe@kernel.dk Cc: kbuild-all@lists.01.org, hch@lst.de, sagi@grimberg.me, Keith Busch <kbusch@kernel.org> Subject: Re: [PATCHv2 2/3] block: introduce rq_list_move Date: Tue, 28 Dec 2021 02:49:10 +0800 [thread overview] Message-ID: <202112280210.F89j103t-lkp@intel.com> (raw) In-Reply-To: <20211227164138.2488066-2-kbusch@kernel.org> Hi Keith, I love your patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linux-review/Xie-Yongji/nbd-Don-t-use-workqueue-to-handle-recv-work/20211227-171406 linus/master v5.16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Keith-Busch/block-introduce-rq_list_for_each_safe-macro/20211228-004304 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211228/202112280210.F89j103t-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/81098ed2c64adf477eae9c21a4188916e0ef5918 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Keith-Busch/block-introduce-rq_list_for_each_safe-macro/20211228-004304 git checkout 81098ed2c64adf477eae9c21a4188916e0ef5918 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from arch/um/drivers/ubd_kern.c:27: >> include/linux/blk-mq.h:227:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 227 | static void inline rq_list_move(struct request **src, struct request **dst, | ^~~~~~ -- In file included from include/linux/blktrace_api.h:5, from block/bfq-iosched.h:9, from block/bfq-cgroup.c:16: >> include/linux/blk-mq.h:227:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 227 | static void inline rq_list_move(struct request **src, struct request **dst, | ^~~~~~ block/bfq-cgroup.c:1437:6: warning: no previous prototype for 'bfqg_and_blkg_get' [-Wmissing-prototypes] 1437 | void bfqg_and_blkg_get(struct bfq_group *bfqg) {} | ^~~~~~~~~~~~~~~~~ vim +/inline +227 include/linux/blk-mq.h 215 216 #define rq_dma_dir(rq) \ 217 (op_is_write(req_op(rq)) ? DMA_TO_DEVICE : DMA_FROM_DEVICE) 218 219 /** 220 * rq_list_move() - move a struct request from one list to another 221 * @src: The source list @rq is currently in 222 * @dst: The destination list that @rq will be appended to 223 * @rq: The request to move 224 * @prv: The request preceding @rq in @src (NULL if @rq is the head) 225 * @nxt: The request following @rq in @src (NULL if @rq is the tail) 226 */ > 227 static void inline rq_list_move(struct request **src, struct request **dst, 228 struct request *rq, struct request *prv, 229 struct request *nxt) 230 { 231 if (prv) 232 prv->rq_next = nxt; 233 else 234 *src = nxt; 235 rq_list_add(dst, rq); 236 } 237 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCHv2 2/3] block: introduce rq_list_move Date: Tue, 28 Dec 2021 02:49:10 +0800 [thread overview] Message-ID: <202112280210.F89j103t-lkp@intel.com> (raw) In-Reply-To: <20211227164138.2488066-2-kbusch@kernel.org> [-- Attachment #1: Type: text/plain, Size: 3379 bytes --] Hi Keith, I love your patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linux-review/Xie-Yongji/nbd-Don-t-use-workqueue-to-handle-recv-work/20211227-171406 linus/master v5.16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Keith-Busch/block-introduce-rq_list_for_each_safe-macro/20211228-004304 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211228/202112280210.F89j103t-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/81098ed2c64adf477eae9c21a4188916e0ef5918 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Keith-Busch/block-introduce-rq_list_for_each_safe-macro/20211228-004304 git checkout 81098ed2c64adf477eae9c21a4188916e0ef5918 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from arch/um/drivers/ubd_kern.c:27: >> include/linux/blk-mq.h:227:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 227 | static void inline rq_list_move(struct request **src, struct request **dst, | ^~~~~~ -- In file included from include/linux/blktrace_api.h:5, from block/bfq-iosched.h:9, from block/bfq-cgroup.c:16: >> include/linux/blk-mq.h:227:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 227 | static void inline rq_list_move(struct request **src, struct request **dst, | ^~~~~~ block/bfq-cgroup.c:1437:6: warning: no previous prototype for 'bfqg_and_blkg_get' [-Wmissing-prototypes] 1437 | void bfqg_and_blkg_get(struct bfq_group *bfqg) {} | ^~~~~~~~~~~~~~~~~ vim +/inline +227 include/linux/blk-mq.h 215 216 #define rq_dma_dir(rq) \ 217 (op_is_write(req_op(rq)) ? DMA_TO_DEVICE : DMA_FROM_DEVICE) 218 219 /** 220 * rq_list_move() - move a struct request from one list to another 221 * @src: The source list @rq is currently in 222 * @dst: The destination list that @rq will be appended to 223 * @rq: The request to move 224 * @prv: The request preceding @rq in @src (NULL if @rq is the head) 225 * @nxt: The request following @rq in @src (NULL if @rq is the tail) 226 */ > 227 static void inline rq_list_move(struct request **src, struct request **dst, 228 struct request *rq, struct request *prv, 229 struct request *nxt) 230 { 231 if (prv) 232 prv->rq_next = nxt; 233 else 234 *src = nxt; 235 rq_list_add(dst, rq); 236 } 237 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-27 18:49 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-27 16:41 [PATCHv2 1/3] block: introduce rq_list_for_each_safe macro Keith Busch 2021-12-27 16:41 ` [PATCHv2 2/3] block: introduce rq_list_move Keith Busch 2021-12-27 18:49 ` kernel test robot [this message] 2021-12-27 18:49 ` kernel test robot 2021-12-29 17:41 ` Christoph Hellwig 2021-12-29 20:59 ` Keith Busch 2021-12-27 16:41 ` [PATCHv2 3/3] nvme-pci: fix queue_rqs list splitting Keith Busch 2021-12-29 17:46 ` Christoph Hellwig 2021-12-29 21:04 ` Keith Busch 2021-12-30 7:53 ` Christoph Hellwig 2022-01-04 19:38 ` Keith Busch 2022-01-05 7:35 ` Christoph Hellwig 2021-12-29 17:39 ` [PATCHv2 1/3] block: introduce rq_list_for_each_safe macro Christoph Hellwig 2021-12-29 20:57 ` Keith Busch 2021-12-30 14:38 ` Max Gurtovoy 2021-12-30 15:30 ` Keith Busch 2022-01-03 15:23 ` Max Gurtovoy 2022-01-03 18:15 ` Keith Busch 2022-01-04 12:15 ` Max Gurtovoy 2022-01-05 17:26 ` Keith Busch 2022-01-06 11:54 ` Max Gurtovoy 2022-01-06 13:41 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202112280210.F89j103t-lkp@intel.com \ --to=lkp@intel.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=kbuild-all@lists.01.org \ --cc=kbusch@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.