* [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582
@ 2021-12-30 15:51 ` Maxim Kutnij
0 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2021-12-30 15:51 UTC (permalink / raw)
To: Matthias Brugger, Russell King
Cc: Maxim Kutnij, linux-arm-kernel, linux-mediatek, linux-kernel
This patch adds support SMP on MediaTek MT6582 Cortex-A7 quad core SoC.
Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
---
arch/arm/mach-mediatek/mediatek.c | 4 +++-
arch/arm/mach-mediatek/platsmp.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
index e6e9f93a1f0..aefeb661405 100644
--- a/arch/arm/mach-mediatek/mediatek.c
+++ b/arch/arm/mach-mediatek/mediatek.c
@@ -20,7 +20,8 @@ static void __init mediatek_timer_init(void)
{
void __iomem *gpt_base;
- if (of_machine_is_compatible("mediatek,mt6589") ||
+ if (of_machine_is_compatible("mediatek,mt6582") ||
+ of_machine_is_compatible("mediatek,mt6589") ||
of_machine_is_compatible("mediatek,mt7623") ||
of_machine_is_compatible("mediatek,mt8135") ||
of_machine_is_compatible("mediatek,mt8127")) {
@@ -38,6 +39,7 @@ static void __init mediatek_timer_init(void)
static const char * const mediatek_board_dt_compat[] = {
"mediatek,mt2701",
+ "mediatek,mt6582",
"mediatek,mt6589",
"mediatek,mt6592",
"mediatek,mt7623",
diff --git a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c
index 16a4ee6c959..e1c7ad52f77 100644
--- a/arch/arm/mach-mediatek/platsmp.c
+++ b/arch/arm/mach-mediatek/platsmp.c
@@ -49,6 +49,7 @@ static const struct of_device_id mtk_tz_smp_boot_infos[] __initconst = {
};
static const struct of_device_id mtk_smp_boot_infos[] __initconst = {
+ { .compatible = "mediatek,mt6582", .data = &mtk_mt7623_boot },
{ .compatible = "mediatek,mt6589", .data = &mtk_mt6589_boot },
{ .compatible = "mediatek,mt7623", .data = &mtk_mt7623_boot },
{ .compatible = "mediatek,mt7629", .data = &mtk_mt7623_boot },
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582
@ 2021-12-30 15:51 ` Maxim Kutnij
0 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2021-12-30 15:51 UTC (permalink / raw)
To: Matthias Brugger, Russell King
Cc: Maxim Kutnij, linux-arm-kernel, linux-mediatek, linux-kernel
This patch adds support SMP on MediaTek MT6582 Cortex-A7 quad core SoC.
Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
---
arch/arm/mach-mediatek/mediatek.c | 4 +++-
arch/arm/mach-mediatek/platsmp.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
index e6e9f93a1f0..aefeb661405 100644
--- a/arch/arm/mach-mediatek/mediatek.c
+++ b/arch/arm/mach-mediatek/mediatek.c
@@ -20,7 +20,8 @@ static void __init mediatek_timer_init(void)
{
void __iomem *gpt_base;
- if (of_machine_is_compatible("mediatek,mt6589") ||
+ if (of_machine_is_compatible("mediatek,mt6582") ||
+ of_machine_is_compatible("mediatek,mt6589") ||
of_machine_is_compatible("mediatek,mt7623") ||
of_machine_is_compatible("mediatek,mt8135") ||
of_machine_is_compatible("mediatek,mt8127")) {
@@ -38,6 +39,7 @@ static void __init mediatek_timer_init(void)
static const char * const mediatek_board_dt_compat[] = {
"mediatek,mt2701",
+ "mediatek,mt6582",
"mediatek,mt6589",
"mediatek,mt6592",
"mediatek,mt7623",
diff --git a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c
index 16a4ee6c959..e1c7ad52f77 100644
--- a/arch/arm/mach-mediatek/platsmp.c
+++ b/arch/arm/mach-mediatek/platsmp.c
@@ -49,6 +49,7 @@ static const struct of_device_id mtk_tz_smp_boot_infos[] __initconst = {
};
static const struct of_device_id mtk_smp_boot_infos[] __initconst = {
+ { .compatible = "mediatek,mt6582", .data = &mtk_mt7623_boot },
{ .compatible = "mediatek,mt6589", .data = &mtk_mt6589_boot },
{ .compatible = "mediatek,mt7623", .data = &mtk_mt7623_boot },
{ .compatible = "mediatek,mt7629", .data = &mtk_mt7623_boot },
--
2.34.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
2021-12-30 15:51 ` Maxim Kutnij
(?)
@ 2021-12-30 15:51 ` Maxim Kutnij
-1 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2021-12-30 15:51 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Maxim Kutnij, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
---
arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
index 4263371784c..5efcbf43325 100644
--- a/arch/arm/boot/dts/mt6582.dtsi
+++ b/arch/arm/boot/dts/mt6582.dtsi
@@ -15,29 +15,43 @@ / {
cpus {
#address-cells = <1>;
#size-cells = <0>;
+ enable-method = "mediatek,mt6589-smp";
- cpu@0 {
+ cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x0>;
+ clock-frequency = <1300000000>;
};
- cpu@1 {
+ cpu1: cpu@1 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x1>;
+ clock-frequency = <1300000000>;
};
- cpu@2 {
+ cpu2: cpu@2 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x2>;
+ clock-frequency = <1300000000>;
};
- cpu@3 {
+ cpu3: cpu@3 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x3>;
+ clock-frequency = <1300000000>;
};
};
+ pmu {
+ compatible = "arm,cortex-a7-pmu";
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
+ };
+
system_clk: dummy13m {
compatible = "fixed-clock";
clock-frequency = <13000000>;
@@ -56,7 +70,18 @@ uart_clk: dummy26m {
#clock-cells = <0>;
};
- timer: timer@11008000 {
+ timer {
+ compatible = "arm,armv7-timer";
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+ clock-frequency = <13000000>;
+ arm,cpu-registers-not-fw-configured;
+ };
+
+ timer: timer@10008000 {
compatible = "mediatek,mt6577-timer";
reg = <0x10008000 0x80>;
interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
@ 2021-12-30 15:51 ` Maxim Kutnij
0 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2021-12-30 15:51 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Maxim Kutnij, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
---
arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
index 4263371784c..5efcbf43325 100644
--- a/arch/arm/boot/dts/mt6582.dtsi
+++ b/arch/arm/boot/dts/mt6582.dtsi
@@ -15,29 +15,43 @@ / {
cpus {
#address-cells = <1>;
#size-cells = <0>;
+ enable-method = "mediatek,mt6589-smp";
- cpu@0 {
+ cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x0>;
+ clock-frequency = <1300000000>;
};
- cpu@1 {
+ cpu1: cpu@1 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x1>;
+ clock-frequency = <1300000000>;
};
- cpu@2 {
+ cpu2: cpu@2 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x2>;
+ clock-frequency = <1300000000>;
};
- cpu@3 {
+ cpu3: cpu@3 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x3>;
+ clock-frequency = <1300000000>;
};
};
+ pmu {
+ compatible = "arm,cortex-a7-pmu";
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
+ };
+
system_clk: dummy13m {
compatible = "fixed-clock";
clock-frequency = <13000000>;
@@ -56,7 +70,18 @@ uart_clk: dummy26m {
#clock-cells = <0>;
};
- timer: timer@11008000 {
+ timer {
+ compatible = "arm,armv7-timer";
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+ clock-frequency = <13000000>;
+ arm,cpu-registers-not-fw-configured;
+ };
+
+ timer: timer@10008000 {
compatible = "mediatek,mt6577-timer";
reg = <0x10008000 0x80>;
interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
@ 2021-12-30 15:51 ` Maxim Kutnij
0 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2021-12-30 15:51 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger
Cc: Maxim Kutnij, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
---
arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
index 4263371784c..5efcbf43325 100644
--- a/arch/arm/boot/dts/mt6582.dtsi
+++ b/arch/arm/boot/dts/mt6582.dtsi
@@ -15,29 +15,43 @@ / {
cpus {
#address-cells = <1>;
#size-cells = <0>;
+ enable-method = "mediatek,mt6589-smp";
- cpu@0 {
+ cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x0>;
+ clock-frequency = <1300000000>;
};
- cpu@1 {
+ cpu1: cpu@1 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x1>;
+ clock-frequency = <1300000000>;
};
- cpu@2 {
+ cpu2: cpu@2 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x2>;
+ clock-frequency = <1300000000>;
};
- cpu@3 {
+ cpu3: cpu@3 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x3>;
+ clock-frequency = <1300000000>;
};
};
+ pmu {
+ compatible = "arm,cortex-a7-pmu";
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
+ };
+
system_clk: dummy13m {
compatible = "fixed-clock";
clock-frequency = <13000000>;
@@ -56,7 +70,18 @@ uart_clk: dummy26m {
#clock-cells = <0>;
};
- timer: timer@11008000 {
+ timer {
+ compatible = "arm,armv7-timer";
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+ clock-frequency = <13000000>;
+ arm,cpu-registers-not-fw-configured;
+ };
+
+ timer: timer@10008000 {
compatible = "mediatek,mt6577-timer";
reg = <0x10008000 0x80>;
interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
--
2.34.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
2021-12-30 15:51 ` Maxim Kutnij
(?)
@ 2021-12-31 15:51 ` Matthias Brugger
-1 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2021-12-31 15:51 UTC (permalink / raw)
To: Maxim Kutnij, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 12/30/21 16:51, Maxim Kutnij wrote:
> This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
>
> Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
> ---
> arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
> 1 file changed, 30 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
> index 4263371784c..5efcbf43325 100644
> --- a/arch/arm/boot/dts/mt6582.dtsi
> +++ b/arch/arm/boot/dts/mt6582.dtsi
> @@ -15,29 +15,43 @@ / {
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> + enable-method = "mediatek,mt6589-smp";
>
> - cpu@0 {
> + cpu0: cpu@0 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x0>;
> + clock-frequency = <1300000000>;
What do we need the clock-frequency for? I wasn't able to figure that
out right now.
Other then that patches look good.
Regards,
Matthias
> };
> - cpu@1 {
> + cpu1: cpu@1 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x1>;
> + clock-frequency = <1300000000>;
> };
> - cpu@2 {
> + cpu2: cpu@2 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x2>;
> + clock-frequency = <1300000000>;
> };
> - cpu@3 {
> + cpu3: cpu@3 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x3>;
> + clock-frequency = <1300000000>;
> };
> };
>
> + pmu {
> + compatible = "arm,cortex-a7-pmu";
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> + };
> +
> system_clk: dummy13m {
> compatible = "fixed-clock";
> clock-frequency = <13000000>;
> @@ -56,7 +70,18 @@ uart_clk: dummy26m {
> #clock-cells = <0>;
> };
>
> - timer: timer@11008000 {
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + clock-frequency = <13000000>;
> + arm,cpu-registers-not-fw-configured;
> + };
> +
> + timer: timer@10008000 {
> compatible = "mediatek,mt6577-timer";
> reg = <0x10008000 0x80>;
> interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
@ 2021-12-31 15:51 ` Matthias Brugger
0 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2021-12-31 15:51 UTC (permalink / raw)
To: Maxim Kutnij, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 12/30/21 16:51, Maxim Kutnij wrote:
> This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
>
> Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
> ---
> arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
> 1 file changed, 30 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
> index 4263371784c..5efcbf43325 100644
> --- a/arch/arm/boot/dts/mt6582.dtsi
> +++ b/arch/arm/boot/dts/mt6582.dtsi
> @@ -15,29 +15,43 @@ / {
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> + enable-method = "mediatek,mt6589-smp";
>
> - cpu@0 {
> + cpu0: cpu@0 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x0>;
> + clock-frequency = <1300000000>;
What do we need the clock-frequency for? I wasn't able to figure that
out right now.
Other then that patches look good.
Regards,
Matthias
> };
> - cpu@1 {
> + cpu1: cpu@1 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x1>;
> + clock-frequency = <1300000000>;
> };
> - cpu@2 {
> + cpu2: cpu@2 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x2>;
> + clock-frequency = <1300000000>;
> };
> - cpu@3 {
> + cpu3: cpu@3 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x3>;
> + clock-frequency = <1300000000>;
> };
> };
>
> + pmu {
> + compatible = "arm,cortex-a7-pmu";
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> + };
> +
> system_clk: dummy13m {
> compatible = "fixed-clock";
> clock-frequency = <13000000>;
> @@ -56,7 +70,18 @@ uart_clk: dummy26m {
> #clock-cells = <0>;
> };
>
> - timer: timer@11008000 {
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + clock-frequency = <13000000>;
> + arm,cpu-registers-not-fw-configured;
> + };
> +
> + timer: timer@10008000 {
> compatible = "mediatek,mt6577-timer";
> reg = <0x10008000 0x80>;
> interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
@ 2021-12-31 15:51 ` Matthias Brugger
0 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2021-12-31 15:51 UTC (permalink / raw)
To: Maxim Kutnij, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 12/30/21 16:51, Maxim Kutnij wrote:
> This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
>
> Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
> ---
> arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++-----
> 1 file changed, 30 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt6582.dtsi b/arch/arm/boot/dts/mt6582.dtsi
> index 4263371784c..5efcbf43325 100644
> --- a/arch/arm/boot/dts/mt6582.dtsi
> +++ b/arch/arm/boot/dts/mt6582.dtsi
> @@ -15,29 +15,43 @@ / {
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> + enable-method = "mediatek,mt6589-smp";
>
> - cpu@0 {
> + cpu0: cpu@0 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x0>;
> + clock-frequency = <1300000000>;
What do we need the clock-frequency for? I wasn't able to figure that
out right now.
Other then that patches look good.
Regards,
Matthias
> };
> - cpu@1 {
> + cpu1: cpu@1 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x1>;
> + clock-frequency = <1300000000>;
> };
> - cpu@2 {
> + cpu2: cpu@2 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x2>;
> + clock-frequency = <1300000000>;
> };
> - cpu@3 {
> + cpu3: cpu@3 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x3>;
> + clock-frequency = <1300000000>;
> };
> };
>
> + pmu {
> + compatible = "arm,cortex-a7-pmu";
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> + };
> +
> system_clk: dummy13m {
> compatible = "fixed-clock";
> clock-frequency = <13000000>;
> @@ -56,7 +70,18 @@ uart_clk: dummy26m {
> #clock-cells = <0>;
> };
>
> - timer: timer@11008000 {
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + clock-frequency = <13000000>;
> + arm,cpu-registers-not-fw-configured;
> + };
> +
> + timer: timer@10008000 {
> compatible = "mediatek,mt6577-timer";
> reg = <0x10008000 0x80>;
> interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582
2021-12-30 15:51 ` Maxim Kutnij
(?)
@ 2022-01-01 13:05 ` Maxim Kutnij
-1 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2022-01-01 13:05 UTC (permalink / raw)
To: gtk3, Matthias Brugger
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, linux, Rob Herring
On Fri, 31 Dec 2021 16:51:20 +0100, Matthias Brugger wrote:
>What do we need the clock-frequency for? I wasn't able to figure that
>out right now.
>
>Other then that patches look good.
>
>Regards,
>Matthias
I thought it might be useful in the future. But if not, then I will remove it in the next patch.
Maxim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582
@ 2022-01-01 13:05 ` Maxim Kutnij
0 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2022-01-01 13:05 UTC (permalink / raw)
To: gtk3, Matthias Brugger
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, linux, Rob Herring
On Fri, 31 Dec 2021 16:51:20 +0100, Matthias Brugger wrote:
>What do we need the clock-frequency for? I wasn't able to figure that
>out right now.
>
>Other then that patches look good.
>
>Regards,
>Matthias
I thought it might be useful in the future. But if not, then I will remove it in the next patch.
Maxim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM: mediatek: add smp bringup code for MT6582
@ 2022-01-01 13:05 ` Maxim Kutnij
0 siblings, 0 replies; 12+ messages in thread
From: Maxim Kutnij @ 2022-01-01 13:05 UTC (permalink / raw)
To: gtk3, Matthias Brugger
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, linux, Rob Herring
On Fri, 31 Dec 2021 16:51:20 +0100, Matthias Brugger wrote:
>What do we need the clock-frequency for? I wasn't able to figure that
>out right now.
>
>Other then that patches look good.
>
>Regards,
>Matthias
I thought it might be useful in the future. But if not, then I will remove it in the next patch.
Maxim
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread