* [PATCH] fs/ntfs3: remove redundant assignment to variable frame
@ 2021-12-30 15:59 Colin Ian King
2022-06-07 16:22 ` Konstantin Komarov
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-12-30 15:59 UTC (permalink / raw)
To: Konstantin Komarov, ntfs3; +Cc: kernel-janitors, linux-kernel, llvm
Variable frame is assigned a value that is never read. The
assignment is redundant and can be removed. Cleans up the
clang-scan build warning:
fs/ntfs3/file.c:995:3: warning: Value stored to 'frame' is
never read [deadcode.DeadStores]
frame = pos >> frame_bits;
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ntfs3/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index 3bae76930e68..27c32692513c 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -992,7 +992,6 @@ static ssize_t ntfs_compress_write(struct kiocb *iocb, struct iov_iter *from)
if (bytes > count)
bytes = count;
- frame = pos >> frame_bits;
frame_vbo = pos & ~(frame_size - 1);
index = frame_vbo >> PAGE_SHIFT;
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/ntfs3: remove redundant assignment to variable frame
2021-12-30 15:59 [PATCH] fs/ntfs3: remove redundant assignment to variable frame Colin Ian King
@ 2022-06-07 16:22 ` Konstantin Komarov
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2022-06-07 16:22 UTC (permalink / raw)
To: Colin Ian King, ntfs3; +Cc: kernel-janitors, linux-kernel, llvm
On 12/30/21 18:59, Colin Ian King wrote:
> Variable frame is assigned a value that is never read. The
> assignment is redundant and can be removed. Cleans up the
> clang-scan build warning:
>
> fs/ntfs3/file.c:995:3: warning: Value stored to 'frame' is
> never read [deadcode.DeadStores]
> frame = pos >> frame_bits;
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/ntfs3/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 3bae76930e68..27c32692513c 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -992,7 +992,6 @@ static ssize_t ntfs_compress_write(struct kiocb *iocb, struct iov_iter *from)
> if (bytes > count)
> bytes = count;
>
> - frame = pos >> frame_bits;
> frame_vbo = pos & ~(frame_size - 1);
> index = frame_vbo >> PAGE_SHIFT;
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-07 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 15:59 [PATCH] fs/ntfs3: remove redundant assignment to variable frame Colin Ian King
2022-06-07 16:22 ` Konstantin Komarov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.