From: "Guilherme G. Piccoli" <gpiccoli@igalia.com> To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: gpiccoli@igalia.com, kernel@gpiccoli.net, pmladek@suse.com, senozhatsky@chromium.org, rostedt@goodmis.org, john.ogness@linutronix.de, feng.tang@intel.com, kexec@lists.infradead.org, dyoung@redhat.com, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com Subject: [PATCH] panic: Move panic_print before kmsg dumpers Date: Thu, 30 Dec 2021 13:18:28 -0300 [thread overview] Message-ID: <20211230161828.121858-1-gpiccoli@igalia.com> (raw) The panic_print setting allows users to collect more information in a panic event, like memory stats, tasks, CPUs backtraces, etc. This is a pretty interesting debug mechanism, but currently the print event happens *after* kmsg_dump(), meaning that Pstore, for example, cannot collect a dmesg with the panic_print information. This patch changes that by moving the panic_print_sys_info() function call up some lines, in order kmsg_dump() accounts this new information and exposes it through Pstore or other kmsg dumpers. Cc: Feng Tang <feng.tang@intel.com> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> --- Hey folks, thanks in advance for reviews/comments! One alternative I've considered was to move kmsg_dump() some lines down, I'm not sure which approach is better, can't see much difference. Opinions are very welcome =) Cheers, Guilherme kernel/panic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index cefd7d82366f..d918da0a1c29 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -271,6 +271,8 @@ void panic(const char *fmt, ...) */ atomic_notifier_call_chain(&panic_notifier_list, 0, buf); + panic_print_sys_info(); + kmsg_dump(KMSG_DUMP_PANIC); /* @@ -301,8 +303,6 @@ void panic(const char *fmt, ...) debug_locks_off(); console_flush_on_panic(CONSOLE_FLUSH_PENDING); - panic_print_sys_info(); - if (!panic_blink) panic_blink = no_blink; -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com> To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: gpiccoli@igalia.com, kernel@gpiccoli.net, pmladek@suse.com, senozhatsky@chromium.org, rostedt@goodmis.org, john.ogness@linutronix.de, feng.tang@intel.com, kexec@lists.infradead.org, dyoung@redhat.com, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com Subject: [PATCH] panic: Move panic_print before kmsg dumpers Date: Thu, 30 Dec 2021 13:18:28 -0300 [thread overview] Message-ID: <20211230161828.121858-1-gpiccoli@igalia.com> (raw) The panic_print setting allows users to collect more information in a panic event, like memory stats, tasks, CPUs backtraces, etc. This is a pretty interesting debug mechanism, but currently the print event happens *after* kmsg_dump(), meaning that Pstore, for example, cannot collect a dmesg with the panic_print information. This patch changes that by moving the panic_print_sys_info() function call up some lines, in order kmsg_dump() accounts this new information and exposes it through Pstore or other kmsg dumpers. Cc: Feng Tang <feng.tang@intel.com> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> --- Hey folks, thanks in advance for reviews/comments! One alternative I've considered was to move kmsg_dump() some lines down, I'm not sure which approach is better, can't see much difference. Opinions are very welcome =) Cheers, Guilherme kernel/panic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index cefd7d82366f..d918da0a1c29 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -271,6 +271,8 @@ void panic(const char *fmt, ...) */ atomic_notifier_call_chain(&panic_notifier_list, 0, buf); + panic_print_sys_info(); + kmsg_dump(KMSG_DUMP_PANIC); /* @@ -301,8 +303,6 @@ void panic(const char *fmt, ...) debug_locks_off(); console_flush_on_panic(CONSOLE_FLUSH_PENDING); - panic_print_sys_info(); - if (!panic_blink) panic_blink = no_blink; -- 2.34.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2021-12-30 16:19 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-30 16:18 Guilherme G. Piccoli [this message] 2021-12-30 16:18 ` [PATCH] panic: Move panic_print before kmsg dumpers Guilherme G. Piccoli 2022-01-03 14:58 ` Petr Mladek 2022-01-03 14:58 ` Petr Mladek 2022-01-03 16:30 ` Guilherme G. Piccoli 2022-01-03 16:30 ` Guilherme G. Piccoli 2022-01-04 11:45 ` Petr Mladek 2022-01-04 11:45 ` Petr Mladek 2022-01-04 12:35 ` Guilherme G. Piccoli 2022-01-04 12:35 ` Guilherme G. Piccoli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211230161828.121858-1-gpiccoli@igalia.com \ --to=gpiccoli@igalia.com \ --cc=akpm@linux-foundation.org \ --cc=anton@enomsg.org \ --cc=ccross@android.com \ --cc=dyoung@redhat.com \ --cc=feng.tang@intel.com \ --cc=john.ogness@linutronix.de \ --cc=keescook@chromium.org \ --cc=kernel@gpiccoli.net \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=senozhatsky@chromium.org \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.