* [linux-next:master 3790/9897] drivers/gpu/drm/i915/i915_vma_snapshot.c:64:17: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc]
@ 2022-01-03 4:58 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-01-03 4:58 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 15667 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
CC: Ramalingam C <ramalingam.c@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: ea586a076e8aa606c59b66d86660590f18354b11
commit: ff20afc4cee7b65f752b1da6d5da4c0bea1431b9 [3790/9897] drm/i915: Update error capture code to avoid using the current vma state
:::::: branch date: 10 days ago
:::::: commit date: 5 weeks ago
config: i386-randconfig-c001-20211207 (https://download.01.org/0day-ci/archive/20220103/202201031211.QpQPHUFA-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ff20afc4cee7b65f752b1da6d5da4c0bea1431b9
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ff20afc4cee7b65f752b1da6d5da4c0bea1431b9
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^
include/asm-generic/bug.h:65:32: note: expanded from macro 'BUG_ON'
#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^
include/linux/compiler.h:56:23: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
drivers/tty/tty_ldisc.c:674:3: note: Loop condition is false. Exiting loop
BUG_ON(disc == N_TTY);
^
include/asm-generic/bug.h:65:27: note: expanded from macro 'BUG_ON'
#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^
drivers/tty/tty_ldisc.c:747:13: note: Returned allocated memory
WARN_ON(tty_ldisc_reinit(tty, N_NULL) < 0);
^
include/asm-generic/bug.h:121:25: note: expanded from macro 'WARN_ON'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
drivers/tty/tty_ldisc.c:747:5: note: Potential memory leak
WARN_ON(tty_ldisc_reinit(tty, N_NULL) < 0);
^
include/asm-generic/bug.h:121:2: note: expanded from macro 'WARN_ON'
int __ret_warn_on = !!(condition); \
^
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
lib/glob.c:48:32: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign]
char const *back_pat = NULL, *back_str = back_str;
^ ~~~~~~~~
lib/glob.c:48:32: note: Assigned value is garbage or undefined
char const *back_pat = NULL, *back_str = back_str;
^ ~~~~~~~~
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
drivers/regulator/palmas-regulator.c:1598:36: warning: Value stored to 'pdata' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
struct palmas_pmic_platform_data *pdata = dev_get_platdata(&pdev->dev);
^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/palmas-regulator.c:1598:36: note: Value stored to 'pdata' during its initialization is never read
struct palmas_pmic_platform_data *pdata = dev_get_platdata(&pdev->dev);
^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (2 in non-user code, 3 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
Suppressed 3 warnings (2 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
Suppressed 2 warnings (2 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
>> drivers/gpu/drm/i915/i915_vma_snapshot.c:64:17: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc]
vsnap->present = false;
^
drivers/gpu/drm/i915/i915_vma_snapshot.c:92:7: note: Calling 'kref_put'
if (!kref_put(&vsnap->kref, vma_snapshot_release))
^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
include/linux/kref.h:64:2: note: '?' condition is false
if (refcount_dec_and_test(&kref->refcount)) {
^
include/linux/compiler.h:56:28: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
include/linux/compiler.h:58:31: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^
include/linux/kref.h:64:2: note: '?' condition is true
if (refcount_dec_and_test(&kref->refcount)) {
^
include/linux/compiler.h:56:28: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
include/linux/compiler.h:58:69: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^
include/linux/compiler.h:69:2: note: expanded from macro '__trace_if_value'
(cond) ? \
^
include/linux/kref.h:64:2: note: Taking true branch
if (refcount_dec_and_test(&kref->refcount)) {
^
include/linux/compiler.h:56:23: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
include/linux/kref.h:65:3: note: Calling 'vma_snapshot_release'
release(kref);
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_vma_snapshot.c:65:2: note: Assuming field 'pages_rsgt' is null
if (vsnap->pages_rsgt)
^
include/linux/compiler.h:56:45: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/gpu/drm/i915/i915_vma_snapshot.c:65:2: note: '?' condition is false
if (vsnap->pages_rsgt)
^
include/linux/compiler.h:56:28: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
include/linux/compiler.h:58:31: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^
drivers/gpu/drm/i915/i915_vma_snapshot.c:65:13: note: Field 'pages_rsgt' is null
if (vsnap->pages_rsgt)
^
drivers/gpu/drm/i915/i915_vma_snapshot.c:65:2: note: '?' condition is false
if (vsnap->pages_rsgt)
^
include/linux/compiler.h:56:28: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
include/linux/compiler.h:58:69: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^
include/linux/compiler.h:69:2: note: expanded from macro '__trace_if_value'
(cond) ? \
^
drivers/gpu/drm/i915/i915_vma_snapshot.c:65:2: note: Taking false branch
if (vsnap->pages_rsgt)
^
include/linux/compiler.h:56:23: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
drivers/gpu/drm/i915/i915_vma_snapshot.c:67:6: note: Assuming field 'onstack' is false
if (!vsnap->onstack)
^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/gpu/drm/i915/i915_vma_snapshot.c:67:2: note: '?' condition is false
if (!vsnap->onstack)
^
include/linux/compiler.h:56:28: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^
include/linux/compiler.h:58:31: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^
drivers/gpu/drm/i915/i915_vma_snapshot.c:67:14: note: Field 'onstack' is false
if (!vsnap->onstack)
vim +64 drivers/gpu/drm/i915/i915_vma_snapshot.c
ff20afc4cee7b6 Thomas Hellström 2021-11-29 58
ff20afc4cee7b6 Thomas Hellström 2021-11-29 59 static void vma_snapshot_release(struct kref *ref)
ff20afc4cee7b6 Thomas Hellström 2021-11-29 60 {
ff20afc4cee7b6 Thomas Hellström 2021-11-29 61 struct i915_vma_snapshot *vsnap =
ff20afc4cee7b6 Thomas Hellström 2021-11-29 62 container_of(ref, typeof(*vsnap), kref);
ff20afc4cee7b6 Thomas Hellström 2021-11-29 63
ff20afc4cee7b6 Thomas Hellström 2021-11-29 @64 vsnap->present = false;
ff20afc4cee7b6 Thomas Hellström 2021-11-29 65 if (vsnap->pages_rsgt)
ff20afc4cee7b6 Thomas Hellström 2021-11-29 66 i915_refct_sgt_put(vsnap->pages_rsgt);
ff20afc4cee7b6 Thomas Hellström 2021-11-29 67 if (!vsnap->onstack)
ff20afc4cee7b6 Thomas Hellström 2021-11-29 68 kfree(vsnap);
ff20afc4cee7b6 Thomas Hellström 2021-11-29 69 }
ff20afc4cee7b6 Thomas Hellström 2021-11-29 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-01-03 4:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03 4:58 [linux-next:master 3790/9897] drivers/gpu/drm/i915/i915_vma_snapshot.c:64:17: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc] kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.