* [PATCH net] ipv6: Do cleanup if attribute validation fails in multipath route
@ 2022-01-03 17:05 David Ahern
2022-01-03 17:29 ` Nicolas Dichtel
2022-01-03 18:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2022-01-03 17:05 UTC (permalink / raw)
To: netdev; +Cc: David Ahern, Nicolas Dichtel
As Nicolas noted, if gateway validation fails walking the multipath
attribute the code should jump to the cleanup to free previously
allocated memory.
Fixes: 23fb261977fd ("ipv6: Check attribute length for RTA_GATEWAY in multipath route")
Signed-off-by: David Ahern <dsahern@kernel.org>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/ipv6/route.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index d2ff8a7e1709..3f36f9603f00 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -5277,12 +5277,10 @@ static int ip6_route_multipath_add(struct fib6_config *cfg,
nla = nla_find(attrs, attrlen, RTA_GATEWAY);
if (nla) {
- int ret;
-
- ret = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
+ err = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
extack);
- if (ret)
- return ret;
+ if (err)
+ goto cleanup;
r_cfg.fc_flags |= RTF_GATEWAY;
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: Do cleanup if attribute validation fails in multipath route
2022-01-03 17:05 [PATCH net] ipv6: Do cleanup if attribute validation fails in multipath route David Ahern
@ 2022-01-03 17:29 ` Nicolas Dichtel
2022-01-03 18:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2022-01-03 17:29 UTC (permalink / raw)
To: David Ahern, netdev
Le 03/01/2022 à 18:05, David Ahern a écrit :
> As Nicolas noted, if gateway validation fails walking the multipath
> attribute the code should jump to the cleanup to free previously
> allocated memory.
>
> Fixes: 23fb261977fd ("ipv6: Check attribute length for RTA_GATEWAY in multipath route")
> Signed-off-by: David Ahern <dsahern@kernel.org>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: Do cleanup if attribute validation fails in multipath route
2022-01-03 17:05 [PATCH net] ipv6: Do cleanup if attribute validation fails in multipath route David Ahern
2022-01-03 17:29 ` Nicolas Dichtel
@ 2022-01-03 18:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-03 18:10 UTC (permalink / raw)
To: David Ahern; +Cc: netdev, nicolas.dichtel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 3 Jan 2022 10:05:55 -0700 you wrote:
> As Nicolas noted, if gateway validation fails walking the multipath
> attribute the code should jump to the cleanup to free previously
> allocated memory.
>
> Fixes: 23fb261977fd ("ipv6: Check attribute length for RTA_GATEWAY in multipath route")
> Signed-off-by: David Ahern <dsahern@kernel.org>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> [...]
Here is the summary with links:
- [net] ipv6: Do cleanup if attribute validation fails in multipath route
https://git.kernel.org/netdev/net/c/95bdba23b5b4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-03 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03 17:05 [PATCH net] ipv6: Do cleanup if attribute validation fails in multipath route David Ahern
2022-01-03 17:29 ` Nicolas Dichtel
2022-01-03 18:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.