* [PATCH net] ipv6: Continue processing multipath route even if gateway attribute is invalid
@ 2022-01-03 17:19 David Ahern
2022-01-03 17:31 ` Nicolas Dichtel
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2022-01-03 17:19 UTC (permalink / raw)
To: netdev; +Cc: David Ahern, Nicolas Dichtel
ip6_route_multipath_del loop continues processing the multipath
attribute even if delete of a nexthop path fails. For consistency,
do the same if the gateway attribute is invalid.
Fixes: d5297ac885b5 ("ipv6: Check attribute length for RTA_GATEWAY when deleting multipath route")
Signed-off-by: David Ahern <dsahern@kernel.org>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/ipv6/route.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 3f36f9603f00..1deb6297aab6 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -5457,8 +5457,10 @@ static int ip6_route_multipath_del(struct fib6_config *cfg,
if (nla) {
err = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
extack);
- if (err)
- return err;
+ if (err) {
+ last_err = err;
+ goto next_rtnh;
+ }
r_cfg.fc_flags |= RTF_GATEWAY;
}
@@ -5467,6 +5469,7 @@ static int ip6_route_multipath_del(struct fib6_config *cfg,
if (err)
last_err = err;
+next_rtnh:
rtnh = rtnh_next(rtnh, &remaining);
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: Continue processing multipath route even if gateway attribute is invalid
2022-01-03 17:19 [PATCH net] ipv6: Continue processing multipath route even if gateway attribute is invalid David Ahern
@ 2022-01-03 17:31 ` Nicolas Dichtel
2022-01-03 18:02 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dichtel @ 2022-01-03 17:31 UTC (permalink / raw)
To: David Ahern, netdev
Le 03/01/2022 à 18:19, David Ahern a écrit :
> ip6_route_multipath_del loop continues processing the multipath
> attribute even if delete of a nexthop path fails. For consistency,
> do the same if the gateway attribute is invalid.
>
> Fixes: d5297ac885b5 ("ipv6: Check attribute length for RTA_GATEWAY when deleting multipath route")
> Signed-off-by: David Ahern <dsahern@kernel.org>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Thanks for the follow up.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: Continue processing multipath route even if gateway attribute is invalid
2022-01-03 17:31 ` Nicolas Dichtel
@ 2022-01-03 18:02 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-01-03 18:02 UTC (permalink / raw)
To: Nicolas Dichtel, David Ahern; +Cc: netdev
On Mon, 3 Jan 2022 18:31:03 +0100 Nicolas Dichtel wrote:
> Le 03/01/2022 à 18:19, David Ahern a écrit :
> > ip6_route_multipath_del loop continues processing the multipath
> > attribute even if delete of a nexthop path fails. For consistency,
> > do the same if the gateway attribute is invalid.
> >
> > Fixes: d5297ac885b5 ("ipv6: Check attribute length for RTA_GATEWAY when deleting multipath route")
> > Signed-off-by: David Ahern <dsahern@kernel.org>
> > Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Fixed the commit ID and applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-03 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03 17:19 [PATCH net] ipv6: Continue processing multipath route even if gateway attribute is invalid David Ahern
2022-01-03 17:31 ` Nicolas Dichtel
2022-01-03 18:02 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.