* [PATCH v2 01/22] ata: sata_fsl: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:28 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 02/22] ata: ahci_brcm: " Damien Le Moal
` (20 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add dependendy on COMPILE_TEST to allow compile tests with configs that
do not enable FSL_SOC.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9ebaa3c288dd..80bad7cba631 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -290,7 +290,7 @@ config AHCI_QORIQ
config SATA_FSL
tristate "Freescale 3.0Gbps SATA support"
- depends on FSL_SOC
+ depends on FSL_SOC || COMPILE_TEST
select SATA_HOST
help
This option enables support for Freescale 3.0Gbps SATA controller.
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 01/22] ata: sata_fsl: add compile test support
2022-01-04 10:58 ` [PATCH v2 01/22] ata: sata_fsl: add compile test support Damien Le Moal
@ 2022-01-04 11:28 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:28 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add dependendy on COMPILE_TEST to allow compile tests with configs that
> do not enable FSL_SOC.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 9ebaa3c288dd..80bad7cba631 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -290,7 +290,7 @@ config AHCI_QORIQ
>
> config SATA_FSL
> tristate "Freescale 3.0Gbps SATA support"
> - depends on FSL_SOC
> + depends on FSL_SOC || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for Freescale 3.0Gbps SATA controller.
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 02/22] ata: ahci_brcm: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
2022-01-04 10:58 ` [PATCH v2 01/22] ata: sata_fsl: add compile test support Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:28 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 03/22] ata: ahci_da850: " Damien Le Moal
` (19 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_BRCMSTB, BMIPS_GENERIC or ARCH_BCM_XXX.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 80bad7cba631..3bf38a328851 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -163,7 +163,7 @@ config SATA_AHCI_PLATFORM
config AHCI_BRCM
tristate "Broadcom AHCI SATA support"
depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_NSP || \
- ARCH_BCM_63XX
+ ARCH_BCM_63XX || COMPILE_TEST
select SATA_HOST
help
This option enables support for the AHCI SATA3 controller found on
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 02/22] ata: ahci_brcm: add compile test support
2022-01-04 10:58 ` [PATCH v2 02/22] ata: ahci_brcm: " Damien Le Moal
@ 2022-01-04 11:28 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:28 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_BRCMSTB, BMIPS_GENERIC or ARCH_BCM_XXX.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 80bad7cba631..3bf38a328851 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -163,7 +163,7 @@ config SATA_AHCI_PLATFORM
> config AHCI_BRCM
> tristate "Broadcom AHCI SATA support"
> depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_NSP || \
> - ARCH_BCM_63XX
> + ARCH_BCM_63XX || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the AHCI SATA3 controller found on
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 03/22] ata: ahci_da850: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
2022-01-04 10:58 ` [PATCH v2 01/22] ata: sata_fsl: add compile test support Damien Le Moal
2022-01-04 10:58 ` [PATCH v2 02/22] ata: ahci_brcm: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:29 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 04/22] ata: ahci_dm816: " Damien Le Moal
` (18 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_DAVINCI_DA850.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3bf38a328851..9f1288fd5482 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -173,7 +173,7 @@ config AHCI_BRCM
config AHCI_DA850
tristate "DaVinci DA850 AHCI SATA support"
- depends on ARCH_DAVINCI_DA850
+ depends on ARCH_DAVINCI_DA850 || COMPILE_TEST
select SATA_HOST
help
This option enables support for the DaVinci DA850 SoC's
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 03/22] ata: ahci_da850: add compile test support
2022-01-04 10:58 ` [PATCH v2 03/22] ata: ahci_da850: " Damien Le Moal
@ 2022-01-04 11:29 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:29 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_DAVINCI_DA850.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 3bf38a328851..9f1288fd5482 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -173,7 +173,7 @@ config AHCI_BRCM
>
> config AHCI_DA850
> tristate "DaVinci DA850 AHCI SATA support"
> - depends on ARCH_DAVINCI_DA850
> + depends on ARCH_DAVINCI_DA850 || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the DaVinci DA850 SoC's
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 04/22] ata: ahci_dm816: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (2 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 03/22] ata: ahci_da850: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:29 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 05/22] ata: ahci_st: " Damien Le Moal
` (17 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_OMAP2PLUS.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9f1288fd5482..e9f919f17d09 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -183,7 +183,7 @@ config AHCI_DA850
config AHCI_DM816
tristate "DaVinci DM816 AHCI SATA support"
- depends on ARCH_OMAP2PLUS
+ depends on ARCH_OMAP2PLUS || COMPILE_TEST
select SATA_HOST
help
This option enables support for the DaVinci DM816 SoC's
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 04/22] ata: ahci_dm816: add compile test support
2022-01-04 10:58 ` [PATCH v2 04/22] ata: ahci_dm816: " Damien Le Moal
@ 2022-01-04 11:29 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:29 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_OMAP2PLUS.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 9f1288fd5482..e9f919f17d09 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -183,7 +183,7 @@ config AHCI_DA850
>
> config AHCI_DM816
> tristate "DaVinci DM816 AHCI SATA support"
> - depends on ARCH_OMAP2PLUS
> + depends on ARCH_OMAP2PLUS || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the DaVinci DM816 SoC's
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 05/22] ata: ahci_st: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (3 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 04/22] ata: ahci_dm816: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:29 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 06/22] ata: ahci_mtk: " Damien Le Moal
` (16 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_STI.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e9f919f17d09..83fac101744c 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -193,7 +193,7 @@ config AHCI_DM816
config AHCI_ST
tristate "ST AHCI SATA support"
- depends on ARCH_STI
+ depends on ARCH_STI || COMPILE_TEST
select SATA_HOST
help
This option enables support for ST AHCI SATA controller.
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 05/22] ata: ahci_st: add compile test support
2022-01-04 10:58 ` [PATCH v2 05/22] ata: ahci_st: " Damien Le Moal
@ 2022-01-04 11:29 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:29 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_STI.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index e9f919f17d09..83fac101744c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -193,7 +193,7 @@ config AHCI_DM816
>
> config AHCI_ST
> tristate "ST AHCI SATA support"
> - depends on ARCH_STI
> + depends on ARCH_STI || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for ST AHCI SATA controller.
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 06/22] ata: ahci_mtk: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (4 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 05/22] ata: ahci_st: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:30 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 07/22] ata: ahci_mvebu: " Damien Le Moal
` (15 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_MEDIATEK.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 83fac101744c..1545201b9104 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -223,7 +223,7 @@ config AHCI_CEVA
config AHCI_MTK
tristate "MediaTek AHCI SATA support"
- depends on ARCH_MEDIATEK
+ depends on ARCH_MEDIATEK || COMPILE_TEST
select MFD_SYSCON
select SATA_HOST
help
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 06/22] ata: ahci_mtk: add compile test support
2022-01-04 10:58 ` [PATCH v2 06/22] ata: ahci_mtk: " Damien Le Moal
@ 2022-01-04 11:30 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:30 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_MEDIATEK.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 83fac101744c..1545201b9104 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -223,7 +223,7 @@ config AHCI_CEVA
>
> config AHCI_MTK
> tristate "MediaTek AHCI SATA support"
> - depends on ARCH_MEDIATEK
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> select MFD_SYSCON
> select SATA_HOST
> help
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 07/22] ata: ahci_mvebu: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (5 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 06/22] ata: ahci_mtk: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:30 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 08/22] ata: ahci_sunxi: " Damien Le Moal
` (14 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_MVEBU.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1545201b9104..237124624db4 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -234,7 +234,7 @@ config AHCI_MTK
config AHCI_MVEBU
tristate "Marvell EBU AHCI SATA support"
- depends on ARCH_MVEBU
+ depends on ARCH_MVEBU || COMPILE_TEST
select SATA_HOST
help
This option enables support for the Marvebu EBU SoC's
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 07/22] ata: ahci_mvebu: add compile test support
2022-01-04 10:58 ` [PATCH v2 07/22] ata: ahci_mvebu: " Damien Le Moal
@ 2022-01-04 11:30 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:30 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_MVEBU.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 1545201b9104..237124624db4 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -234,7 +234,7 @@ config AHCI_MTK
>
> config AHCI_MVEBU
> tristate "Marvell EBU AHCI SATA support"
> - depends on ARCH_MVEBU
> + depends on ARCH_MVEBU || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the Marvebu EBU SoC's
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 08/22] ata: ahci_sunxi: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (6 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 07/22] ata: ahci_mvebu: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:30 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 09/22] ata: ahci_tegra: " Damien Le Moal
` (13 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_SUNXI.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 237124624db4..db3f65ae1ed5 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -253,7 +253,7 @@ config AHCI_OCTEON
config AHCI_SUNXI
tristate "Allwinner sunxi AHCI SATA support"
- depends on ARCH_SUNXI
+ depends on ARCH_SUNXI || COMPILE_TEST
select SATA_HOST
help
This option enables support for the Allwinner sunxi SoC's
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 08/22] ata: ahci_sunxi: add compile test support
2022-01-04 10:58 ` [PATCH v2 08/22] ata: ahci_sunxi: " Damien Le Moal
@ 2022-01-04 11:30 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:30 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_SUNXI.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 237124624db4..db3f65ae1ed5 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -253,7 +253,7 @@ config AHCI_OCTEON
>
> config AHCI_SUNXI
> tristate "Allwinner sunxi AHCI SATA support"
> - depends on ARCH_SUNXI
> + depends on ARCH_SUNXI || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the Allwinner sunxi SoC's
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 09/22] ata: ahci_tegra: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (7 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 08/22] ata: ahci_sunxi: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:31 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 10/22] ata: ahci_xgene: " Damien Le Moal
` (12 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_TEGRA.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index db3f65ae1ed5..9def63c7e9ad 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -263,7 +263,7 @@ config AHCI_SUNXI
config AHCI_TEGRA
tristate "NVIDIA Tegra AHCI SATA support"
- depends on ARCH_TEGRA
+ depends on ARCH_TEGRA || COMPILE_TEST
select SATA_HOST
help
This option enables support for the NVIDIA Tegra SoC's
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 09/22] ata: ahci_tegra: add compile test support
2022-01-04 10:58 ` [PATCH v2 09/22] ata: ahci_tegra: " Damien Le Moal
@ 2022-01-04 11:31 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:31 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_TEGRA.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index db3f65ae1ed5..9def63c7e9ad 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -263,7 +263,7 @@ config AHCI_SUNXI
>
> config AHCI_TEGRA
> tristate "NVIDIA Tegra AHCI SATA support"
> - depends on ARCH_TEGRA
> + depends on ARCH_TEGRA || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the NVIDIA Tegra SoC's
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 10/22] ata: ahci_xgene: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (8 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 09/22] ata: ahci_tegra: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:31 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 11/22] ata: ahci_seattle: " Damien Le Moal
` (11 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable PHY_XGENE.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9def63c7e9ad..1be6a14e46e1 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -273,7 +273,7 @@ config AHCI_TEGRA
config AHCI_XGENE
tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
- depends on PHY_XGENE
+ depends on PHY_XGENE || COMPILE_TEST
select SATA_HOST
help
This option enables support for APM X-Gene SoC SATA host controller.
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 10/22] ata: ahci_xgene: add compile test support
2022-01-04 10:58 ` [PATCH v2 10/22] ata: ahci_xgene: " Damien Le Moal
@ 2022-01-04 11:31 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:31 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable PHY_XGENE.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 9def63c7e9ad..1be6a14e46e1 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -273,7 +273,7 @@ config AHCI_TEGRA
>
> config AHCI_XGENE
> tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
> - depends on PHY_XGENE
> + depends on PHY_XGENE || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for APM X-Gene SoC SATA host controller.
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 11/22] ata: ahci_seattle: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (9 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 10/22] ata: ahci_xgene: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:31 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 12/22] ata: pata_bk3710: " Damien Le Moal
` (10 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_SEATTLE.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1be6a14e46e1..8df5b32e6879 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -311,7 +311,7 @@ config SATA_GEMINI
config SATA_AHCI_SEATTLE
tristate "AMD Seattle 6.0Gbps AHCI SATA host controller support"
- depends on ARCH_SEATTLE
+ depends on ARCH_SEATTLE || COMPILE_TEST
select SATA_HOST
help
This option enables support for AMD Seattle SATA host controller.
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 11/22] ata: ahci_seattle: add compile test support
2022-01-04 10:58 ` [PATCH v2 11/22] ata: ahci_seattle: " Damien Le Moal
@ 2022-01-04 11:31 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:31 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_SEATTLE.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 1be6a14e46e1..8df5b32e6879 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -311,7 +311,7 @@ config SATA_GEMINI
>
> config SATA_AHCI_SEATTLE
> tristate "AMD Seattle 6.0Gbps AHCI SATA host controller support"
> - depends on ARCH_SEATTLE
> + depends on ARCH_SEATTLE || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for AMD Seattle SATA host controller.
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 12/22] ata: pata_bk3710: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (10 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 11/22] ata: ahci_seattle: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:31 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 13/22] ata: pata_cs5535: " Damien Le Moal
` (9 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_DAVINCI.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 8df5b32e6879..b706a3a64b11 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -616,7 +616,7 @@ config PATA_ATP867X
config PATA_BK3710
tristate "Palmchip BK3710 PATA support"
- depends on ARCH_DAVINCI
+ depends on ARCH_DAVINCI || COMPILE_TEST
select PATA_TIMINGS
help
This option enables support for the integrated IDE controller on
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 12/22] ata: pata_bk3710: add compile test support
2022-01-04 10:58 ` [PATCH v2 12/22] ata: pata_bk3710: " Damien Le Moal
@ 2022-01-04 11:31 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:31 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_DAVINCI.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 8df5b32e6879..b706a3a64b11 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -616,7 +616,7 @@ config PATA_ATP867X
>
> config PATA_BK3710
> tristate "Palmchip BK3710 PATA support"
> - depends on ARCH_DAVINCI
> + depends on ARCH_DAVINCI || COMPILE_TEST
> select PATA_TIMINGS
> help
> This option enables support for the integrated IDE controller on
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 13/22] ata: pata_cs5535: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (11 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 12/22] ata: pata_bk3710: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:35 ` Hannes Reinecke
2022-01-05 22:57 ` kernel test robot
2022-01-04 10:58 ` [PATCH v2 14/22] ata: pata_ftide010: " Damien Le Moal
` (8 subsequent siblings)
21 siblings, 2 replies; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not have X86_32 enabled.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index b706a3a64b11..daf57a4e8196 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -654,7 +654,7 @@ config PATA_CS5530
config PATA_CS5535
tristate "CS5535 PATA support (Experimental)"
- depends on PCI && X86_32
+ depends on PCI && (X86_32 || COMPILE_TEST)
help
This option enables support for the NatSemi/AMD CS5535
companion chip used with the Geode processor family.
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 13/22] ata: pata_cs5535: add compile test support
2022-01-04 10:58 ` [PATCH v2 13/22] ata: pata_cs5535: " Damien Le Moal
@ 2022-01-04 11:35 ` Hannes Reinecke
2022-01-06 4:50 ` Damien Le Moal
2022-01-05 22:57 ` kernel test robot
1 sibling, 1 reply; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:35 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not have X86_32 enabled.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b706a3a64b11..daf57a4e8196 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -654,7 +654,7 @@ config PATA_CS5530
>
> config PATA_CS5535
> tristate "CS5535 PATA support (Experimental)"
> - depends on PCI && X86_32
> + depends on PCI && (X86_32 || COMPILE_TEST)
> help
> This option enables support for the NatSemi/AMD CS5535
> companion chip used with the Geode processor family.
>
Looks weird, but seems to be de rigeur in ata/Kconfig.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v2 13/22] ata: pata_cs5535: add compile test support
2022-01-04 11:35 ` Hannes Reinecke
@ 2022-01-06 4:50 ` Damien Le Moal
0 siblings, 0 replies; 49+ messages in thread
From: Damien Le Moal @ 2022-01-06 4:50 UTC (permalink / raw)
To: Hannes Reinecke, linux-ide
On 1/4/22 20:35, Hannes Reinecke wrote:
> On 1/4/22 11:58 AM, Damien Le Moal wrote:
>> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
>> configs that do not have X86_32 enabled.
>>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> ---
>> drivers/ata/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index b706a3a64b11..daf57a4e8196 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -654,7 +654,7 @@ config PATA_CS5530
>>
>> config PATA_CS5535
>> tristate "CS5535 PATA support (Experimental)"
>> - depends on PCI && X86_32
>> + depends on PCI && (X86_32 || COMPILE_TEST)
>> help
>> This option enables support for the NatSemi/AMD CS5535
>> companion chip used with the Geode processor family.
>>
> Looks weird, but seems to be de rigeur in ata/Kconfig.
So it turns out that this one actually compile only with X86 32 and 64
because of the use of asm/msr.h functions.
So I changed it to:
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9d37485c638b..c432cf205589 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -637,7 +637,7 @@ config PATA_CS5530
config PATA_CS5535
tristate "CS5535 PATA support (Experimental)"
- depends on PCI && X86_32
+ depends on PCI && (X86_32 || (X86_64 && COMPILE_TEST))
help
This option enables support for the NatSemi/AMD CS5535
companion chip used with the Geode processor family.
I kept your reviewed-by tag. Please let me know if this is OK.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
>
> Cheers,
>
> Hannes
--
Damien Le Moal
Western Digital Research
^ permalink raw reply related [flat|nested] 49+ messages in thread
* Re: [PATCH v2 13/22] ata: pata_cs5535: add compile test support
2022-01-04 10:58 ` [PATCH v2 13/22] ata: pata_cs5535: " Damien Le Moal
2022-01-04 11:35 ` Hannes Reinecke
@ 2022-01-05 22:57 ` kernel test robot
1 sibling, 0 replies; 49+ messages in thread
From: kernel test robot @ 2022-01-05 22:57 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]
Hi Damien,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.16-rc8 next-20220105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Damien-Le-Moal/Improve-compile-test-coverage/20220104-190230
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c9e6606c7fe92b50a02ce51dda82586ebdf99b48
config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220106/202201060633.Wvw3EGGz-lkp(a)intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d15ac501e8f23784b7a2f4f6497de3910c9ed6d6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Damien-Le-Moal/Improve-compile-test-coverage/20220104-190230
git checkout d15ac501e8f23784b7a2f4f6497de3910c9ed6d6
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/ata/pata_cs5535.c:26:10: fatal error: asm/msr.h: No such file or directory
26 | #include <asm/msr.h>
| ^~~~~~~~~~~
compilation terminated.
vim +26 drivers/ata/pata_cs5535.c
669a5db411d85a Jeff Garzik 2006-08-29 @26 #include <asm/msr.h>
669a5db411d85a Jeff Garzik 2006-08-29 27
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 14/22] ata: pata_ftide010: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (12 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 13/22] ata: pata_cs5535: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:35 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 15/22] ata: pata_imx: " Damien Le Moal
` (7 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARM.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index daf57a4e8196..1b18de61e8df 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -702,7 +702,7 @@ config PATA_EP93XX
config PATA_FTIDE010
tristate "Faraday Technology FTIDE010 PATA support"
depends on OF
- depends on ARM
+ depends on ARM || COMPILE_TEST
depends on SATA_GEMINI
help
This option enables support for the Faraday FTIDE010
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 14/22] ata: pata_ftide010: add compile test support
2022-01-04 10:58 ` [PATCH v2 14/22] ata: pata_ftide010: " Damien Le Moal
@ 2022-01-04 11:35 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:35 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARM.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index daf57a4e8196..1b18de61e8df 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -702,7 +702,7 @@ config PATA_EP93XX
> config PATA_FTIDE010
> tristate "Faraday Technology FTIDE010 PATA support"
> depends on OF
> - depends on ARM
> + depends on ARM || COMPILE_TEST
> depends on SATA_GEMINI
> help
> This option enables support for the Faraday FTIDE010
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 15/22] ata: pata_imx: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (13 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 14/22] ata: pata_ftide010: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:35 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 16/22] ata: pata_pxa: " Damien Le Moal
` (6 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_MXC.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1b18de61e8df..e4e4460cb1fe 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -765,7 +765,7 @@ config PATA_ICSIDE
config PATA_IMX
tristate "PATA support for Freescale iMX"
- depends on ARCH_MXC
+ depends on ARCH_MXC || COMPILE_TEST
select PATA_TIMINGS
help
This option enables support for the PATA host available on Freescale
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 15/22] ata: pata_imx: add compile test support
2022-01-04 10:58 ` [PATCH v2 15/22] ata: pata_imx: " Damien Le Moal
@ 2022-01-04 11:35 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:35 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_MXC.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 1b18de61e8df..e4e4460cb1fe 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -765,7 +765,7 @@ config PATA_ICSIDE
>
> config PATA_IMX
> tristate "PATA support for Freescale iMX"
> - depends on ARCH_MXC
> + depends on ARCH_MXC || COMPILE_TEST
> select PATA_TIMINGS
> help
> This option enables support for the PATA host available on Freescale
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 16/22] ata: pata_pxa: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (14 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 15/22] ata: pata_imx: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:36 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 17/22] ata: pata_legacy: " Damien Le Moal
` (5 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_PXA.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e4e4460cb1fe..59576f92c730 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -986,7 +986,7 @@ config PATA_VIA
config PATA_PXA
tristate "PXA DMA-capable PATA support"
- depends on ARCH_PXA
+ depends on ARCH_PXA || COMPILE_TEST
help
This option enables support for harddrive attached to PXA CPU's bus.
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 16/22] ata: pata_pxa: add compile test support
2022-01-04 10:58 ` [PATCH v2 16/22] ata: pata_pxa: " Damien Le Moal
@ 2022-01-04 11:36 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:36 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ARCH_PXA.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index e4e4460cb1fe..59576f92c730 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -986,7 +986,7 @@ config PATA_VIA
>
> config PATA_PXA
> tristate "PXA DMA-capable PATA support"
> - depends on ARCH_PXA
> + depends on ARCH_PXA || COMPILE_TEST
> help
> This option enables support for harddrive attached to PXA CPU's bus.
>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 17/22] ata: pata_legacy: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (15 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 16/22] ata: pata_pxa: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:39 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 18/22] ata: pata_samsung_cf: " Damien Le Moal
` (4 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ISA.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 59576f92c730..490f0856a271 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1137,7 +1137,7 @@ config PATA_OF_PLATFORM
config PATA_QDI
tristate "QDI VLB PATA support"
- depends on ISA
+ depends on ISA || COMPILE_TEST
select PATA_LEGACY
help
Support for QDI 6500 and 6580 PATA controllers on VESA local bus.
@@ -1172,7 +1172,7 @@ config PATA_SAMSUNG_CF
config PATA_WINBOND_VLB
tristate "Winbond W83759A VLB PATA support (Experimental)"
- depends on ISA
+ depends on ISA || COMPILE_TEST
select PATA_LEGACY
help
Support for the Winbond W83759A controller on Vesa Local Bus
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 17/22] ata: pata_legacy: add compile test support
2022-01-04 10:58 ` [PATCH v2 17/22] ata: pata_legacy: " Damien Le Moal
@ 2022-01-04 11:39 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:39 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable ISA.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 59576f92c730..490f0856a271 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1137,7 +1137,7 @@ config PATA_OF_PLATFORM
>
> config PATA_QDI
> tristate "QDI VLB PATA support"
> - depends on ISA
> + depends on ISA || COMPILE_TEST
> select PATA_LEGACY
> help
> Support for QDI 6500 and 6580 PATA controllers on VESA local bus.
> @@ -1172,7 +1172,7 @@ config PATA_SAMSUNG_CF
>
> config PATA_WINBOND_VLB
> tristate "Winbond W83759A VLB PATA support (Experimental)"
> - depends on ISA
> + depends on ISA || COMPILE_TEST
> select PATA_LEGACY
> help
> Support for the Winbond W83759A controller on Vesa Local Bus
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 18/22] ata: pata_samsung_cf: add compile test support
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (16 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 17/22] ata: pata_legacy: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:40 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 19/22] ata: sata_fsl: fix scsi host initialization Damien Le Moal
` (3 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable SAMSUNG_DEV_IDE.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 490f0856a271..8af5659a7676 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1162,7 +1162,7 @@ config PATA_RZ1000
config PATA_SAMSUNG_CF
tristate "Samsung SoC PATA support"
- depends on SAMSUNG_DEV_IDE
+ depends on SAMSUNG_DEV_IDE || COMPILE_TEST
select PATA_TIMINGS
help
This option enables basic support for Samsung's S3C/S5P board
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 18/22] ata: pata_samsung_cf: add compile test support
2022-01-04 10:58 ` [PATCH v2 18/22] ata: pata_samsung_cf: " Damien Le Moal
@ 2022-01-04 11:40 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:40 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
> configs that do not enable SAMSUNG_DEV_IDE.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 490f0856a271..8af5659a7676 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1162,7 +1162,7 @@ config PATA_RZ1000
>
> config PATA_SAMSUNG_CF
> tristate "Samsung SoC PATA support"
> - depends on SAMSUNG_DEV_IDE
> + depends on SAMSUNG_DEV_IDE || COMPILE_TEST
> select PATA_TIMINGS
> help
> This option enables basic support for Samsung's S3C/S5P board
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 19/22] ata: sata_fsl: fix scsi host initialization
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (17 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 18/22] ata: pata_samsung_cf: " Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:41 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 20/22] ata: sata_fsl: fix cmdhdr_tbl_entry and prde struct definitions Damien Le Moal
` (2 subsequent siblings)
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
When compiling with W=1, the sata_fsl driver compilation throws the
warning:
drivers/ata/sata_fsl.c:1385:22: error: initialized field overwritten
[-Werror=override-init]
1385 | .can_queue = SATA_FSL_QUEUE_DEPTH,
This is due to the driver scsi host template initialization overwriting
the can_queue field that is already set using the ATA_NCQ_SHT()
initializer macro, resulting in the same field being initialized twice
in the host template declaration.
To remove this warning, introduce the ATA_SUBBASE_SHT_QD() and
ATA_NCQ_SHT_QD() initialization macros to allow specifying a queue depth
different from the default ATA_DEF_QUEUE using an additional argument to
the macro.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/sata_fsl.c | 3 +--
include/linux/libata.h | 11 +++++++++++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 142e65d5efc7..101d4dd79f62 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1380,8 +1380,7 @@ static void sata_fsl_host_stop(struct ata_host *host)
* scsi mid-layer and libata interface structures
*/
static struct scsi_host_template sata_fsl_sht = {
- ATA_NCQ_SHT("sata_fsl"),
- .can_queue = SATA_FSL_QUEUE_DEPTH,
+ ATA_NCQ_SHT_QD("sata_fsl", SATA_FSL_QUEUE_DEPTH),
.sg_tablesize = SATA_FSL_MAX_PRD_USABLE,
.dma_boundary = ATA_DMA_BOUNDARY,
};
diff --git a/include/linux/libata.h b/include/linux/libata.h
index ab2d404cde08..cafe360ab3cd 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1385,6 +1385,12 @@ extern const struct attribute_group *ata_common_sdev_groups[];
.tag_alloc_policy = BLK_TAG_ALLOC_RR, \
.slave_configure = ata_scsi_slave_config
+#define ATA_SUBBASE_SHT_QD(drv_name, drv_qd) \
+ __ATA_BASE_SHT(drv_name), \
+ .can_queue = drv_qd, \
+ .tag_alloc_policy = BLK_TAG_ALLOC_RR, \
+ .slave_configure = ata_scsi_slave_config
+
#define ATA_BASE_SHT(drv_name) \
ATA_SUBBASE_SHT(drv_name), \
.sdev_groups = ata_common_sdev_groups
@@ -1396,6 +1402,11 @@ extern const struct attribute_group *ata_ncq_sdev_groups[];
ATA_SUBBASE_SHT(drv_name), \
.sdev_groups = ata_ncq_sdev_groups, \
.change_queue_depth = ata_scsi_change_queue_depth
+
+#define ATA_NCQ_SHT_QD(drv_name, drv_qd) \
+ ATA_SUBBASE_SHT_QD(drv_name, drv_qd), \
+ .sdev_groups = ata_ncq_sdev_groups, \
+ .change_queue_depth = ata_scsi_change_queue_depth
#endif
/*
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 19/22] ata: sata_fsl: fix scsi host initialization
2022-01-04 10:58 ` [PATCH v2 19/22] ata: sata_fsl: fix scsi host initialization Damien Le Moal
@ 2022-01-04 11:41 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:41 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> When compiling with W=1, the sata_fsl driver compilation throws the
> warning:
>
> drivers/ata/sata_fsl.c:1385:22: error: initialized field overwritten
> [-Werror=override-init]
> 1385 | .can_queue = SATA_FSL_QUEUE_DEPTH,
>
> This is due to the driver scsi host template initialization overwriting
> the can_queue field that is already set using the ATA_NCQ_SHT()
> initializer macro, resulting in the same field being initialized twice
> in the host template declaration.
>
> To remove this warning, introduce the ATA_SUBBASE_SHT_QD() and
> ATA_NCQ_SHT_QD() initialization macros to allow specifying a queue depth
> different from the default ATA_DEF_QUEUE using an additional argument to
> the macro.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/sata_fsl.c | 3 +--
> include/linux/libata.h | 11 +++++++++++
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 142e65d5efc7..101d4dd79f62 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -1380,8 +1380,7 @@ static void sata_fsl_host_stop(struct ata_host *host)
> * scsi mid-layer and libata interface structures
> */
> static struct scsi_host_template sata_fsl_sht = {
> - ATA_NCQ_SHT("sata_fsl"),
> - .can_queue = SATA_FSL_QUEUE_DEPTH,
> + ATA_NCQ_SHT_QD("sata_fsl", SATA_FSL_QUEUE_DEPTH),
> .sg_tablesize = SATA_FSL_MAX_PRD_USABLE,
> .dma_boundary = ATA_DMA_BOUNDARY,
> };
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index ab2d404cde08..cafe360ab3cd 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -1385,6 +1385,12 @@ extern const struct attribute_group *ata_common_sdev_groups[];
> .tag_alloc_policy = BLK_TAG_ALLOC_RR, \
> .slave_configure = ata_scsi_slave_config
>
> +#define ATA_SUBBASE_SHT_QD(drv_name, drv_qd) \
> + __ATA_BASE_SHT(drv_name), \
> + .can_queue = drv_qd, \
> + .tag_alloc_policy = BLK_TAG_ALLOC_RR, \
> + .slave_configure = ata_scsi_slave_config
> +
> #define ATA_BASE_SHT(drv_name) \
> ATA_SUBBASE_SHT(drv_name), \
> .sdev_groups = ata_common_sdev_groups
> @@ -1396,6 +1402,11 @@ extern const struct attribute_group *ata_ncq_sdev_groups[];
> ATA_SUBBASE_SHT(drv_name), \
> .sdev_groups = ata_ncq_sdev_groups, \
> .change_queue_depth = ata_scsi_change_queue_depth
> +
> +#define ATA_NCQ_SHT_QD(drv_name, drv_qd) \
> + ATA_SUBBASE_SHT_QD(drv_name, drv_qd), \
> + .sdev_groups = ata_ncq_sdev_groups, \
> + .change_queue_depth = ata_scsi_change_queue_depth
> #endif
>
> /*
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 20/22] ata: sata_fsl: fix cmdhdr_tbl_entry and prde struct definitions
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (18 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 19/22] ata: sata_fsl: fix scsi host initialization Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:45 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 21/22] ata: ahci_xgene: use correct type for port mmio address Damien Le Moal
2022-01-04 10:58 ` [PATCH v2 22/22] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id() Damien Le Moal
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
The fields of the cmdhdr_tbl_entry structure all store __le32 values,
and so are the dba and ddc_and_ext fields of the prde structure. Define
these fields using the __le32 type to avoid sparse warnings about
incorrect type in assignment.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/sata_fsl.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 101d4dd79f62..13d532193405 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -221,10 +221,10 @@ enum {
* 4 Dwords per command slot, command header size == 64 Dwords.
*/
struct cmdhdr_tbl_entry {
- u32 cda;
- u32 prde_fis_len;
- u32 ttl;
- u32 desc_info;
+ __le32 cda;
+ __le32 prde_fis_len;
+ __le32 ttl;
+ __le32 desc_info;
};
/*
@@ -259,9 +259,9 @@ struct command_desc {
*/
struct prde {
- u32 dba;
+ __le32 dba;
u8 fill[2 * 4];
- u32 ddc_and_ext;
+ __le32 ddc_and_ext;
};
/*
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 20/22] ata: sata_fsl: fix cmdhdr_tbl_entry and prde struct definitions
2022-01-04 10:58 ` [PATCH v2 20/22] ata: sata_fsl: fix cmdhdr_tbl_entry and prde struct definitions Damien Le Moal
@ 2022-01-04 11:45 ` Hannes Reinecke
2022-01-05 3:39 ` Damien Le Moal
0 siblings, 1 reply; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:45 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> The fields of the cmdhdr_tbl_entry structure all store __le32 values,
> and so are the dba and ddc_and_ext fields of the prde structure. Define
> these fields using the __le32 type to avoid sparse warnings about
> incorrect type in assignment.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/sata_fsl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 101d4dd79f62..13d532193405 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -221,10 +221,10 @@ enum {
> * 4 Dwords per command slot, command header size == 64 Dwords.
> */
> struct cmdhdr_tbl_entry {
> - u32 cda;
> - u32 prde_fis_len;
> - u32 ttl;
> - u32 desc_info;
> + __le32 cda;
> + __le32 prde_fis_len;
> + __le32 ttl;
> + __le32 desc_info;
> };
>
> /*
> @@ -259,9 +259,9 @@ struct command_desc {
> */
>
> struct prde {
> - u32 dba;
> + __le32 dba;
> u8 fill[2 * 4];
> - u32 ddc_and_ext;
> + __le32 ddc_and_ext;
> };
>
> /*
>
... which means that _technically_ we should modify the log message in
sata_fsl_setup_cmd_hdr_entry() to use le32_to_cpu(), too, to avoid
garbled numbers on big endian. Or maybe not, if we argue that we want
to print out the values as sent to the HW.
Anyway.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v2 20/22] ata: sata_fsl: fix cmdhdr_tbl_entry and prde struct definitions
2022-01-04 11:45 ` Hannes Reinecke
@ 2022-01-05 3:39 ` Damien Le Moal
0 siblings, 0 replies; 49+ messages in thread
From: Damien Le Moal @ 2022-01-05 3:39 UTC (permalink / raw)
To: Hannes Reinecke, linux-ide
On 1/4/22 20:45, Hannes Reinecke wrote:
> On 1/4/22 11:58 AM, Damien Le Moal wrote:
>> The fields of the cmdhdr_tbl_entry structure all store __le32 values,
>> and so are the dba and ddc_and_ext fields of the prde structure. Define
>> these fields using the __le32 type to avoid sparse warnings about
>> incorrect type in assignment.
>>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> ---
>> drivers/ata/sata_fsl.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>> index 101d4dd79f62..13d532193405 100644
>> --- a/drivers/ata/sata_fsl.c
>> +++ b/drivers/ata/sata_fsl.c
>> @@ -221,10 +221,10 @@ enum {
>> * 4 Dwords per command slot, command header size == 64 Dwords.
>> */
>> struct cmdhdr_tbl_entry {
>> - u32 cda;
>> - u32 prde_fis_len;
>> - u32 ttl;
>> - u32 desc_info;
>> + __le32 cda;
>> + __le32 prde_fis_len;
>> + __le32 ttl;
>> + __le32 desc_info;
>> };
>>
>> /*
>> @@ -259,9 +259,9 @@ struct command_desc {
>> */
>>
>> struct prde {
>> - u32 dba;
>> + __le32 dba;
>> u8 fill[2 * 4];
>> - u32 ddc_and_ext;
>> + __le32 ddc_and_ext;
>> };
>>
>> /*
>>
> ... which means that _technically_ we should modify the log message in
> sata_fsl_setup_cmd_hdr_entry() to use le32_to_cpu(), too, to avoid
> garbled numbers on big endian. Or maybe not, if we argue that we want
> to print out the values as sent to the HW.
It makes more sense to me to print the real value, so I added that fix.
>
> Anyway.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
>
> Cheers,
>
> Hannes
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 21/22] ata: ahci_xgene: use correct type for port mmio address
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (19 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 20/22] ata: sata_fsl: fix cmdhdr_tbl_entry and prde struct definitions Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:46 ` Hannes Reinecke
2022-01-04 10:58 ` [PATCH v2 22/22] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id() Damien Le Moal
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
Sparse complains about an incorrect type for port_mmio pointer
variables:
drivers/ata/ahci_xgene.c:196:41: warning: incorrect type in initializer
(different address spaces)
drivers/ata/ahci_xgene.c:196:41: expected void *port_mmio
drivers/ata/ahci_xgene.c:196:41: got void [noderef] __iomem *
Fix this by declaring port_mmio as "void __iomem *" instead of "void *".
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/ahci_xgene.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 4d8a186ec12a..68ec7e9430b2 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -193,7 +193,7 @@ static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc)
struct xgene_ahci_context *ctx = hpriv->plat_data;
int rc = 0;
u32 port_fbs;
- void *port_mmio = ahci_port_base(ap);
+ void __iomem *port_mmio = ahci_port_base(ap);
/*
* Write the pmp value to PxFBS.DEV
@@ -454,7 +454,7 @@ static int xgene_ahci_pmp_softreset(struct ata_link *link, unsigned int *class,
int pmp = sata_srst_pmp(link);
struct ata_port *ap = link->ap;
u32 rc;
- void *port_mmio = ahci_port_base(ap);
+ void __iomem *port_mmio = ahci_port_base(ap);
u32 port_fbs;
/*
@@ -499,7 +499,7 @@ static int xgene_ahci_softreset(struct ata_link *link, unsigned int *class,
struct ata_port *ap = link->ap;
struct ahci_host_priv *hpriv = ap->host->private_data;
struct xgene_ahci_context *ctx = hpriv->plat_data;
- void *port_mmio = ahci_port_base(ap);
+ void __iomem *port_mmio = ahci_port_base(ap);
u32 port_fbs;
u32 port_fbs_save;
u32 retry = 1;
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 21/22] ata: ahci_xgene: use correct type for port mmio address
2022-01-04 10:58 ` [PATCH v2 21/22] ata: ahci_xgene: use correct type for port mmio address Damien Le Moal
@ 2022-01-04 11:46 ` Hannes Reinecke
0 siblings, 0 replies; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:46 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> Sparse complains about an incorrect type for port_mmio pointer
> variables:
>
> drivers/ata/ahci_xgene.c:196:41: warning: incorrect type in initializer
> (different address spaces)
> drivers/ata/ahci_xgene.c:196:41: expected void *port_mmio
> drivers/ata/ahci_xgene.c:196:41: got void [noderef] __iomem *
>
> Fix this by declaring port_mmio as "void __iomem *" instead of "void *".
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/ahci_xgene.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v2 22/22] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id()
2022-01-04 10:58 [PATCH v2 00/22] Improve compile test coverage Damien Le Moal
` (20 preceding siblings ...)
2022-01-04 10:58 ` [PATCH v2 21/22] ata: ahci_xgene: use correct type for port mmio address Damien Le Moal
@ 2022-01-04 10:58 ` Damien Le Moal
2022-01-04 11:51 ` Hannes Reinecke
21 siblings, 1 reply; 49+ messages in thread
From: Damien Le Moal @ 2022-01-04 10:58 UTC (permalink / raw)
To: linux-ide
ATA IDENTIFY command returns an array of le16 words. Accessing it as a
u16 array triggers the following sparse warning:
drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
drivers/ata/ahci_xgene.c:262:33: left side has type unsigned short
drivers/ata/ahci_xgene.c:262:33: right side has type restricted __le16
Use a local variable to explicitly cast the id array to __le16 to avoid
this warning.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/ahci_xgene.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 68ec7e9430b2..d5075d0f8cb1 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -239,6 +239,7 @@ static bool xgene_ahci_is_memram_inited(struct xgene_ahci_context *ctx)
static unsigned int xgene_ahci_read_id(struct ata_device *dev,
struct ata_taskfile *tf, u16 *id)
{
+ __le16 *__id = (__le16 *)id;
u32 err_mask;
err_mask = ata_do_dev_read_id(dev, tf, id);
@@ -259,7 +260,7 @@ static unsigned int xgene_ahci_read_id(struct ata_device *dev,
*
* Clear reserved bit 8 (DEVSLP bit) as we don't support DEVSLP
*/
- id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
+ __id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
return 0;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH v2 22/22] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id()
2022-01-04 10:58 ` [PATCH v2 22/22] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id() Damien Le Moal
@ 2022-01-04 11:51 ` Hannes Reinecke
2022-01-05 3:40 ` Damien Le Moal
0 siblings, 1 reply; 49+ messages in thread
From: Hannes Reinecke @ 2022-01-04 11:51 UTC (permalink / raw)
To: Damien Le Moal, linux-ide
On 1/4/22 11:58 AM, Damien Le Moal wrote:
> ATA IDENTIFY command returns an array of le16 words. Accessing it as a
> u16 array triggers the following sparse warning:
>
> drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
> drivers/ata/ahci_xgene.c:262:33: left side has type unsigned short
> drivers/ata/ahci_xgene.c:262:33: right side has type restricted __le16
>
> Use a local variable to explicitly cast the id array to __le16 to avoid
> this warning.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/ahci_xgene.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index 68ec7e9430b2..d5075d0f8cb1 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -239,6 +239,7 @@ static bool xgene_ahci_is_memram_inited(struct xgene_ahci_context *ctx)
> static unsigned int xgene_ahci_read_id(struct ata_device *dev,
> struct ata_taskfile *tf, u16 *id)
> {
> + __le16 *__id = (__le16 *)id;
> u32 err_mask;
>
> err_mask = ata_do_dev_read_id(dev, tf, id);
> @@ -259,7 +260,7 @@ static unsigned int xgene_ahci_read_id(struct ata_device *dev,
> *
> * Clear reserved bit 8 (DEVSLP bit) as we don't support DEVSLP
> */
> - id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
> + __id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
>
> return 0;
> }
>
Hmm. I would think that the 'id' argument is wrong; it really should be
'__le16 *', as it only gets converted later on with the call to
swap_buf_le16(id, ATA_ID_WORDS) in
drivers/ata/libata-core.c:ata_dev_read_id(). So when this function is
called the argument really _is_ __le16, only the declaration doesn't
tell us.
Maybe one should rather fix this?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v2 22/22] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id()
2022-01-04 11:51 ` Hannes Reinecke
@ 2022-01-05 3:40 ` Damien Le Moal
0 siblings, 0 replies; 49+ messages in thread
From: Damien Le Moal @ 2022-01-05 3:40 UTC (permalink / raw)
To: Hannes Reinecke, linux-ide
On 1/4/22 20:51, Hannes Reinecke wrote:
> On 1/4/22 11:58 AM, Damien Le Moal wrote:
>> ATA IDENTIFY command returns an array of le16 words. Accessing it as a
>> u16 array triggers the following sparse warning:
>>
>> drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
>> drivers/ata/ahci_xgene.c:262:33: left side has type unsigned short
>> drivers/ata/ahci_xgene.c:262:33: right side has type restricted __le16
>>
>> Use a local variable to explicitly cast the id array to __le16 to avoid
>> this warning.
>>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> ---
>> drivers/ata/ahci_xgene.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>> index 68ec7e9430b2..d5075d0f8cb1 100644
>> --- a/drivers/ata/ahci_xgene.c
>> +++ b/drivers/ata/ahci_xgene.c
>> @@ -239,6 +239,7 @@ static bool xgene_ahci_is_memram_inited(struct xgene_ahci_context *ctx)
>> static unsigned int xgene_ahci_read_id(struct ata_device *dev,
>> struct ata_taskfile *tf, u16 *id)
>> {
>> + __le16 *__id = (__le16 *)id;
>> u32 err_mask;
>>
>> err_mask = ata_do_dev_read_id(dev, tf, id);
>> @@ -259,7 +260,7 @@ static unsigned int xgene_ahci_read_id(struct ata_device *dev,
>> *
>> * Clear reserved bit 8 (DEVSLP bit) as we don't support DEVSLP
>> */
>> - id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
>> + __id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
>>
>> return 0;
>> }
>>
> Hmm. I would think that the 'id' argument is wrong; it really should be
> '__le16 *', as it only gets converted later on with the call to
> swap_buf_le16(id, ATA_ID_WORDS) in
> drivers/ata/libata-core.c:ata_dev_read_id(). So when this function is
> called the argument really _is_ __le16, only the declaration doesn't
> tell us.
>
> Maybe one should rather fix this?
Good point. Sending V3 with this patch changed to fix read_id()
operation interface.
>
> Cheers,
>
> Hannes
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 49+ messages in thread