From: Christian Brauner <brauner@kernel.org> To: Jeff Layton <jlayton@kernel.org>, ceph-devel@vger.kernel.org Cc: Ilya Dryomov <idryomov@gmail.com>, Christoph Hellwig <hch@lst.de>, Christian Brauner <christian.brauner@ubuntu.com> Subject: [PATCH 11/12] ceph/file: allow idmapped atomic_open inode op Date: Tue, 4 Jan 2022 15:04:13 +0100 [thread overview] Message-ID: <20220104140414.155198-12-brauner@kernel.org> (raw) In-Reply-To: <20220104140414.155198-1-brauner@kernel.org> From: Christian Brauner <christian.brauner@ubuntu.com> Enable ceph_atomic_open() to handle idmapped mounts. This is just a matter of passing down the mount's idmapping. Cc: Jeff Layton <jlayton@kernel.org> Cc: Ilya Dryomov <idryomov@gmail.com> Cc: ceph-devel@vger.kernel.org Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> --- fs/ceph/file.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index c138e8126286..7fecb41796c7 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -608,7 +608,10 @@ static int ceph_finish_async_create(struct inode *dir, struct dentry *dentry, in.truncate_seq = cpu_to_le32(1); in.truncate_size = cpu_to_le64(-1ULL); in.xattr_version = cpu_to_le64(1); - in.uid = cpu_to_le32(from_kuid(&init_user_ns, current_fsuid())); + in.uid = cpu_to_le32(from_kuid(&init_user_ns, + mapped_kuid_user(req->mnt_userns, + &init_user_ns, + current_fsuid()))); if (dir->i_mode & S_ISGID) { in.gid = cpu_to_le32(from_kgid(&init_user_ns, dir->i_gid)); @@ -616,11 +619,14 @@ static int ceph_finish_async_create(struct inode *dir, struct dentry *dentry, if (S_ISDIR(mode)) mode |= S_ISGID; else if ((mode & (S_ISGID | S_IXGRP)) == (S_ISGID | S_IXGRP) && - !in_group_p(dir->i_gid) && - !capable_wrt_inode_uidgid(&init_user_ns, dir, CAP_FSETID)) + !in_group_p(i_gid_into_mnt(req->mnt_userns, dir)) && + !capable_wrt_inode_uidgid(req->mnt_userns, dir, CAP_FSETID)) mode &= ~S_ISGID; } else { - in.gid = cpu_to_le32(from_kgid(&init_user_ns, current_fsgid())); + in.gid = cpu_to_le32(from_kgid(&init_user_ns, + mapped_kgid_user(req->mnt_userns, + &init_user_ns, + current_fsgid()))); } in.mode = cpu_to_le32((u32)mode); @@ -677,6 +683,7 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry, struct file *file, unsigned flags, umode_t mode) { struct ceph_fs_client *fsc = ceph_sb_to_client(dir->i_sb); + struct user_namespace *mnt_userns = file_mnt_user_ns(file); struct ceph_mds_client *mdsc = fsc->mdsc; struct ceph_mds_request *req; struct dentry *dn; @@ -719,6 +726,7 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry, mask |= CEPH_CAP_XATTR_SHARED; req->r_args.open.mask = cpu_to_le32(mask); req->r_parent = dir; + req->mnt_userns = mnt_userns; ihold(dir); if (flags & O_CREAT) { -- 2.32.0
next prev parent reply other threads:[~2022-01-04 14:04 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-04 14:04 [PATCH 00/12] ceph: support idmapped mounts Christian Brauner 2022-01-04 14:04 ` [PATCH 01/12] ceph: stash idmapping in mdsc request Christian Brauner 2022-01-04 17:22 ` Jeff Layton 2022-01-04 14:04 ` [PATCH 02/12] ceph: handle idmapped mounts in create_request_message() Christian Brauner 2022-01-04 17:40 ` Jeff Layton 2022-01-04 19:33 ` Gregory Farnum 2022-01-05 14:11 ` Christian Brauner 2022-01-05 14:10 ` Christian Brauner 2022-01-05 15:03 ` Jeff Layton 2022-01-05 15:35 ` Christian Brauner 2022-01-04 14:04 ` [PATCH 03/12] ceph: allow idmapped mknod inode op Christian Brauner 2022-01-04 14:04 ` [PATCH 04/12] ceph: allow idmapped symlink " Christian Brauner 2022-01-04 14:04 ` [PATCH 05/12] ceph: allow idmapped mkdir " Christian Brauner 2022-01-04 14:04 ` [PATCH 06/12] ceph: allow idmapped rename " Christian Brauner 2022-01-04 14:04 ` [PATCH 07/12] ceph: allow idmapped getattr " Christian Brauner 2022-01-04 14:04 ` [PATCH 08/12] ceph: allow idmapped permission " Christian Brauner 2022-01-04 14:04 ` [PATCH 09/12] ceph: allow idmapped setattr " Christian Brauner 2022-01-04 14:04 ` [PATCH 10/12] ceph/acl: allow idmapped set_acl " Christian Brauner 2022-01-04 14:04 ` Christian Brauner [this message] 2022-01-04 14:04 ` [PATCH 12/12] ceph: allow idmapped mounts Christian Brauner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220104140414.155198-12-brauner@kernel.org \ --to=brauner@kernel.org \ --cc=ceph-devel@vger.kernel.org \ --cc=christian.brauner@ubuntu.com \ --cc=hch@lst.de \ --cc=idryomov@gmail.com \ --cc=jlayton@kernel.org \ --subject='Re: [PATCH 11/12] ceph/file: allow idmapped atomic_open inode op' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.