* [PATCH v3] mtd: onenand: Check for error irq
@ 2022-01-04 16:26 ` Jiasheng Jiang
0 siblings, 0 replies; 4+ messages in thread
From: Jiasheng Jiang @ 2022-01-04 16:26 UTC (permalink / raw)
To: miquel.raynal
Cc: kyungmin.park, richard, vigneshr, linux-mtd, linux-kernel,
Jiasheng Jiang
For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.
Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
v3: Roll back to v1 commit message and correct the fixes tag.
v2: Change the commit message.
---
drivers/mtd/nand/onenand/generic.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/onenand/generic.c b/drivers/mtd/nand/onenand/generic.c
index 8b6f4da5d720..a4b8b65fe15f 100644
--- a/drivers/mtd/nand/onenand/generic.c
+++ b/drivers/mtd/nand/onenand/generic.c
@@ -53,7 +53,12 @@ static int generic_onenand_probe(struct platform_device *pdev)
}
info->onenand.mmcontrol = pdata ? pdata->mmcontrol : NULL;
- info->onenand.irq = platform_get_irq(pdev, 0);
+
+ err = platform_get_irq(pdev, 0);
+ if (err < 0)
+ goto out_iounmap;
+
+ info->onenand.irq = err;
info->mtd.dev.parent = &pdev->dev;
info->mtd.priv = &info->onenand;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3] mtd: onenand: Check for error irq
@ 2022-01-04 16:26 ` Jiasheng Jiang
0 siblings, 0 replies; 4+ messages in thread
From: Jiasheng Jiang @ 2022-01-04 16:26 UTC (permalink / raw)
To: miquel.raynal
Cc: kyungmin.park, richard, vigneshr, linux-mtd, linux-kernel,
Jiasheng Jiang
For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.
Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
v3: Roll back to v1 commit message and correct the fixes tag.
v2: Change the commit message.
---
drivers/mtd/nand/onenand/generic.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/onenand/generic.c b/drivers/mtd/nand/onenand/generic.c
index 8b6f4da5d720..a4b8b65fe15f 100644
--- a/drivers/mtd/nand/onenand/generic.c
+++ b/drivers/mtd/nand/onenand/generic.c
@@ -53,7 +53,12 @@ static int generic_onenand_probe(struct platform_device *pdev)
}
info->onenand.mmcontrol = pdata ? pdata->mmcontrol : NULL;
- info->onenand.irq = platform_get_irq(pdev, 0);
+
+ err = platform_get_irq(pdev, 0);
+ if (err < 0)
+ goto out_iounmap;
+
+ info->onenand.irq = err;
info->mtd.dev.parent = &pdev->dev;
info->mtd.priv = &info->onenand;
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mtd: onenand: Check for error irq
2022-01-04 16:26 ` Jiasheng Jiang
@ 2022-01-23 15:44 ` Miquel Raynal
-1 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2022-01-23 15:44 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: kyungmin.park, richard, vigneshr, linux-mtd, linux-kernel
Hi Jiasheng,
jiasheng@iscas.ac.cn wrote on Wed, 5 Jan 2022 00:26:58 +0800:
> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
>
> Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
Applied to nand/next.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mtd: onenand: Check for error irq
@ 2022-01-23 15:44 ` Miquel Raynal
0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2022-01-23 15:44 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: kyungmin.park, richard, vigneshr, linux-mtd, linux-kernel
Hi Jiasheng,
jiasheng@iscas.ac.cn wrote on Wed, 5 Jan 2022 00:26:58 +0800:
> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
>
> Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
Applied to nand/next.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-23 15:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 16:26 [PATCH v3] mtd: onenand: Check for error irq Jiasheng Jiang
2022-01-04 16:26 ` Jiasheng Jiang
2022-01-23 15:44 ` Miquel Raynal
2022-01-23 15:44 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.