* [RESEND PATCH] mfd: arizona: Add missing statics to the of_match_tables
@ 2022-01-04 16:54 Charles Keepax
2022-02-08 9:16 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2022-01-04 16:54 UTC (permalink / raw)
To: lee.jones; +Cc: patches, linux-kernel
When the match tables were split for I2C and SPI a static should have
been added since the tables are no longer exported.
Fixes: 3f65555c417c ("mfd: arizona: Split of_match table into I2C and SPI versions")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/mfd/arizona-i2c.c | 2 +-
drivers/mfd/arizona-spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c
index 3ed810e81f631..6d83e6b9a692d 100644
--- a/drivers/mfd/arizona-i2c.c
+++ b/drivers/mfd/arizona-i2c.c
@@ -105,7 +105,7 @@ static const struct i2c_device_id arizona_i2c_id[] = {
MODULE_DEVICE_TABLE(i2c, arizona_i2c_id);
#ifdef CONFIG_OF
-const struct of_device_id arizona_i2c_of_match[] = {
+static const struct of_device_id arizona_i2c_of_match[] = {
{ .compatible = "wlf,wm5102", .data = (void *)WM5102 },
{ .compatible = "wlf,wm5110", .data = (void *)WM5110 },
{ .compatible = "wlf,wm8280", .data = (void *)WM8280 },
diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
index 9fe06dda37829..98c87d3bd00fa 100644
--- a/drivers/mfd/arizona-spi.c
+++ b/drivers/mfd/arizona-spi.c
@@ -226,7 +226,7 @@ static const struct spi_device_id arizona_spi_ids[] = {
MODULE_DEVICE_TABLE(spi, arizona_spi_ids);
#ifdef CONFIG_OF
-const struct of_device_id arizona_spi_of_match[] = {
+static const struct of_device_id arizona_spi_of_match[] = {
{ .compatible = "wlf,wm5102", .data = (void *)WM5102 },
{ .compatible = "wlf,wm5110", .data = (void *)WM5110 },
{ .compatible = "wlf,wm8280", .data = (void *)WM8280 },
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] mfd: arizona: Add missing statics to the of_match_tables
2022-01-04 16:54 [RESEND PATCH] mfd: arizona: Add missing statics to the of_match_tables Charles Keepax
@ 2022-02-08 9:16 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2022-02-08 9:16 UTC (permalink / raw)
To: Charles Keepax; +Cc: patches, linux-kernel
On Tue, 04 Jan 2022, Charles Keepax wrote:
> When the match tables were split for I2C and SPI a static should have
> been added since the tables are no longer exported.
>
> Fixes: 3f65555c417c ("mfd: arizona: Split of_match table into I2C and SPI versions")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/mfd/arizona-i2c.c | 2 +-
> drivers/mfd/arizona-spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-08 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 16:54 [RESEND PATCH] mfd: arizona: Add missing statics to the of_match_tables Charles Keepax
2022-02-08 9:16 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.