From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
Date: Tue, 04 Jan 2022 17:29:09 +0800 [thread overview]
Message-ID: <202201041744.YK2Dcs6t-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2272 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Marc Zyngier <maz@kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c9e6606c7fe92b50a02ce51dda82586ebdf99b48
commit: d8fcbe52d7d382106ab1dfa89c4b6a4952524125 PCI: apple: Add INTx and per-port interrupt support
date: 9 weeks ago
:::::: branch date: 35 hours ago
:::::: commit date: 9 weeks ago
compiler: csky-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
^
vim +177 drivers/pci/controller/pcie-apple.c
d8fcbe52d7d382 Marc Zyngier 2021-09-29 169
d8fcbe52d7d382 Marc Zyngier 2021-09-29 170 static int apple_port_irq_set_type(struct irq_data *data, unsigned int type)
d8fcbe52d7d382 Marc Zyngier 2021-09-29 171 {
d8fcbe52d7d382 Marc Zyngier 2021-09-29 172 /*
d8fcbe52d7d382 Marc Zyngier 2021-09-29 173 * It doesn't seem that there is any way to configure the
d8fcbe52d7d382 Marc Zyngier 2021-09-29 174 * trigger, so assume INTx have to be level (as per the spec),
d8fcbe52d7d382 Marc Zyngier 2021-09-29 175 * and the rest is edge (which looks likely).
d8fcbe52d7d382 Marc Zyngier 2021-09-29 176 */
d8fcbe52d7d382 Marc Zyngier 2021-09-29 @177 if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
d8fcbe52d7d382 Marc Zyngier 2021-09-29 178 return -EINVAL;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 179
d8fcbe52d7d382 Marc Zyngier 2021-09-29 180 irqd_set_trigger_type(data, type);
d8fcbe52d7d382 Marc Zyngier 2021-09-29 181 return 0;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 182 }
d8fcbe52d7d382 Marc Zyngier 2021-09-29 183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2022-01-04 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 9:29 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-29 7:34 drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] kernel test robot
2021-12-08 3:15 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201041744.YK2Dcs6t-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.