* drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
@ 2022-01-04 9:29 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-01-04 9:29 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2272 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Marc Zyngier <maz@kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c9e6606c7fe92b50a02ce51dda82586ebdf99b48
commit: d8fcbe52d7d382106ab1dfa89c4b6a4952524125 PCI: apple: Add INTx and per-port interrupt support
date: 9 weeks ago
:::::: branch date: 35 hours ago
:::::: commit date: 9 weeks ago
compiler: csky-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
^
vim +177 drivers/pci/controller/pcie-apple.c
d8fcbe52d7d382 Marc Zyngier 2021-09-29 169
d8fcbe52d7d382 Marc Zyngier 2021-09-29 170 static int apple_port_irq_set_type(struct irq_data *data, unsigned int type)
d8fcbe52d7d382 Marc Zyngier 2021-09-29 171 {
d8fcbe52d7d382 Marc Zyngier 2021-09-29 172 /*
d8fcbe52d7d382 Marc Zyngier 2021-09-29 173 * It doesn't seem that there is any way to configure the
d8fcbe52d7d382 Marc Zyngier 2021-09-29 174 * trigger, so assume INTx have to be level (as per the spec),
d8fcbe52d7d382 Marc Zyngier 2021-09-29 175 * and the rest is edge (which looks likely).
d8fcbe52d7d382 Marc Zyngier 2021-09-29 176 */
d8fcbe52d7d382 Marc Zyngier 2021-09-29 @177 if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
d8fcbe52d7d382 Marc Zyngier 2021-09-29 178 return -EINVAL;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 179
d8fcbe52d7d382 Marc Zyngier 2021-09-29 180 irqd_set_trigger_type(data, type);
d8fcbe52d7d382 Marc Zyngier 2021-09-29 181 return 0;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 182 }
d8fcbe52d7d382 Marc Zyngier 2021-09-29 183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
@ 2022-01-29 7:34 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-01-29 7:34 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2277 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Marc Zyngier <maz@kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 169387e2aa291a4e3cb856053730fe99d6cec06f
commit: d8fcbe52d7d382106ab1dfa89c4b6a4952524125 PCI: apple: Add INTx and per-port interrupt support
date: 3 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 3 months ago
compiler: riscv32-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
^
vim +177 drivers/pci/controller/pcie-apple.c
d8fcbe52d7d382 Marc Zyngier 2021-09-29 169
d8fcbe52d7d382 Marc Zyngier 2021-09-29 170 static int apple_port_irq_set_type(struct irq_data *data, unsigned int type)
d8fcbe52d7d382 Marc Zyngier 2021-09-29 171 {
d8fcbe52d7d382 Marc Zyngier 2021-09-29 172 /*
d8fcbe52d7d382 Marc Zyngier 2021-09-29 173 * It doesn't seem that there is any way to configure the
d8fcbe52d7d382 Marc Zyngier 2021-09-29 174 * trigger, so assume INTx have to be level (as per the spec),
d8fcbe52d7d382 Marc Zyngier 2021-09-29 175 * and the rest is edge (which looks likely).
d8fcbe52d7d382 Marc Zyngier 2021-09-29 176 */
d8fcbe52d7d382 Marc Zyngier 2021-09-29 @177 if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
d8fcbe52d7d382 Marc Zyngier 2021-09-29 178 return -EINVAL;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 179
d8fcbe52d7d382 Marc Zyngier 2021-09-29 180 irqd_set_trigger_type(data, type);
d8fcbe52d7d382 Marc Zyngier 2021-09-29 181 return 0;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 182 }
d8fcbe52d7d382 Marc Zyngier 2021-09-29 183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
@ 2021-12-08 3:15 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-12-08 3:15 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3083 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Marc Zyngier <maz@kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cd8c917a56f20f48748dd43d9ae3caff51d5b987
commit: d8fcbe52d7d382106ab1dfa89c4b6a4952524125 PCI: apple: Add INTx and per-port interrupt support
date: 5 weeks ago
:::::: branch date: 27 hours ago
:::::: commit date: 5 weeks ago
compiler: sparc64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> kernel/bpf/bpf_iter.c:456:12: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (!ulen ^ !ubuf)
^
kernel/bpf/bpf_iter.c:517:29: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (bpfptr_is_null(ulinfo) ^ !linfo_len)
^
>> drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
^
>> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:964:14: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
if (pullup ^ !t)
^
>> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:286:2: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
*gpio_chip = &hw->chip;
^
vim +177 drivers/pci/controller/pcie-apple.c
d8fcbe52d7d382 Marc Zyngier 2021-09-29 169
d8fcbe52d7d382 Marc Zyngier 2021-09-29 170 static int apple_port_irq_set_type(struct irq_data *data, unsigned int type)
d8fcbe52d7d382 Marc Zyngier 2021-09-29 171 {
d8fcbe52d7d382 Marc Zyngier 2021-09-29 172 /*
d8fcbe52d7d382 Marc Zyngier 2021-09-29 173 * It doesn't seem that there is any way to configure the
d8fcbe52d7d382 Marc Zyngier 2021-09-29 174 * trigger, so assume INTx have to be level (as per the spec),
d8fcbe52d7d382 Marc Zyngier 2021-09-29 175 * and the rest is edge (which looks likely).
d8fcbe52d7d382 Marc Zyngier 2021-09-29 176 */
d8fcbe52d7d382 Marc Zyngier 2021-09-29 @177 if (hwirq_is_intx(data->hwirq) ^ !!(type & IRQ_TYPE_LEVEL_MASK))
d8fcbe52d7d382 Marc Zyngier 2021-09-29 178 return -EINVAL;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 179
d8fcbe52d7d382 Marc Zyngier 2021-09-29 180 irqd_set_trigger_type(data, type);
d8fcbe52d7d382 Marc Zyngier 2021-09-29 181 return 0;
d8fcbe52d7d382 Marc Zyngier 2021-09-29 182 }
d8fcbe52d7d382 Marc Zyngier 2021-09-29 183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-29 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 9:29 drivers/pci/controller/pcie-apple.c:177:33: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-29 7:34 kernel test robot
2021-12-08 3:15 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.