[PATCH] can: gs_usb: Zero-initialize flags

[PATCH] can: gs_usb: Zero-initialize flags

[Brian Silverman]

No information is deliberately sent here in host->device communications,
but the open-source candleLight firmware echoes it back, which can
result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
spurious ERRORFRAMEs.

Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
---
 drivers/net/can/usb/gs_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 1b400de00f51..cc4ad8d59bd7 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,
 
 	hf->echo_id = idx;
 	hf->channel = dev->channel;
+	hf->flags = 0;
 
 	cf = (struct can_frame *)skb->data;
 

base-commit: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
-- 
2.20.1

Re: [PATCH] can: gs_usb: Zero-initialize flags

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On 05.01.2022 16:29:50, Brian Silverman wrote:
> No information is deliberately sent here in host->device communications,
> but the open-source candleLight firmware echoes it back, which can
> result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
> spurious ERRORFRAMEs.
> 
> Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>

Applied to linux-can/testing + opened an issue on github:
https://github.com/candle-usb/candleLight_fw/issues/87

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] can: gs_usb: Zero-initialize flags

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On 08.01.2022 23:29:04, Marc Kleine-Budde wrote:
> On 05.01.2022 16:29:50, Brian Silverman wrote:
> > No information is deliberately sent here in host->device communications,
> > but the open-source candleLight firmware echoes it back, which can
> > result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
> > spurious ERRORFRAMEs.
> > 
> > Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
> 
> Applied to linux-can/testing + opened an issue on github:
> https://github.com/candle-usb/candleLight_fw/issues/87

BTW: Your brian.silverman@bluerivertech.com address fails:

| brian.silverman@bluerivertech.com
|  host aspmx.l.google.com [2a00:1450:400c:c0c::1a]
|  SMTP error from remote mail server after RCPT TO:<brian.silverman@bluerivertech.com>:
|  550-5.2.1 The email account that you tried to reach is disabled. Learn more at
|  550 5.2.1  https://support.google.com/mail/?p=DisabledUser o10si1930223wrh.555 - gsmtp

Should I change the author's email address to your gmail address?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] can: gs_usb: Zero-initialize flags

[Brian Silverman]

On Sat, Jan 8, 2022 at 3:16 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> BTW: Your brian.silverman@bluerivertech.com address fails:
>
> | brian.silverman@bluerivertech.com
> |  host aspmx.l.google.com [2a00:1450:400c:c0c::1a]
> |  SMTP error from remote mail server after RCPT TO:<brian.silverman@bluerivertech.com>:
> |  550-5.2.1 The email account that you tried to reach is disabled. Learn more at
> |  550 5.2.1  https://support.google.com/mail/?p=DisabledUser o10si1930223wrh.555 - gsmtp
>
> Should I change the author's email address to your gmail address?

I wrote it as part of my employment by Blue River, but am currently
moving on to another job. The policy was to have my work email on the
patch. Seems like the same situation whenever somebody uses a work
email and then leaves that job, just in this case the timing is
tighter than common. I think leaving it is best.

To be clear, contributing this was definitely authorized by the
company, I just didn't get around to sending out the patch until
almost my last day.

Thanks,
Brian

Re: [PATCH] can: gs_usb: Zero-initialize flags

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]

On 08.01.2022 15:41:57, Brian Silverman wrote:
> On Sat, Jan 8, 2022 at 3:16 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > BTW: Your brian.silverman@bluerivertech.com address fails:
> >
> > | brian.silverman@bluerivertech.com
> > |  host aspmx.l.google.com [2a00:1450:400c:c0c::1a]
> > |  SMTP error from remote mail server after RCPT TO:<brian.silverman@bluerivertech.com>:
> > |  550-5.2.1 The email account that you tried to reach is disabled. Learn more at
> > |  550 5.2.1  https://support.google.com/mail/?p=DisabledUser o10si1930223wrh.555 - gsmtp
> >
> > Should I change the author's email address to your gmail address?
> 
> I wrote it as part of my employment by Blue River, but am currently
> moving on to another job. The policy was to have my work email on the
> patch. Seems like the same situation whenever somebody uses a work
> email and then leaves that job, just in this case the timing is
> tighter than common. I think leaving it is best.
> 
> To be clear, contributing this was definitely authorized by the
> company, I just didn't get around to sending out the patch until
> almost my last day.

Ok. We should map that non working email address to working one, having
non working email addresses in quite annoying when sending patches.

Basically there are two options:

1. Map your old bluerivertech.com address to a new address of yours,
   e.g. your gmail address.
2. Map the bluerivertech.com address to someone else (i.e. a real
   person) or a role account (e.g. kernel@bluerivertech.com).

What do you prefer?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] can: gs_usb: Zero-initialize flags

[Brian Silverman]

On Sun, Jan 9, 2022 at 2:39 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> Ok. We should map that non working email address to working one, having
> non working email addresses in quite annoying when sending patches.
>
> Basically there are two options:
>
> 1. Map your old bluerivertech.com address to a new address of yours,
>    e.g. your gmail address.
> 2. Map the bluerivertech.com address to someone else (i.e. a real
>    person) or a role account (e.g. kernel@bluerivertech.com).
>
> What do you prefer?

Map it to bsilver16384@gmail.com please.

Thanks,
Brian