All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Michal Koutn? <mkoutny@suse.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
	tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cgroup/rstat: check updated_next only for root
Date: Thu, 6 Jan 2022 00:35:42 +0000	[thread overview]
Message-ID: <20220106003542.d247w7qwtq6ajyii@master> (raw)
In-Reply-To: <20220105193504.GD6464@blackbody.suse.cz>

On Wed, Jan 05, 2022 at 08:35:04PM +0100, Michal Koutn? wrote:
>On Sat, Dec 25, 2021 at 12:09:32AM +0000, Wei Yang <richard.weiyang@gmail.com> wrote:
>> This means we can remove the check on ->updated_next, if we make sure
>> the subtree from @root is on list, which could be done by checking
>> updated_next for root.
>
>Nice refactoring.
>
>> @@ -96,9 +97,12 @@ static struct cgroup *cgroup_rstat_cpu_pop_updated(struct cgroup *pos,
>>  	 * We're gonna walk down to the first leaf and visit/remove it.  We
>>  	 * can pick whatever unvisited node as the starting point.
>>  	 */
>> -	if (!pos)
>> +	if (!pos) {
>>  		pos = root;
>> -	else
>> +		// return NULL if this subtree is not on-list
>> +		if (!cgroup_rstat_cpu(pos, cpu)->updated_next)
>> +			return NULL;
>> +	} else
>+		/* return NULL if this subtree is not on-list */
>
>Just a coding style nitpick.

Thanks for comment. Would you like me to send a v2?

>
>The patch is otherwise
>Reviewed-by: Michal Koutn? <mkoutny@suse.com>

-- 
Wei Yang
Help you, Help me

WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Michal Koutn? <mkoutny-IBi9RG/b67k@public.gmane.org>
Cc: Wei Yang
	<richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] cgroup/rstat: check updated_next only for root
Date: Thu, 6 Jan 2022 00:35:42 +0000	[thread overview]
Message-ID: <20220106003542.d247w7qwtq6ajyii@master> (raw)
In-Reply-To: <20220105193504.GD6464-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>

On Wed, Jan 05, 2022 at 08:35:04PM +0100, Michal Koutn? wrote:
>On Sat, Dec 25, 2021 at 12:09:32AM +0000, Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> This means we can remove the check on ->updated_next, if we make sure
>> the subtree from @root is on list, which could be done by checking
>> updated_next for root.
>
>Nice refactoring.
>
>> @@ -96,9 +97,12 @@ static struct cgroup *cgroup_rstat_cpu_pop_updated(struct cgroup *pos,
>>  	 * We're gonna walk down to the first leaf and visit/remove it.  We
>>  	 * can pick whatever unvisited node as the starting point.
>>  	 */
>> -	if (!pos)
>> +	if (!pos) {
>>  		pos = root;
>> -	else
>> +		// return NULL if this subtree is not on-list
>> +		if (!cgroup_rstat_cpu(pos, cpu)->updated_next)
>> +			return NULL;
>> +	} else
>+		/* return NULL if this subtree is not on-list */
>
>Just a coding style nitpick.

Thanks for comment. Would you like me to send a v2?

>
>The patch is otherwise
>Reviewed-by: Michal Koutn? <mkoutny-IBi9RG/b67k@public.gmane.org>

-- 
Wei Yang
Help you, Help me

  reply	other threads:[~2022-01-06  0:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-25  0:09 [PATCH 1/2] cgroup: rstat: explicitly put loop variant in while Wei Yang
2021-12-25  0:09 ` Wei Yang
2021-12-25  0:09 ` [PATCH 2/2] cgroup/rstat: check updated_next only for root Wei Yang
2021-12-25  0:09   ` Wei Yang
2022-01-05 19:35   ` Michal Koutný
2022-01-05 19:35     ` Michal Koutný
2022-01-06  0:35     ` Wei Yang [this message]
2022-01-06  0:35       ` Wei Yang
2022-01-06 21:55   ` Tejun Heo
2022-01-06 21:55     ` Tejun Heo
2022-01-05 19:37 ` [PATCH 1/2] cgroup: rstat: explicitly put loop variant in while Michal Koutný
2022-01-05 19:37   ` Michal Koutný
2022-01-06 21:10 ` Tejun Heo
2022-01-06 21:10   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220106003542.d247w7qwtq6ajyii@master \
    --to=richard.weiyang@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.