All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Christy Lee <christylee@fb.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Alexei Starovoitov <ast@kernel.org>
Subject: [linux-next:master 7391/10864] kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type?
Date: Fri, 7 Jan 2022 11:20:03 +0300	[thread overview]
Message-ID: <202201060848.nagWejwv-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7a769a3922d81cfc74ab4d90a9cc69485f260976
commit: 0f55f9ed21f96630c6ec96805d42f92c0b458b37 [7391/10864] bpf: Only print scratched registers and stack slots to verifier logs.
config: xtensa-randconfig-m031-20220105 (https://download.01.org/0day-ci/archive/20220106/202201060848.nagWejwv-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type?

vim +619 kernel/bpf/verifier.c

0f55f9ed21f9663 Christy Lee 2021-12-16  617  static void mark_stack_slot_scratched(struct bpf_verifier_env *env, u32 spi)
0f55f9ed21f9663 Christy Lee 2021-12-16  618  {
0f55f9ed21f9663 Christy Lee 2021-12-16 @619  	env->scratched_stack_slots |= 1UL << spi;

Use 1ULL instead.

0f55f9ed21f9663 Christy Lee 2021-12-16  620  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [linux-next:master 7391/10864] kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type?
Date: Thu, 06 Jan 2022 08:09:36 +0800	[thread overview]
Message-ID: <202201060848.nagWejwv-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Christy Lee <christylee@fb.com>
CC: Alexei Starovoitov <ast@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7a769a3922d81cfc74ab4d90a9cc69485f260976
commit: 0f55f9ed21f96630c6ec96805d42f92c0b458b37 [7391/10864] bpf: Only print scratched registers and stack slots to verifier logs.
:::::: branch date: 16 hours ago
:::::: commit date: 3 weeks ago
config: xtensa-randconfig-m031-20220105 (https://download.01.org/0day-ci/archive/20220106/202201060848.nagWejwv-lkp(a)intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type?

Old smatch warnings:
arch/xtensa/include/asm/thread_info.h:91 current_thread_info() warn: inconsistent indenting

vim +619 kernel/bpf/verifier.c

0f55f9ed21f9663 Christy Lee 2021-12-16  616  
0f55f9ed21f9663 Christy Lee 2021-12-16  617  static void mark_stack_slot_scratched(struct bpf_verifier_env *env, u32 spi)
0f55f9ed21f9663 Christy Lee 2021-12-16  618  {
0f55f9ed21f9663 Christy Lee 2021-12-16 @619  	env->scratched_stack_slots |= 1UL << spi;
0f55f9ed21f9663 Christy Lee 2021-12-16  620  }
0f55f9ed21f9663 Christy Lee 2021-12-16  621  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 7391/10864] kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type?
Date: Fri, 07 Jan 2022 11:20:03 +0300	[thread overview]
Message-ID: <202201060848.nagWejwv-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7a769a3922d81cfc74ab4d90a9cc69485f260976
commit: 0f55f9ed21f96630c6ec96805d42f92c0b458b37 [7391/10864] bpf: Only print scratched registers and stack slots to verifier logs.
config: xtensa-randconfig-m031-20220105 (https://download.01.org/0day-ci/archive/20220106/202201060848.nagWejwv-lkp(a)intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type?

vim +619 kernel/bpf/verifier.c

0f55f9ed21f9663 Christy Lee 2021-12-16  617  static void mark_stack_slot_scratched(struct bpf_verifier_env *env, u32 spi)
0f55f9ed21f9663 Christy Lee 2021-12-16  618  {
0f55f9ed21f9663 Christy Lee 2021-12-16 @619  	env->scratched_stack_slots |= 1UL << spi;

Use 1ULL instead.

0f55f9ed21f9663 Christy Lee 2021-12-16  620  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

             reply	other threads:[~2022-01-07  8:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06  0:09 kernel test robot [this message]
2022-01-07  8:20 ` [linux-next:master 7391/10864] kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type? Dan Carpenter
2022-01-07  8:20 ` Dan Carpenter
2022-01-08  0:58 ` [PATCH bpf-next] Fix incorrect integer literal used for marking scratched registers in verifier logs Christy Lee
2022-01-08  0:58   ` Christy Lee
2022-01-10 21:52   ` Song Liu
2022-01-10 21:52     ` Song Liu
2022-01-10 22:12     ` Christy Lee
2022-01-10 22:12       ` Christy Lee
2022-01-10 22:25       ` Song Liu
2022-01-10 22:25         ` Song Liu
2022-01-11  9:48       ` Dan Carpenter
2022-01-11  9:48         ` Dan Carpenter
2022-01-11  9:48         ` Dan Carpenter
2022-01-11 17:56         ` Alexei Starovoitov
2022-01-11 17:56           ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202201060848.nagWejwv-lkp@intel.com \
    --to=dan.carpenter@oracle.com \
    --cc=ast@kernel.org \
    --cc=christylee@fb.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.