* [PATCH] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
@ 2022-01-06 15:05 ` Ajit Kumar Pandey
0 siblings, 0 replies; 4+ messages in thread
From: Ajit Kumar Pandey @ 2022-01-06 15:05 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Vijendar.Mukunda, Alexander.Deucher, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, Ajit Kumar Pandey, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, V sujith kumar Reddy, open list
RT1019 components was initially registered with i2c1 and i2c2 but
now changed to i2c0 and i2c1 in most of our AMD platforms. Change
default rt1019 components to 10EC1019:00 and 10EC1019:01 which is
aligned with most of AMD machines.
Any exception to rt1019 device ids in near future board design can
be handled using dmi based quirk for that machine.
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
---
sound/soc/amd/acp/acp-mach-common.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
index 03d8d1af14b3..c9caade5cb74 100644
--- a/sound/soc/amd/acp/acp-mach-common.c
+++ b/sound/soc/amd/acp/acp-mach-common.c
@@ -293,8 +293,8 @@ static const struct snd_soc_ops acp_card_rt5682s_ops = {
/* Declare RT1019 codec components */
SND_SOC_DAILINK_DEF(rt1019,
- DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:01", "rt1019-aif"),
- COMP_CODEC("i2c-10EC1019:02", "rt1019-aif")));
+ DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:00", "rt1019-aif"),
+ COMP_CODEC("i2c-10EC1019:01", "rt1019-aif")));
static const struct snd_soc_dapm_route rt1019_map_lr[] = {
{ "Left Spk", NULL, "Left SPO" },
@@ -303,11 +303,11 @@ static const struct snd_soc_dapm_route rt1019_map_lr[] = {
static struct snd_soc_codec_conf rt1019_conf[] = {
{
- .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
+ .dlc = COMP_CODEC_CONF("i2c-10EC1019:00"),
.name_prefix = "Left",
},
{
- .dlc = COMP_CODEC_CONF("i2c-10EC1019:02"),
+ .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
.name_prefix = "Right",
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
@ 2022-01-06 15:05 ` Ajit Kumar Pandey
0 siblings, 0 replies; 4+ messages in thread
From: Ajit Kumar Pandey @ 2022-01-06 15:05 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Sunil-kumar.Dommati, Ajit Kumar Pandey, open list,
Basavaraj.Hiregoudar, Takashi Iwai, Liam Girdwood,
V sujith kumar Reddy, Vijendar.Mukunda, Alexander.Deucher
RT1019 components was initially registered with i2c1 and i2c2 but
now changed to i2c0 and i2c1 in most of our AMD platforms. Change
default rt1019 components to 10EC1019:00 and 10EC1019:01 which is
aligned with most of AMD machines.
Any exception to rt1019 device ids in near future board design can
be handled using dmi based quirk for that machine.
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
---
sound/soc/amd/acp/acp-mach-common.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
index 03d8d1af14b3..c9caade5cb74 100644
--- a/sound/soc/amd/acp/acp-mach-common.c
+++ b/sound/soc/amd/acp/acp-mach-common.c
@@ -293,8 +293,8 @@ static const struct snd_soc_ops acp_card_rt5682s_ops = {
/* Declare RT1019 codec components */
SND_SOC_DAILINK_DEF(rt1019,
- DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:01", "rt1019-aif"),
- COMP_CODEC("i2c-10EC1019:02", "rt1019-aif")));
+ DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:00", "rt1019-aif"),
+ COMP_CODEC("i2c-10EC1019:01", "rt1019-aif")));
static const struct snd_soc_dapm_route rt1019_map_lr[] = {
{ "Left Spk", NULL, "Left SPO" },
@@ -303,11 +303,11 @@ static const struct snd_soc_dapm_route rt1019_map_lr[] = {
static struct snd_soc_codec_conf rt1019_conf[] = {
{
- .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
+ .dlc = COMP_CODEC_CONF("i2c-10EC1019:00"),
.name_prefix = "Left",
},
{
- .dlc = COMP_CODEC_CONF("i2c-10EC1019:02"),
+ .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
.name_prefix = "Right",
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
2022-01-06 15:05 ` Ajit Kumar Pandey
@ 2022-01-06 20:28 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-01-06 20:28 UTC (permalink / raw)
To: Ajit Kumar Pandey, alsa-devel
Cc: Jaroslav Kysela, Liam Girdwood, open list, Basavaraj.Hiregoudar,
Takashi Iwai, Alexander.Deucher, Sunil-kumar.Dommati,
V sujith kumar Reddy, Vijendar.Mukunda
On Thu, 6 Jan 2022 20:35:21 +0530, Ajit Kumar Pandey wrote:
> RT1019 components was initially registered with i2c1 and i2c2 but
> now changed to i2c0 and i2c1 in most of our AMD platforms. Change
> default rt1019 components to 10EC1019:00 and 10EC1019:01 which is
> aligned with most of AMD machines.
>
> Any exception to rt1019 device ids in near future board design can
> be handled using dmi based quirk for that machine.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
commit: 7112550890d7e415188a3351ec0a140be60f6deb
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
@ 2022-01-06 20:28 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-01-06 20:28 UTC (permalink / raw)
To: Ajit Kumar Pandey, alsa-devel
Cc: Sunil-kumar.Dommati, Liam Girdwood, Basavaraj.Hiregoudar,
open list, Takashi Iwai, V sujith kumar Reddy, Vijendar.Mukunda,
Alexander.Deucher
On Thu, 6 Jan 2022 20:35:21 +0530, Ajit Kumar Pandey wrote:
> RT1019 components was initially registered with i2c1 and i2c2 but
> now changed to i2c0 and i2c1 in most of our AMD platforms. Change
> default rt1019 components to 10EC1019:00 and 10EC1019:01 which is
> aligned with most of AMD machines.
>
> Any exception to rt1019 device ids in near future board design can
> be handled using dmi based quirk for that machine.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
commit: 7112550890d7e415188a3351ec0a140be60f6deb
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-06 20:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 15:05 [PATCH] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id Ajit Kumar Pandey
2022-01-06 15:05 ` Ajit Kumar Pandey
2022-01-06 20:28 ` Mark Brown
2022-01-06 20:28 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.