* [PATCH] dt-bindings: net: stm32-dwmac: Make each example a separate entry
@ 2022-01-06 18:25 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-06 18:25 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Maxime Coquelin,
Alexandre Torgue, Christophe Roullier
Cc: netdev, devicetree, linux-stm32, linux-arm-kernel, linux-kernel
Each independent example should be a separate entry. This allows for
'interrupts' to have different cell sizes.
The first example also has a phandle in 'interrupts', so drop the phandle.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
index 577f4e284425..f41d5e386080 100644
--- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
@@ -102,7 +102,7 @@ examples:
compatible = "st,stm32mp1-dwmac", "snps,dwmac-4.20a";
reg = <0x5800a000 0x2000>;
reg-names = "stmmaceth";
- interrupts = <&intc GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq";
clock-names = "stmmaceth",
"mac-clk-tx",
@@ -121,6 +121,7 @@ examples:
phy-mode = "rgmii";
};
+ - |
//Example 2 (MCU example)
ethernet1: ethernet@40028000 {
compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
@@ -136,6 +137,7 @@ examples:
phy-mode = "mii";
};
+ - |
//Example 3
ethernet2: ethernet@40027000 {
compatible = "st,stm32-dwmac", "snps,dwmac-4.10a";
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dt-bindings: net: stm32-dwmac: Make each example a separate entry
@ 2022-01-06 18:25 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-06 18:25 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Maxime Coquelin,
Alexandre Torgue, Christophe Roullier
Cc: netdev, devicetree, linux-stm32, linux-arm-kernel, linux-kernel
Each independent example should be a separate entry. This allows for
'interrupts' to have different cell sizes.
The first example also has a phandle in 'interrupts', so drop the phandle.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
index 577f4e284425..f41d5e386080 100644
--- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
@@ -102,7 +102,7 @@ examples:
compatible = "st,stm32mp1-dwmac", "snps,dwmac-4.20a";
reg = <0x5800a000 0x2000>;
reg-names = "stmmaceth";
- interrupts = <&intc GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq";
clock-names = "stmmaceth",
"mac-clk-tx",
@@ -121,6 +121,7 @@ examples:
phy-mode = "rgmii";
};
+ - |
//Example 2 (MCU example)
ethernet1: ethernet@40028000 {
compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
@@ -136,6 +137,7 @@ examples:
phy-mode = "mii";
};
+ - |
//Example 3
ethernet2: ethernet@40027000 {
compatible = "st,stm32-dwmac", "snps,dwmac-4.10a";
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: stm32-dwmac: Make each example a separate entry
2022-01-06 18:25 ` Rob Herring
@ 2022-01-11 17:50 ` Rob Herring
-1 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-11 17:50 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, Maxime Coquelin, linux-stm32, David S. Miller,
netdev, Alexandre Torgue, Christophe Roullier, linux-arm-kernel,
Jakub Kicinski, devicetree
On Thu, 06 Jan 2022 12:25:16 -0600, Rob Herring wrote:
> Each independent example should be a separate entry. This allows for
> 'interrupts' to have different cell sizes.
>
> The first example also has a phandle in 'interrupts', so drop the phandle.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: stm32-dwmac: Make each example a separate entry
@ 2022-01-11 17:50 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-11 17:50 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, Maxime Coquelin, linux-stm32, David S. Miller,
netdev, Alexandre Torgue, Christophe Roullier, linux-arm-kernel,
Jakub Kicinski, devicetree
On Thu, 06 Jan 2022 12:25:16 -0600, Rob Herring wrote:
> Each independent example should be a separate entry. This allows for
> 'interrupts' to have different cell sizes.
>
> The first example also has a phandle in 'interrupts', so drop the phandle.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-11 17:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 18:25 [PATCH] dt-bindings: net: stm32-dwmac: Make each example a separate entry Rob Herring
2022-01-06 18:25 ` Rob Herring
2022-01-11 17:50 ` Rob Herring
2022-01-11 17:50 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.