From: Lahav Schlesinger <lschlesinger@drivenets.com>
To: David Ahern <dsahern@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, kuba@kernel.org, idosch@idosch.org,
nicolas.dichtel@6wind.com, nikolay@nvidia.com
Subject: Re: [PATCH net-next v6] rtnetlink: Support fine-grained netdevice bulk deletion
Date: Thu, 6 Jan 2022 21:54:36 +0200 [thread overview]
Message-ID: <20220106195435.odlagzlkikgasmwd@kgollan-pc> (raw)
In-Reply-To: <269e52cd-2d84-3bca-2045-b49806ba6501@gmail.com>
On Wed, Jan 05, 2022 at 09:09:34AM -0700, David Ahern wrote:
> CAUTION: External E-Mail - Use caution with links and attachments
>
>
> On 1/4/22 5:18 PM, David Ahern wrote:
> > On 1/4/22 1:40 PM, Lahav Schlesinger wrote:
> >> I tried using dev->unreg_list but it doesn't work e.g. for veth pairs
> >> where ->dellink() of a veth automatically adds the peer. Therefore if
> >> @ifindices contains both peers then the first ->dellink() will remove
> >> the next device from @list_kill. This caused a page fault when
> >> @list_kill was further iterated on.
> >
> > make sure you add a selftest for the bulk delete and cover cases with
> > veth, vlan, vrf, dummy, bridge, ...
> >
>
> BTW, delete of a netdev clears out neighbor entries, network addresses,
> routes, hardware updates, etc. with lots of notifications to userspace.
> Bulk delete of 1000s of netdevs is going to end up holding the rtnl for
> a "long" time. It would be good for the selftests to include a cases
> with lots of neighbor entries, routes, addresses.
Ack. I'll add such tests to v7. What numbers you have in mind for the
number of routes/neighbours etc? I suppose we don't want the tests to
run for extremely long times.
prev parent reply other threads:[~2022-01-06 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 8:10 [PATCH net-next v6] rtnetlink: Support fine-grained netdevice bulk deletion Lahav Schlesinger
2022-01-04 14:32 ` Eric Dumazet
2022-01-04 20:40 ` Lahav Schlesinger
2022-01-04 21:12 ` Jakub Kicinski
2022-01-05 0:19 ` David Ahern
2022-01-06 19:51 ` Lahav Schlesinger
2022-01-05 0:18 ` David Ahern
2022-01-05 16:09 ` David Ahern
2022-01-06 19:54 ` Lahav Schlesinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106195435.odlagzlkikgasmwd@kgollan-pc \
--to=lschlesinger@drivenets.com \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.