All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
To: jikos@kernel.org, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dianders@google.com,
	Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
Subject: [PATCH v2] HID: google: modify HID device groups of eel
Date: Fri,  7 Jan 2022 17:13:57 +0800	[thread overview]
Message-ID: <20220107091357.28960-1-xiazhengqiao@huaqin.corp-partner.google.com> (raw)

If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet
Mode Switch of eel hammer will not be detected by system. when it
is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet
Mode Switch successfully.

Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
---
 drivers/hid/hid-google-hammer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 0403beb3104b..e5acd15f4a55 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
 static const struct hid_device_id hammer_devices[] = {
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
-	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },
-- 
2.17.1


             reply	other threads:[~2022-01-07  9:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  9:13 Zhengqiao Xia [this message]
2022-01-07  9:31 ` [PATCH v2] HID: google: modify HID device groups of eel Zhengqiao Xia
2022-01-14  8:38 ` Jiri Kosina
2022-01-14 19:25   ` Stephen Boyd
2022-01-14 19:59     ` Dmitry Torokhov
2022-01-14 20:55       ` Stephen Boyd
2022-01-14 21:40         ` Dmitry Torokhov
2022-01-14 11:33 ` Re " xiazhengqiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107091357.28960-1-xiazhengqiao@huaqin.corp-partner.google.com \
    --to=xiazhengqiao@huaqin.corp-partner.google.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dianders@google.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.