All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, dianders@google.com,
	Wei-Ning Huang <wnhuang@google.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Sean O'Brien <seobrien@chromium.org>
Subject: Re: [PATCH v2] HID: google: modify HID device groups of eel
Date: Fri, 14 Jan 2022 09:38:23 +0100 (CET)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm> (raw)
In-Reply-To: <20220107091357.28960-1-xiazhengqiao@huaqin.corp-partner.google.com>

On Fri, 7 Jan 2022, Zhengqiao Xia wrote:

> If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet
> Mode Switch of eel hammer will not be detected by system. when it
> is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet
> Mode Switch successfully.
> 
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> ---
>  drivers/hid/hid-google-hammer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index 0403beb3104b..e5acd15f4a55 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
>  static const struct hid_device_id hammer_devices[] = {
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>  		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
> -	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
>  		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,

Color me confused, but anything with HID_GROUP_VIVALDI should be matched 
by hid-vivaldi driver, so what is this about?

Adding some more CCs.

Thanks,

-- 
Jiri Kosina
SUSE Labs


  parent reply	other threads:[~2022-01-14  8:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  9:13 [PATCH v2] HID: google: modify HID device groups of eel Zhengqiao Xia
2022-01-07  9:31 ` Zhengqiao Xia
2022-01-14  8:38 ` Jiri Kosina [this message]
2022-01-14 19:25   ` Stephen Boyd
2022-01-14 19:59     ` Dmitry Torokhov
2022-01-14 20:55       ` Stephen Boyd
2022-01-14 21:40         ` Dmitry Torokhov
2022-01-14 11:33 ` Re " xiazhengqiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2201140935460.28059@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dianders@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=drinkcat@chromium.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seobrien@chromium.org \
    --cc=swboyd@chromium.org \
    --cc=wnhuang@google.com \
    --cc=xiazhengqiao@huaqin.corp-partner.google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.