All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: David Disseldorp <ddiss@suse.de>
Cc: linux-fsdevel@vger.kernel.org, Martin Wilck <mwilck@suse.com>,
	viro@zeniv.linux.org.uk, willy@infradead.org
Subject: Re: [PATCH v6 1/6] initramfs: refactor do_header() cpio magic checks
Date: Fri, 7 Jan 2022 14:52:29 +0100	[thread overview]
Message-ID: <20220107135229.d3moxxff3clzslrr@wittgenstein> (raw)
In-Reply-To: <20220107133814.32655-2-ddiss@suse.de>

On Fri, Jan 07, 2022 at 02:38:09PM +0100, David Disseldorp wrote:
> do_header() is called for each cpio entry and fails if the first six
> bytes don't match "newc" magic. The magic check includes a special case
> error message if POSIX.1 ASCII (cpio -H odc) magic is detected. This
> special case POSIX.1 check can be nested under the "newc" mismatch code
> path to avoid calling memcmp() twice in a non-error case.
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> Reviewed-by: Martin Wilck <mwilck@suse.com>
> ---

Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

  reply	other threads:[~2022-01-07 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 13:38 [PATCH v6 0/6] initramfs: "crc" cpio format and INITRAMFS_PRESERVE_MTIME David Disseldorp
2022-01-07 13:38 ` [PATCH v6 1/6] initramfs: refactor do_header() cpio magic checks David Disseldorp
2022-01-07 13:52   ` Christian Brauner [this message]
2022-01-07 13:38 ` [PATCH v6 2/6] initramfs: make dir_entry.name a flexible array member David Disseldorp
2022-01-07 13:46   ` Christian Brauner
2022-01-07 13:38 ` [PATCH v6 3/6] initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option David Disseldorp
2022-03-08 13:09   ` David Disseldorp
2022-03-10  3:41     ` Andrew Morton
2022-01-07 13:38 ` [PATCH v6 4/6] gen_init_cpio: fix short read file handling David Disseldorp
2022-01-12 15:38   ` Martin Wilck
2022-01-07 13:38 ` [PATCH v6 5/6] gen_init_cpio: support file checksum archiving David Disseldorp
2022-01-07 13:38 ` [PATCH v6 6/6] initramfs: support cpio extraction with file checksums David Disseldorp
2022-01-18 17:25 ` [PATCH v6 0/6] initramfs: "crc" cpio format and INITRAMFS_PRESERVE_MTIME David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107135229.d3moxxff3clzslrr@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=ddiss@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mwilck@suse.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.