Re: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

Re: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

[Jiasheng Jiang]

On Sat, Jan 08, 2022 at 10:53:42PM +0800, Damien Le Moal wrote:
>> Cc: stable@vger.kernel.org#5.10
>
> Please keep the space before the #
>
> Cc: stable@vger.kernel.org #5.10

Actually, I added the space before, but the when I use the tool
'scripts/checkpatch.pl' to check my format, it told me a warning
that it should not have space.

The warning is as follow:
WARNING: email address 'stable@vger.kernel.org #5.10' might be
better as 'stable@vger.kernel.org#5.10'

So I have no idea what is correct.
Is the tool outdated?
If so, I will correct my cc and please update the tool.

> As commented before, what exactly was corrected ? That is what needs to be
> mentioned here. In any case, I fail to see what code change you added between v2
> and v3. The code changes are identical in the 2 versions.

Thanks, I will make the changelog more clear.
In fact, in the v2 I was careless to write '!!alt_base'.
So I removed the redundant '!' in v3.

Please tell me the right cc format, and then I will submit a new v3,
without the problems above.

Sincerely thanks,
Jiang

Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

[Damien Le Moal]

On 2022/01/08 12:55, Jiasheng Jiang wrote:
> On Sat, Jan 08, 2022 at 10:53:42PM +0800, Damien Le Moal wrote:
>>> Cc: stable@vger.kernel.org#5.10
>>
>> Please keep the space before the #
>>
>> Cc: stable@vger.kernel.org #5.10
> 
> Actually, I added the space before, but the when I use the tool
> 'scripts/checkpatch.pl' to check my format, it told me a warning
> that it should not have space.
> 
> The warning is as follow:
> WARNING: email address 'stable@vger.kernel.org #5.10' might be
> better as 'stable@vger.kernel.org#5.10'
> 
> So I have no idea what is correct.
> Is the tool outdated?
> If so, I will correct my cc and please update the tool.
> 
>> As commented before, what exactly was corrected ? That is what needs to be
>> mentioned here. In any case, I fail to see what code change you added between v2
>> and v3. The code changes are identical in the 2 versions.
> 
> Thanks, I will make the changelog more clear.
> In fact, in the v2 I was careless to write '!!alt_base'.
> So I removed the redundant '!' in v3.
> 
> Please tell me the right cc format, and then I will submit a new v3,
> without the problems above.

Cc: stable@vger.kernel.org # 5.10

Should work.

> 
> Sincerely thanks,
> Jiang
> 


-- 
Damien Le Moal
Western Digital Research

Re: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

[Jiasheng Jiang]

On Tue, Jan 11, 2022 at 10:23:29PM +0800, Naohiro Aota wrote:
> The checkpatch.pl in 5.10.90 fails to parse the line as shown
> above. That is fixed in commit fccaebf00e60 ("checkpatch: improve
> email parsing") in the current tree.

Thanks, I have sent a new v3 with the correct cc.

Sincerely thanks,
Jiang

Re: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap

[Jiasheng Jiang]

On Sun, Jan 09, 2022 at 04:53:39PM +0800, Damien Le Moal wrote:
>>>> Cc: stable@vger.kernel.org#5.10
>>>
>>> Please keep the space before the #
>>>
>>> Cc: stable@vger.kernel.org #5.10
>> 
>> Actually, I added the space before, but the when I use the tool
>> 'scripts/checkpatch.pl' to check my format, it told me a warning
>> that it should not have space.
>> 
>> The warning is as follow:
>> WARNING: email address 'stable@vger.kernel.org #5.10' might be
>> better as 'stable@vger.kernel.org#5.10'
>
> Cc: stable@vger.kernel.org # 5.10
>
> Should work.

I used 'scripts/checkpatch.pl' to check it, giving me the warning again.

The warning is as follow:
WARNING: email address 'stable@vger.kernel.org # 5.10' might be better as
'stable@vger.kernel.org# 5.10'

And if I use the 'stable@vger.kernel.org# 5.10', warning too.

The warning is as follow:
WARNING: email address 'stable@vger.kernel.org# 5.10' might be better as
'stable@vger.kernel.org#5.10' 

It seems that the only non-warning format is 'stable@vger.kernel.org#5.10'.

Sincerely thanks,
Jiang