* [PATCH] nitrogen6x: add missing pinctrl to fix mmc
@ 2022-01-05 13:17 Gary Bisson
2022-01-05 13:25 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gary Bisson @ 2022-01-05 13:17 UTC (permalink / raw)
To: u-boot; +Cc: troy.kisky, Gary Bisson
Since commit f7ac30b042d, the pin muxing for mmc was removed from the
board file to be managed by DM_MMC which requires PINCTRL to work. It
made the change for sabrelite but nitrogen configs were forgotten.
Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
configs/nitrogen6dl2g_defconfig | 2 ++
configs/nitrogen6dl_defconfig | 2 ++
configs/nitrogen6q2g_defconfig | 2 ++
configs/nitrogen6q_defconfig | 2 ++
configs/nitrogen6s1g_defconfig | 2 ++
configs/nitrogen6s_defconfig | 2 ++
6 files changed, 12 insertions(+)
diff --git a/configs/nitrogen6dl2g_defconfig b/configs/nitrogen6dl2g_defconfig
index 593a43e5e79..20c5d302577 100644
--- a/configs/nitrogen6dl2g_defconfig
+++ b/configs/nitrogen6dl2g_defconfig
@@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=y
CONFIG_FEC_MXC=y
CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
diff --git a/configs/nitrogen6dl_defconfig b/configs/nitrogen6dl_defconfig
index 4bcc6756801..796bd66bc23 100644
--- a/configs/nitrogen6dl_defconfig
+++ b/configs/nitrogen6dl_defconfig
@@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=y
CONFIG_FEC_MXC=y
CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
diff --git a/configs/nitrogen6q2g_defconfig b/configs/nitrogen6q2g_defconfig
index 76fc53d5154..b42220db064 100644
--- a/configs/nitrogen6q2g_defconfig
+++ b/configs/nitrogen6q2g_defconfig
@@ -70,6 +70,8 @@ CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=y
CONFIG_FEC_MXC=y
CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
diff --git a/configs/nitrogen6q_defconfig b/configs/nitrogen6q_defconfig
index fca3e5f5311..cc085594967 100644
--- a/configs/nitrogen6q_defconfig
+++ b/configs/nitrogen6q_defconfig
@@ -70,6 +70,8 @@ CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=y
CONFIG_FEC_MXC=y
CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
diff --git a/configs/nitrogen6s1g_defconfig b/configs/nitrogen6s1g_defconfig
index 8b720b0d600..17133c5cd60 100644
--- a/configs/nitrogen6s1g_defconfig
+++ b/configs/nitrogen6s1g_defconfig
@@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=y
CONFIG_FEC_MXC=y
CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
diff --git a/configs/nitrogen6s_defconfig b/configs/nitrogen6s_defconfig
index a9d239e9be9..242580e3e9f 100644
--- a/configs/nitrogen6s_defconfig
+++ b/configs/nitrogen6s_defconfig
@@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=y
CONFIG_FEC_MXC=y
CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nitrogen6x: add missing pinctrl to fix mmc
2022-01-05 13:17 [PATCH] nitrogen6x: add missing pinctrl to fix mmc Gary Bisson
@ 2022-01-05 13:25 ` Fabio Estevam
2022-01-06 22:04 ` Troy Kisky
2022-01-09 1:28 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-01-05 13:25 UTC (permalink / raw)
To: Gary Bisson, Stefano Babic, Tom Rini; +Cc: U-Boot-Denx, Troy Kisky
Hi Gary,
On Wed, Jan 5, 2022 at 10:18 AM Gary Bisson
<gary.bisson@boundarydevices.com> wrote:
>
> Since commit f7ac30b042d, the pin muxing for mmc was removed from the
> board file to be managed by DM_MMC which requires PINCTRL to work. It
> made the change for sabrelite but nitrogen configs were forgotten.
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Since it is a bug fix, it would be nice to get included in the 2022.01 release.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nitrogen6x: add missing pinctrl to fix mmc
2022-01-05 13:17 [PATCH] nitrogen6x: add missing pinctrl to fix mmc Gary Bisson
2022-01-05 13:25 ` Fabio Estevam
@ 2022-01-06 22:04 ` Troy Kisky
2022-01-09 1:28 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Troy Kisky @ 2022-01-06 22:04 UTC (permalink / raw)
To: Gary Bisson, u-boot
On 1/5/2022 5:17 AM, Gary Bisson wrote:
> Since commit f7ac30b042d, the pin muxing for mmc was removed from the
> board file to be managed by DM_MMC which requires PINCTRL to work. It
> made the change for sabrelite but nitrogen configs were forgotten.
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> configs/nitrogen6dl2g_defconfig | 2 ++
> configs/nitrogen6dl_defconfig | 2 ++
> configs/nitrogen6q2g_defconfig | 2 ++
> configs/nitrogen6q_defconfig | 2 ++
> configs/nitrogen6s1g_defconfig | 2 ++
> configs/nitrogen6s_defconfig | 2 ++
> 6 files changed, 12 insertions(+)
>
> diff --git a/configs/nitrogen6dl2g_defconfig b/configs/nitrogen6dl2g_defconfig
> index 593a43e5e79..20c5d302577 100644
> --- a/configs/nitrogen6dl2g_defconfig
> +++ b/configs/nitrogen6dl2g_defconfig
> @@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
> CONFIG_PHY_MICREL_KSZ90X1=y
> CONFIG_FEC_MXC=y
> CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_IMX6=y
> CONFIG_MXC_UART=y
> CONFIG_SPI=y
> CONFIG_DM_SPI=y
> diff --git a/configs/nitrogen6dl_defconfig b/configs/nitrogen6dl_defconfig
> index 4bcc6756801..796bd66bc23 100644
> --- a/configs/nitrogen6dl_defconfig
> +++ b/configs/nitrogen6dl_defconfig
> @@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
> CONFIG_PHY_MICREL_KSZ90X1=y
> CONFIG_FEC_MXC=y
> CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_IMX6=y
> CONFIG_MXC_UART=y
> CONFIG_SPI=y
> CONFIG_DM_SPI=y
> diff --git a/configs/nitrogen6q2g_defconfig b/configs/nitrogen6q2g_defconfig
> index 76fc53d5154..b42220db064 100644
> --- a/configs/nitrogen6q2g_defconfig
> +++ b/configs/nitrogen6q2g_defconfig
> @@ -70,6 +70,8 @@ CONFIG_PHY_MICREL=y
> CONFIG_PHY_MICREL_KSZ90X1=y
> CONFIG_FEC_MXC=y
> CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_IMX6=y
> CONFIG_MXC_UART=y
> CONFIG_SPI=y
> CONFIG_DM_SPI=y
> diff --git a/configs/nitrogen6q_defconfig b/configs/nitrogen6q_defconfig
> index fca3e5f5311..cc085594967 100644
> --- a/configs/nitrogen6q_defconfig
> +++ b/configs/nitrogen6q_defconfig
> @@ -70,6 +70,8 @@ CONFIG_PHY_MICREL=y
> CONFIG_PHY_MICREL_KSZ90X1=y
> CONFIG_FEC_MXC=y
> CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_IMX6=y
> CONFIG_MXC_UART=y
> CONFIG_SPI=y
> CONFIG_DM_SPI=y
> diff --git a/configs/nitrogen6s1g_defconfig b/configs/nitrogen6s1g_defconfig
> index 8b720b0d600..17133c5cd60 100644
> --- a/configs/nitrogen6s1g_defconfig
> +++ b/configs/nitrogen6s1g_defconfig
> @@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
> CONFIG_PHY_MICREL_KSZ90X1=y
> CONFIG_FEC_MXC=y
> CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_IMX6=y
> CONFIG_MXC_UART=y
> CONFIG_SPI=y
> CONFIG_DM_SPI=y
> diff --git a/configs/nitrogen6s_defconfig b/configs/nitrogen6s_defconfig
> index a9d239e9be9..242580e3e9f 100644
> --- a/configs/nitrogen6s_defconfig
> +++ b/configs/nitrogen6s_defconfig
> @@ -68,6 +68,8 @@ CONFIG_PHY_MICREL=y
> CONFIG_PHY_MICREL_KSZ90X1=y
> CONFIG_FEC_MXC=y
> CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_IMX6=y
> CONFIG_MXC_UART=y
> CONFIG_SPI=y
> CONFIG_DM_SPI=y
Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nitrogen6x: add missing pinctrl to fix mmc
2022-01-05 13:17 [PATCH] nitrogen6x: add missing pinctrl to fix mmc Gary Bisson
2022-01-05 13:25 ` Fabio Estevam
2022-01-06 22:04 ` Troy Kisky
@ 2022-01-09 1:28 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-01-09 1:28 UTC (permalink / raw)
To: Gary Bisson; +Cc: u-boot, troy.kisky
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Wed, Jan 05, 2022 at 02:17:53PM +0100, Gary Bisson wrote:
> Since commit f7ac30b042d, the pin muxing for mmc was removed from the
> board file to be managed by DM_MMC which requires PINCTRL to work. It
> made the change for sabrelite but nitrogen configs were forgotten.
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-09 1:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 13:17 [PATCH] nitrogen6x: add missing pinctrl to fix mmc Gary Bisson
2022-01-05 13:25 ` Fabio Estevam
2022-01-06 22:04 ` Troy Kisky
2022-01-09 1:28 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.