From: kernel test robot <lkp@intel.com> To: Hans de Goede <hdegoede@redhat.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Andy Shevchenko <andy@kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Linus Walleij <linus.walleij@linaro.org> Cc: kbuild-all@lists.01.org, Hans de Goede <hdegoede@redhat.com>, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs Date: Sun, 9 Jan 2022 02:54:28 +0800 [thread overview] Message-ID: <202201090243.oStM3Qc9-lkp@intel.com> (raw) In-Reply-To: <20220107234456.148389-1-hdegoede@redhat.com> Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on linusw-pinctrl/devel] [also build test WARNING on v5.16-rc8 next-20220107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/pinctrl-baytrail-Clear-direct_irq_en-flag-on-broken-configs/20220108-074637 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel config: i386-randconfig-r013-20220108 (https://download.01.org/0day-ci/archive/20220109/202201090243.oStM3Qc9-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/fc9eb527f62b0bebde64745ec5b0a838fde7ef41 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hans-de-Goede/pinctrl-baytrail-Clear-direct_irq_en-flag-on-broken-configs/20220108-074637 git checkout fc9eb527f62b0bebde64745ec5b0a838fde7ef41 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pinctrl/intel/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/acpi.h:15, from drivers/pinctrl/intel/pinctrl-baytrail.c:9: drivers/pinctrl/intel/pinctrl-baytrail.c: In function 'byt_direct_irq_sanity_check': >> drivers/pinctrl/intel/pinctrl-baytrail.c:1483:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'int' [-Wformat=] 1483 | dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:129:27: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:163:31: note: in expansion of macro 'dev_fmt' 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ | ^~~~~~~ drivers/pinctrl/intel/pinctrl-baytrail.c:1483:3: note: in expansion of macro 'dev_dbg' 1483 | dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); | ^~~~~~~ drivers/pinctrl/intel/pinctrl-baytrail.c:1483:47: note: format string is defined here 1483 | dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); | ~~^ | | | long int | %d vim +1483 drivers/pinctrl/intel/pinctrl-baytrail.c 1468 1469 static bool byt_direct_irq_sanity_check(struct intel_pinctrl *vg, int pin, u32 value) 1470 { 1471 u8 *match, direct_irq[16]; 1472 1473 if (!(value & (BYT_TRIG_POS | BYT_TRIG_NEG))) { 1474 dev_warn(vg->dev, 1475 FW_BUG "pin %i: direct_irq_en set without trigger, clearing\n", pin); 1476 return false; 1477 } 1478 1479 memcpy_fromio(direct_irq, vg->communities->pad_regs + BYT_DIRECT_IRQ_REG, 1480 sizeof(direct_irq)); 1481 match = memchr(direct_irq, pin, sizeof(direct_irq)); 1482 if (match) > 1483 dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); 1484 else 1485 dev_warn(vg->dev, FW_BUG "pin %i: direct_irq_en set but no IRQ assigned, clearing\n", pin); 1486 1487 return match; 1488 } 1489 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs Date: Sun, 09 Jan 2022 02:54:28 +0800 [thread overview] Message-ID: <202201090243.oStM3Qc9-lkp@intel.com> (raw) In-Reply-To: <20220107234456.148389-1-hdegoede@redhat.com> [-- Attachment #1: Type: text/plain, Size: 4055 bytes --] Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on linusw-pinctrl/devel] [also build test WARNING on v5.16-rc8 next-20220107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/pinctrl-baytrail-Clear-direct_irq_en-flag-on-broken-configs/20220108-074637 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel config: i386-randconfig-r013-20220108 (https://download.01.org/0day-ci/archive/20220109/202201090243.oStM3Qc9-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/fc9eb527f62b0bebde64745ec5b0a838fde7ef41 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hans-de-Goede/pinctrl-baytrail-Clear-direct_irq_en-flag-on-broken-configs/20220108-074637 git checkout fc9eb527f62b0bebde64745ec5b0a838fde7ef41 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pinctrl/intel/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/acpi.h:15, from drivers/pinctrl/intel/pinctrl-baytrail.c:9: drivers/pinctrl/intel/pinctrl-baytrail.c: In function 'byt_direct_irq_sanity_check': >> drivers/pinctrl/intel/pinctrl-baytrail.c:1483:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'int' [-Wformat=] 1483 | dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:129:27: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:163:31: note: in expansion of macro 'dev_fmt' 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ | ^~~~~~~ drivers/pinctrl/intel/pinctrl-baytrail.c:1483:3: note: in expansion of macro 'dev_dbg' 1483 | dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); | ^~~~~~~ drivers/pinctrl/intel/pinctrl-baytrail.c:1483:47: note: format string is defined here 1483 | dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); | ~~^ | | | long int | %d vim +1483 drivers/pinctrl/intel/pinctrl-baytrail.c 1468 1469 static bool byt_direct_irq_sanity_check(struct intel_pinctrl *vg, int pin, u32 value) 1470 { 1471 u8 *match, direct_irq[16]; 1472 1473 if (!(value & (BYT_TRIG_POS | BYT_TRIG_NEG))) { 1474 dev_warn(vg->dev, 1475 FW_BUG "pin %i: direct_irq_en set without trigger, clearing\n", pin); 1476 return false; 1477 } 1478 1479 memcpy_fromio(direct_irq, vg->communities->pad_regs + BYT_DIRECT_IRQ_REG, 1480 sizeof(direct_irq)); 1481 match = memchr(direct_irq, pin, sizeof(direct_irq)); 1482 if (match) > 1483 dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match - direct_irq); 1484 else 1485 dev_warn(vg->dev, FW_BUG "pin %i: direct_irq_en set but no IRQ assigned, clearing\n", pin); 1486 1487 return match; 1488 } 1489 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-08 18:55 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-07 23:44 [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs Hans de Goede [not found] ` <CAHp75Vfgpm7sROw_Ay8+tK0bhu-kCbS=O_kwax+i_vaH7H4wXA@mail.gmail.com> 2022-01-08 9:59 ` [PATCH] " Hans de Goede 2022-01-12 20:20 ` Hans de Goede 2022-01-12 20:42 ` Andy Shevchenko 2022-01-12 20:45 ` Hans de Goede 2022-01-08 18:54 ` [PATCH v3] " kernel test robot 2022-01-08 18:54 ` kernel test robot 2022-01-12 19:58 ` Hans de Goede 2022-01-12 19:58 ` Hans de Goede 2022-01-12 20:44 ` Andy Shevchenko 2022-01-12 20:44 ` Andy Shevchenko 2022-01-12 20:50 ` Hans de Goede 2022-01-12 20:50 ` Hans de Goede 2022-01-12 21:01 ` Andy Shevchenko 2022-01-12 21:01 ` Andy Shevchenko 2022-01-08 18:54 ` kernel test robot [this message] 2022-01-08 18:54 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202201090243.oStM3Qc9-lkp@intel.com \ --to=lkp@intel.com \ --cc=andy@kernel.org \ --cc=bgolaszewski@baylibre.com \ --cc=hdegoede@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.