Re: [PATCH u-boot-marvell v2] arm: mvebu: turris_omnia: Fixup SATA or PCIe nodes at runtime in DT blob

From: "Pali Rohár" <pali@kernel.org>
To: Stefan Roese <sr@denx.de>
Cc: "Marek Behún" <kabel@kernel.org>,
	u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell v2] arm: mvebu: turris_omnia: Fixup SATA or PCIe nodes at runtime in DT blob
Date: Mon, 10 Jan 2022 10:06:25 +0100	[thread overview]
Message-ID: <20220110090625.i2nive52tufw6jx4@pali> (raw)
In-Reply-To: <cca2efc0-aac9-1976-ae90-639cdcb4aa4b@denx.de>

On Monday 10 January 2022 08:43:17 Stefan Roese wrote:
> > +	/* If mSATA card is not present, disable SATA DT node */
> > +	if (!mode_sata) {
> > +		fdt_for_each_node_by_compatible (node, blob, -1,
> > +						 "marvell,armada-380-ahci") {
> 
> Why are adding the space before the "(" here? This does not seem the
> common and preferred coding style AFAICT.

Hello Stefan! Just to note that I'm adding this space too when writing
for-loops. E.g.:

for (i = 0; i < 10; i++) {
...
}

or:

fdt_for_each_node_by_compatible (node, blob, -1, compatible) {
...
}

> > +			if (!fdtdec_get_is_enabled(blob, node))
> > +				continue;
> > +
> > +			if (fdt_status_disabled(blob, node) < 0)
> > +				printf("Cannot disable SATA DT node!\n");
> > +			else
> > +				debug("Disabled SATA DT node\n");
> > +
> > +			break;
> > +		}
> > +
> > +		return;
> > +	}