From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-fbdev@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, Kris Karas <bugs-a21@moonlit-rail.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Peter Robinson <pbrobinson@gmail.com>, Thomas Zimmermann <tzimmermann@suse.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Borislav Petkov <bp@suse.de> Subject: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Date: Mon, 10 Jan 2022 10:56:23 +0100 [thread overview] Message-ID: <20220110095625.278836-1-javierm@redhat.com> (raw) This patch series contains two fixes for the vga16fb driver. I looked at the driver due a regression reported [0], caused by commit d391c5827107 ("drivers/firmware: move x86 Generic System Framebuffers support"). The mentioned commit didn't change any logic but just moved the platform device registration that matches the vesafb and efifb drivers to happen later. And this caused the vga16fb driver to be probed even in machines that don't have an EGA or VGA video adapter. This is a v2 of the patch series that addresses issues pointed out by Geert Uytterhoeven. Patch #1 is fixing the wrong check to determine if either EGA or VGA is used and patch #2 adds a check to the driver to only be loaded for EGA and VGA 16 color graphic cards. [0]: https://bugzilla.kernel.org/show_bug.cgi?id=215001 Best regards, Javier Changes in v2: - Make the change only for x86 (Geert Uytterhoeven) - Only check the suppported video mode for x86 (Geert Uytterhoeven). Javier Martinez Canillas (2): video: vga16fb: Fix logic that checks for the display standard video: vga16fb: Only probe for EGA and VGA 16 color graphic cards drivers/video/fbdev/vga16fb.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) -- 2.33.1
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Kris Karas <bugs-a21@moonlit-rail.com>, Peter Robinson <pbrobinson@gmail.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Javier Martinez Canillas <javierm@redhat.com>, Borislav Petkov <bp@suse.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Date: Mon, 10 Jan 2022 10:56:23 +0100 [thread overview] Message-ID: <20220110095625.278836-1-javierm@redhat.com> (raw) This patch series contains two fixes for the vga16fb driver. I looked at the driver due a regression reported [0], caused by commit d391c5827107 ("drivers/firmware: move x86 Generic System Framebuffers support"). The mentioned commit didn't change any logic but just moved the platform device registration that matches the vesafb and efifb drivers to happen later. And this caused the vga16fb driver to be probed even in machines that don't have an EGA or VGA video adapter. This is a v2 of the patch series that addresses issues pointed out by Geert Uytterhoeven. Patch #1 is fixing the wrong check to determine if either EGA or VGA is used and patch #2 adds a check to the driver to only be loaded for EGA and VGA 16 color graphic cards. [0]: https://bugzilla.kernel.org/show_bug.cgi?id=215001 Best regards, Javier Changes in v2: - Make the change only for x86 (Geert Uytterhoeven) - Only check the suppported video mode for x86 (Geert Uytterhoeven). Javier Martinez Canillas (2): video: vga16fb: Fix logic that checks for the display standard video: vga16fb: Only probe for EGA and VGA 16 color graphic cards drivers/video/fbdev/vga16fb.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) -- 2.33.1
next reply other threads:[~2022-01-10 9:56 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-10 9:56 Javier Martinez Canillas [this message] 2022-01-10 9:56 ` [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Javier Martinez Canillas 2022-01-10 9:56 ` [PATCH v2 1/2] video: vga16fb: Fix logic that checks for the display standard Javier Martinez Canillas 2022-01-10 9:56 ` Javier Martinez Canillas 2022-01-10 9:56 ` [PATCH v2 2/2] video: vga16fb: Only probe for EGA and VGA 16 color graphic cards Javier Martinez Canillas 2022-01-10 9:56 ` Javier Martinez Canillas 2022-01-11 13:16 ` [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Maxime Ripard 2022-01-11 13:16 ` Maxime Ripard 2022-01-12 2:19 ` Kris Karas (Bug reporting) 2022-01-12 2:19 ` Kris Karas (Bug reporting) 2022-01-12 7:57 ` Geert Uytterhoeven 2022-01-12 7:57 ` Geert Uytterhoeven 2022-01-12 11:38 ` Javier Martinez Canillas 2022-01-12 11:38 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220110095625.278836-1-javierm@redhat.com \ --to=javierm@redhat.com \ --cc=bp@suse.de \ --cc=bugs-a21@moonlit-rail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pbrobinson@gmail.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.