* [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov
@ 2022-01-10 8:58 yegorslists--- via buildroot
2022-01-10 8:58 ` [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface yegorslists--- via buildroot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: yegorslists--- via buildroot @ 2022-01-10 8:58 UTC (permalink / raw)
To: buildroot; +Cc: Wojciech M . Zabolotny
From: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
DEVELOPERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/DEVELOPERS b/DEVELOPERS
index cd0b54b041..7a9f0f7370 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2968,6 +2968,7 @@ F: configs/beaglebone_defconfig
F: configs/beaglebone_qt5_defconfig
F: package/acl/
F: package/attr/
+F: package/avrdude/
F: package/boost/
F: package/bootstrap/
F: package/cannelloni/
--
2.17.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface
2022-01-10 8:58 [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov yegorslists--- via buildroot
@ 2022-01-10 8:58 ` yegorslists--- via buildroot
2022-01-10 14:04 ` Yann E. MORIN
2022-01-10 14:14 ` [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov Yann E. MORIN
2022-01-27 18:30 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: yegorslists--- via buildroot @ 2022-01-10 8:58 UTC (permalink / raw)
To: buildroot; +Cc: Wojciech M . Zabolotny
From: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
package/avrdude/Config.in | 3 +++
package/avrdude/avrdude.mk | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
index 89558a5ff5..57a8df66ea 100644
--- a/package/avrdude/Config.in
+++ b/package/avrdude/Config.in
@@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
if BR2_PACKAGE_AVRDUDE
+config BR2_PACKAGE_AVRDUDE_LINUXGPIO
+ bool "Linux sysfs GPIO interface support"
+
config BR2_PACKAGE_AVRDUDE_SPI
bool "SPI support"
default y # Backward compatibility
diff --git a/package/avrdude/avrdude.mk b/package/avrdude/avrdude.mk
index accd92c1d5..3ccba80d8e 100644
--- a/package/avrdude/avrdude.mk
+++ b/package/avrdude/avrdude.mk
@@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
host-flex host-bison
+ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
+AVRDUDE_CONF_OPTS += --enable-linuxgpio
+else
+AVRDUDE_CONF_OPTS += --disable-linuxgpio
+endif
+
ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
AVRDUDE_CONF_OPTS += --enable-linuxspi
else
--
2.17.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface
2022-01-10 8:58 ` [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface yegorslists--- via buildroot
@ 2022-01-10 14:04 ` Yann E. MORIN
2022-01-10 17:59 ` Yegor Yefremov via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2022-01-10 14:04 UTC (permalink / raw)
To: yegorslists; +Cc: Wojciech M . Zabolotny, buildroot
Yegor, All,
On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/avrdude/Config.in | 3 +++
> package/avrdude/avrdude.mk | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
> index 89558a5ff5..57a8df66ea 100644
> --- a/package/avrdude/Config.in
> +++ b/package/avrdude/Config.in
> @@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
>
> if BR2_PACKAGE_AVRDUDE
>
> +config BR2_PACKAGE_AVRDUDE_LINUXGPIO
> + bool "Linux sysfs GPIO interface support"
> +
> config BR2_PACKAGE_AVRDUDE_SPI
> bool "SPI support"
> default y # Backward compatibility
> diff --git a/package/avrdude/avrdude.mk b/package/avrdude/avrdude.mk
> index accd92c1d5..3ccba80d8e 100644
> --- a/package/avrdude/avrdude.mk
> +++ b/package/avrdude/avrdude.mk
> @@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
> AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
> host-flex host-bison
>
> +ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
> +AVRDUDE_CONF_OPTS += --enable-linuxgpio
> +else
> +AVRDUDE_CONF_OPTS += --disable-linuxgpio
> +endif
We already have an unconditional activation of those:
https://github.com/buildroot/buildroot/blob/master/package/avrdude/avrdude.mk#L15
(which you can btw. incidentally also notice as part the hunk header).
So, if the intention was to be able to enable linux-gpio, then this is a
noop as they are already enabled. If the intention was to be able to
disable them, then the unconditional enable should be dropped.
But then, does it make sense to be able to disable linux GPIO?
And what if both SPI and GPIO are disabled?
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
> AVRDUDE_CONF_OPTS += --enable-linuxspi
> else
> --
> 2.17.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov
2022-01-10 8:58 [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov yegorslists--- via buildroot
2022-01-10 8:58 ` [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface yegorslists--- via buildroot
@ 2022-01-10 14:14 ` Yann E. MORIN
2022-01-27 18:30 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2022-01-10 14:14 UTC (permalink / raw)
To: yegorslists; +Cc: Wojciech M . Zabolotny, buildroot
Yegor, All,
On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> DEVELOPERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index cd0b54b041..7a9f0f7370 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2968,6 +2968,7 @@ F: configs/beaglebone_defconfig
> F: configs/beaglebone_qt5_defconfig
> F: package/acl/
> F: package/attr/
> +F: package/avrdude/
> F: package/boost/
> F: package/bootstrap/
> F: package/cannelloni/
> --
> 2.17.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface
2022-01-10 14:04 ` Yann E. MORIN
@ 2022-01-10 17:59 ` Yegor Yefremov via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Yegor Yefremov via buildroot @ 2022-01-10 17:59 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Wojciech M . Zabolotny, buildroot
Hi Yann, all,
On Mon, Jan 10, 2022 at 3:04 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Yegor, All,
>
> On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> > package/avrdude/Config.in | 3 +++
> > package/avrdude/avrdude.mk | 6 ++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
> > index 89558a5ff5..57a8df66ea 100644
> > --- a/package/avrdude/Config.in
> > +++ b/package/avrdude/Config.in
> > @@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
> >
> > if BR2_PACKAGE_AVRDUDE
> >
> > +config BR2_PACKAGE_AVRDUDE_LINUXGPIO
> > + bool "Linux sysfs GPIO interface support"
> > +
> > config BR2_PACKAGE_AVRDUDE_SPI
> > bool "SPI support"
> > default y # Backward compatibility
> > diff --git a/package/avrdude/avrdude.mk b/package/avrdude/avrdude.mk
> > index accd92c1d5..3ccba80d8e 100644
> > --- a/package/avrdude/avrdude.mk
> > +++ b/package/avrdude/avrdude.mk
> > @@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
> > AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
> > host-flex host-bison
> >
> > +ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
> > +AVRDUDE_CONF_OPTS += --enable-linuxgpio
> > +else
> > +AVRDUDE_CONF_OPTS += --disable-linuxgpio
> > +endif
>
> We already have an unconditional activation of those:
>
> https://github.com/buildroot/buildroot/blob/master/package/avrdude/avrdude.mk#L15
>
> (which you can btw. incidentally also notice as part the hunk header).
My bad. I have just overlooked this setting. You can drop the patch.
Regards,
Yegor
> So, if the intention was to be able to enable linux-gpio, then this is a
> noop as they are already enabled. If the intention was to be able to
> disable them, then the unconditional enable should be dropped.
>
> But then, does it make sense to be able to disable linux GPIO?
>
> And what if both SPI and GPIO are disabled?
>
> Regards,
> Yann E. MORIN.
>
> > ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
> > AVRDUDE_CONF_OPTS += --enable-linuxspi
> > else
> > --
> > 2.17.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov
2022-01-10 8:58 [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov yegorslists--- via buildroot
2022-01-10 8:58 ` [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface yegorslists--- via buildroot
2022-01-10 14:14 ` [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov Yann E. MORIN
@ 2022-01-27 18:30 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-01-27 18:30 UTC (permalink / raw)
To: yegorslists--- via buildroot; +Cc: Wojciech M . Zabolotny
>>>>> "yegorslists---" == yegorslists--- via buildroot <buildroot@buildroot.org> writes:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Committed to 2021.02.x and 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-27 18:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 8:58 [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov yegorslists--- via buildroot
2022-01-10 8:58 ` [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface yegorslists--- via buildroot
2022-01-10 14:04 ` Yann E. MORIN
2022-01-10 17:59 ` Yegor Yefremov via buildroot
2022-01-10 14:14 ` [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov Yann E. MORIN
2022-01-27 18:30 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.