[PATCH net-next] Revert "net: vertexcom: default to disabled on kbuild"

[PATCH net-next] Revert "net: vertexcom: default to disabled on kbuild"

[Saeed Mahameed]

From: Saeed Mahameed <saeedm@nvidia.com>

This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.

To align with other vendors, NET_VENDOR configs are supposed to be ON by
default, while their drivers should default to OFF.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/vertexcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/vertexcom/Kconfig b/drivers/net/ethernet/vertexcom/Kconfig
index 6e2cf062ddba..4184a635fe01 100644
--- a/drivers/net/ethernet/vertexcom/Kconfig
+++ b/drivers/net/ethernet/vertexcom/Kconfig
@@ -5,7 +5,7 @@
 
 config NET_VENDOR_VERTEXCOM
 	bool "Vertexcom devices"
-	default n
+	default y
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
-- 
2.34.1

Re: [PATCH net-next] Revert "net: vertexcom: default to disabled on kbuild"

[Jakub Kicinski]

On Mon, 10 Jan 2022 12:52:46 -0800 Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.
> 
> To align with other vendors, NET_VENDOR configs are supposed to be ON by
> default, while their drivers should default to OFF.

Still planning to rework everything to default to 'n' in net-next later
or did you change your mind? :)

Re: [PATCH net-next] Revert "net: vertexcom: default to disabled on kbuild"

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 10 Jan 2022 12:52:46 -0800 you wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.
> 
> To align with other vendors, NET_VENDOR configs are supposed to be ON by
> default, while their drivers should default to OFF.
> 
> [...]

Here is the summary with links:
  - [net-next] Revert "net: vertexcom: default to disabled on kbuild"
    https://git.kernel.org/netdev/net/c/7d6019b602de

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next] Revert "net: vertexcom: default to disabled on kbuild"

[Saeed Mahameed]

On Mon, Jan 10, 2022 at 06:54:54PM -0800, Jakub Kicinski wrote:
>On Mon, 10 Jan 2022 12:52:46 -0800 Saeed Mahameed wrote:
>> From: Saeed Mahameed <saeedm@nvidia.com>
>>
>> This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.
>>
>> To align with other vendors, NET_VENDOR configs are supposed to be ON by
>> default, while their drivers should default to OFF.
>
>Still planning to rework everything to default to 'n' in net-next later
>or did you change your mind? :)

absolutely, I wouldn't miss any chance to write a sed regex to make a
major patch for me ;), I am just waiting for the next release.