All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Li Ning <lining2020x@163.com>,
	Tejun Heo <tj@kernel.org>, Chunguang Xu <brookxu@tencent.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: [RFC PATCH 0/7] block: improve iops limit throttle
Date: Tue, 11 Jan 2022 19:55:25 +0800	[thread overview]
Message-ID: <20220111115532.497117-1-ming.lei@redhat.com> (raw)

Hello Guys,

Lining reported that iops limit throttle doesn't work on dm-thin, also
iops limit throttle works bad on plain disk in case of excessive split.

Commit 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for large IO scenarios")
was for addressing this issue, but the taken approach is just to run
post-accounting, then current split bios won't be throttled actually,
so actual iops throttle result isn't good in case of excessive bio
splitting.

The 1st two patches are cleanup.

The 3rd and 4th patches add one new helper of __submit_bio_noacct() for
blk_throtl_dispatch_work_fn(), so that bios won't be throttled any more
when blk-throttle code dispatches throttled bios.

The 5th and 6th patch makes the real difference for throttling split bio wrt.
iops limit.

The last patch is to revert commit 4f1e9630afe6 ("blk-throtl: optimize IOPS
throttle for large IO scenarios").

Lining, you should get exact IOPS throttling in your dm-thin test with
this patchset, please test and feedback.


Ming Lei (7):
  block: move submit_bio_checks() into submit_bio_noacct
  block: move blk_crypto_bio_prep() out of blk-mq.c
  block: allow to bypass bio check before submitting bio
  block: don't check bio in blk_throtl_dispatch_work_fn
  block: throttle split bio in case of iops limit
  block: don't try to throttle split bio if iops limit isn't set
  block: revert 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for
    large IO scenarios")

 block/blk-core.c       | 32 +++++++++-------------
 block/blk-merge.c      |  2 --
 block/blk-mq.c         |  3 ---
 block/blk-throttle.c   | 61 +++++++++++++++---------------------------
 block/blk-throttle.h   | 16 ++++++-----
 include/linux/blkdev.h |  7 ++++-
 6 files changed, 51 insertions(+), 70 deletions(-)

-- 
2.31.1


             reply	other threads:[~2022-01-11 11:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 11:55 Ming Lei [this message]
2022-01-11 11:55 ` [RFC PATCH 1/7] block: move submit_bio_checks() into submit_bio_noacct Ming Lei
2022-01-17  8:20   ` Christoph Hellwig
2022-01-11 11:55 ` [RFC PATCH 2/7] block: move blk_crypto_bio_prep() out of blk-mq.c Ming Lei
2022-01-11 11:55 ` [RFC PATCH 3/7] block: allow to bypass bio check before submitting bio Ming Lei
2022-01-17  8:21   ` Christoph Hellwig
2022-02-09  8:12     ` Ming Lei
2022-02-09  8:16       ` Christoph Hellwig
2022-02-09  8:35         ` Ming Lei
2022-01-11 11:55 ` [RFC PATCH 4/7] block: don't check bio in blk_throtl_dispatch_work_fn Ming Lei
2022-01-11 11:55 ` [RFC PATCH 5/7] block: throttle split bio in case of iops limit Ming Lei
2022-01-11 11:55 ` [RFC PATCH 6/7] block: don't try to throttle split bio if iops limit isn't set Ming Lei
2022-01-11 11:55 ` [RFC PATCH 7/7] block: revert 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for large IO scenarios") Ming Lei
     [not found] ` <4666c796.5083.17e4d67bb88.Coremail.lining2020x@163.com>
     [not found]   ` <d7c6f47.2d01.17e51b058cc.Coremail.lining2020x@163.com>
2022-01-17  7:46     ` [RFC PATCH 0/7] block: improve iops limit throttle 163

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111115532.497117-1-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=brookxu@tencent.com \
    --cc=lining2020x@163.com \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.