All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Li Ning <lining2020x@163.com>,
	Tejun Heo <tj@kernel.org>, Chunguang Xu <brookxu@tencent.com>
Subject: Re: [RFC PATCH 3/7] block: allow to bypass bio check before submitting bio
Date: Wed, 9 Feb 2022 16:12:43 +0800	[thread overview]
Message-ID: <YgN3e98Px8F5w3q/@T590> (raw)
In-Reply-To: <YeUnERz9Qoz2UtVn@infradead.org>

On Mon, Jan 17, 2022 at 12:21:37AM -0800, Christoph Hellwig wrote:
> 
> >   * systems and other upper level users of the block layer should use
> >   * submit_bio() instead.
> >   */
> > -void submit_bio_noacct(struct bio *bio)
> > +void __submit_bio_noacct(struct bio *bio, bool check)
> >  {
> > -	if (unlikely(!submit_bio_checks(bio)))
> > +	if (unlikely(check && !submit_bio_checks(bio)))
> >  		return;
> 
> This doesn't make sense as an API - you can just move the checks
> into the caller that pass check=true.

But submit_bio_checks() is local helper, and it is hard to make it
public to drivers. Not mention there are lots of callers to
submit_bio_noacct().


Thanks,
Ming


  reply	other threads:[~2022-02-09  8:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 11:55 [RFC PATCH 0/7] block: improve iops limit throttle Ming Lei
2022-01-11 11:55 ` [RFC PATCH 1/7] block: move submit_bio_checks() into submit_bio_noacct Ming Lei
2022-01-17  8:20   ` Christoph Hellwig
2022-01-11 11:55 ` [RFC PATCH 2/7] block: move blk_crypto_bio_prep() out of blk-mq.c Ming Lei
2022-01-11 11:55 ` [RFC PATCH 3/7] block: allow to bypass bio check before submitting bio Ming Lei
2022-01-17  8:21   ` Christoph Hellwig
2022-02-09  8:12     ` Ming Lei [this message]
2022-02-09  8:16       ` Christoph Hellwig
2022-02-09  8:35         ` Ming Lei
2022-01-11 11:55 ` [RFC PATCH 4/7] block: don't check bio in blk_throtl_dispatch_work_fn Ming Lei
2022-01-11 11:55 ` [RFC PATCH 5/7] block: throttle split bio in case of iops limit Ming Lei
2022-01-11 11:55 ` [RFC PATCH 6/7] block: don't try to throttle split bio if iops limit isn't set Ming Lei
2022-01-11 11:55 ` [RFC PATCH 7/7] block: revert 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for large IO scenarios") Ming Lei
     [not found] ` <4666c796.5083.17e4d67bb88.Coremail.lining2020x@163.com>
     [not found]   ` <d7c6f47.2d01.17e51b058cc.Coremail.lining2020x@163.com>
2022-01-17  7:46     ` [RFC PATCH 0/7] block: improve iops limit throttle 163

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgN3e98Px8F5w3q/@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=brookxu@tencent.com \
    --cc=hch@infradead.org \
    --cc=lining2020x@163.com \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.