* [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description
@ 2022-01-11 13:39 Martin Kepplinger
2022-01-11 13:39 ` [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description Martin Kepplinger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Martin Kepplinger @ 2022-01-11 13:39 UTC (permalink / raw)
To: laurent.pinchart, mchehab, robh, sakari.ailus, geert
Cc: linux-media, devicetree, linux-kernel, Martin Kepplinger
This is supposed to fix "make dt_binding_check":
Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
camera@20: port:endpoint: Unevaluated properties are not allowed
('link-frequencies', 'data-lanes' were unexpected)
From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
revision history
----------------
v2: thank you, Laurent
* add unevaluatedProperties: false
v1:
https://lore.kernel.org/linux-media/20220110123804.377944-1-martin.kepplinger@puri.sm/
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 85a8877c2f38..5d0fc18a2ea2 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -49,7 +49,8 @@ properties:
description: Definition of the regulator used for the VDDD power supply.
port:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
properties:
endpoint:
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description
2022-01-11 13:39 [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Martin Kepplinger
@ 2022-01-11 13:39 ` Martin Kepplinger
2022-01-22 0:39 ` Rob Herring
2022-01-11 14:07 ` [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Laurent Pinchart
2022-01-22 0:38 ` Rob Herring
2 siblings, 1 reply; 5+ messages in thread
From: Martin Kepplinger @ 2022-01-11 13:39 UTC (permalink / raw)
To: laurent.pinchart, mchehab, robh, sakari.ailus, geert
Cc: linux-media, devicetree, linux-kernel, Martin Kepplinger
link-frequencies is required but only mentioned in the example. Add
it to the description.
Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 5d0fc18a2ea2..1e2df8cf2937 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -69,8 +69,11 @@ properties:
- const: 1
- const: 2
+ link-frequencies: true
+
required:
- data-lanes
+ - link-frequencies
required:
- compatible
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description
2022-01-11 13:39 [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Martin Kepplinger
2022-01-11 13:39 ` [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description Martin Kepplinger
@ 2022-01-11 14:07 ` Laurent Pinchart
2022-01-22 0:38 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2022-01-11 14:07 UTC (permalink / raw)
To: Martin Kepplinger
Cc: mchehab, robh, sakari.ailus, geert, linux-media, devicetree,
linux-kernel
Hi Martin,
Thank you for the patch.
On Tue, Jan 11, 2022 at 02:39:36PM +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
Maybe s/is supposed to fix/fixes/ ? :-) No need to post a new version
just for that, I think it can be changed when applying the patch. Sakari
?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
> From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>
>
> revision history
> ----------------
> v2: thank you, Laurent
> * add unevaluatedProperties: false
> v1:
> https://lore.kernel.org/linux-media/20220110123804.377944-1-martin.kepplinger@puri.sm/
>
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 85a8877c2f38..5d0fc18a2ea2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -49,7 +49,8 @@ properties:
> description: Definition of the regulator used for the VDDD power supply.
>
> port:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
>
> properties:
> endpoint:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description
2022-01-11 13:39 [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Martin Kepplinger
2022-01-11 13:39 ` [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description Martin Kepplinger
2022-01-11 14:07 ` [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Laurent Pinchart
@ 2022-01-22 0:38 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-01-22 0:38 UTC (permalink / raw)
To: Martin Kepplinger
Cc: devicetree, sakari.ailus, geert, mchehab, laurent.pinchart,
linux-kernel, linux-media
On Tue, 11 Jan 2022 14:39:36 +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
> From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>
>
> revision history
> ----------------
> v2: thank you, Laurent
> * add unevaluatedProperties: false
> v1:
> https://lore.kernel.org/linux-media/20220110123804.377944-1-martin.kepplinger@puri.sm/
>
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description
2022-01-11 13:39 ` [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description Martin Kepplinger
@ 2022-01-22 0:39 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-01-22 0:39 UTC (permalink / raw)
To: Martin Kepplinger
Cc: devicetree, linux-kernel, geert, mchehab, linux-media,
laurent.pinchart, sakari.ailus
On Tue, 11 Jan 2022 14:39:37 +0100, Martin Kepplinger wrote:
> link-frequencies is required but only mentioned in the example. Add
> it to the description.
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-22 0:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 13:39 [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Martin Kepplinger
2022-01-11 13:39 ` [PATCH v2 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description Martin Kepplinger
2022-01-22 0:39 ` Rob Herring
2022-01-11 14:07 ` [PATCH v2 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description Laurent Pinchart
2022-01-22 0:38 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.