* [PATCH] nbd/server.c: Remove unused field
@ 2022-01-11 19:43 Nir Soffer
2022-01-11 20:17 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Nir Soffer @ 2022-01-11 19:43 UTC (permalink / raw)
To: qemu-devel
Cc: Nir Soffer, Vladimir Sementsov-Ogievskiy, Eric Blake, qemu-block
NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
this field exists since the first git commit and was never used.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
---
nbd/server.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index 3927f7789d..ce5b2a1d02 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -70,21 +70,20 @@ static int system_errno_to_nbd_errno(int err)
default:
return NBD_EINVAL;
}
}
/* Definitions for opaque data types */
typedef struct NBDRequestData NBDRequestData;
struct NBDRequestData {
- QSIMPLEQ_ENTRY(NBDRequestData) entry;
NBDClient *client;
uint8_t *data;
bool complete;
};
struct NBDExport {
BlockExport common;
char *name;
char *description;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nbd/server.c: Remove unused field
2022-01-11 19:43 [PATCH] nbd/server.c: Remove unused field Nir Soffer
@ 2022-01-11 20:17 ` Philippe Mathieu-Daudé
2022-01-12 14:55 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-11 20:17 UTC (permalink / raw)
To: Nir Soffer, qemu-devel
Cc: Vladimir Sementsov-Ogievskiy, Eric Blake, qemu-block
On 1/11/22 20:43, Nir Soffer wrote:
> NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
> this field exists since the first git commit and was never used.
>
> Signed-off-by: Nir Soffer <nsoffer@redhat.com>
> ---
> nbd/server.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nbd/server.c: Remove unused field
2022-01-11 20:17 ` Philippe Mathieu-Daudé
@ 2022-01-12 14:55 ` Eric Blake
0 siblings, 0 replies; 3+ messages in thread
From: Eric Blake @ 2022-01-12 14:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Nir Soffer, Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
On Tue, Jan 11, 2022 at 09:17:43PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/11/22 20:43, Nir Soffer wrote:
> > NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
s/filed/field/
> > this field exists since the first git commit and was never used.
If my git sleuthing is right, that's commit d9a73806, from 2011.
> >
> > Signed-off-by: Nir Soffer <nsoffer@redhat.com>
> > ---
> > nbd/server.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thanks, I'll add that to my NBD queue.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-12 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 19:43 [PATCH] nbd/server.c: Remove unused field Nir Soffer
2022-01-11 20:17 ` Philippe Mathieu-Daudé
2022-01-12 14:55 ` Eric Blake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.