* [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting
@ 2022-01-12 11:24 Joachim Wiberg
2022-01-12 12:36 ` Scott Wood
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Joachim Wiberg @ 2022-01-12 11:24 UTC (permalink / raw)
To: linuxppc-dev, Scott Wood, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras
Cc: Joachim Wiberg, Tobias Waldekranz
From: Tobias Waldekranz <tobias@waldekranz.com>
This means an idle guest won't needlessly consume an entire core on
the host, waiting for work to show up.
Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
---
arch/powerpc/platforms/85xx/qemu_e500.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/85xx/qemu_e500.c b/arch/powerpc/platforms/85xx/qemu_e500.c
index a4127b0b161f..4c4d577effd9 100644
--- a/arch/powerpc/platforms/85xx/qemu_e500.c
+++ b/arch/powerpc/platforms/85xx/qemu_e500.c
@@ -67,4 +67,9 @@ define_machine(qemu_e500) {
.get_irq = mpic_get_coreint_irq,
.calibrate_decr = generic_calibrate_decr,
.progress = udbg_progress,
+#ifdef CONFIG_PPC64
+ .power_save = book3e_idle,
+#else
+ .power_save = e500_idle,
+#endif
};
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting
2022-01-12 11:24 [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting Joachim Wiberg
@ 2022-01-12 12:36 ` Scott Wood
2022-01-14 10:32 ` Joachim Wiberg
2022-01-14 17:49 ` Scott Wood
2022-02-15 5:26 ` Michael Ellerman
2 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2022-01-12 12:36 UTC (permalink / raw)
To: Joachim Wiberg, linuxppc-dev, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras
Cc: Tobias Waldekranz
On Wed, 2022-01-12 at 12:24 +0100, Joachim Wiberg wrote:
> From: Tobias Waldekranz <tobias@waldekranz.com>
>
> This means an idle guest won't needlessly consume an entire core on
> the host, waiting for work to show up.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
> arch/powerpc/platforms/85xx/qemu_e500.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/powerpc/platforms/85xx/qemu_e500.c
> b/arch/powerpc/platforms/85xx/qemu_e500.c
> index a4127b0b161f..4c4d577effd9 100644
> --- a/arch/powerpc/platforms/85xx/qemu_e500.c
> +++ b/arch/powerpc/platforms/85xx/qemu_e500.c
> @@ -67,4 +67,9 @@ define_machine(qemu_e500) {
> .get_irq = mpic_get_coreint_irq,
> .calibrate_decr = generic_calibrate_decr,
> .progress = udbg_progress,
> +#ifdef CONFIG_PPC64
> + .power_save = book3e_idle,
> +#else
> + .power_save = e500_idle,
> +#endif
> };
In the 32-bit case shouldn't this already be getting added by
setup_power_save()? Though I see corenet_generic.c doing the same thing...
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting
2022-01-12 12:36 ` Scott Wood
@ 2022-01-14 10:32 ` Joachim Wiberg
0 siblings, 0 replies; 5+ messages in thread
From: Joachim Wiberg @ 2022-01-14 10:32 UTC (permalink / raw)
To: Scott Wood, linuxppc-dev, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras
Cc: Tobias Waldekranz
On Wed, Jan 12, 2022 at 06:36, Scott Wood <oss@buserror.net> wrote:
> On Wed, 2022-01-12 at 12:24 +0100, Joachim Wiberg wrote:
>> [snip]
>> +#ifdef CONFIG_PPC64
>> + .power_save = book3e_idle,
>> +#else
>> + .power_save = e500_idle,
>> +#endif
>> };
> In the 32-bit case shouldn't this already be getting added by
> setup_power_save()? Though I see corenet_generic.c doing the same thing...
We went for consistency with the corenet_generic.c setup, which as you
noted does the same thing.
Best regards
/Joachim
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting
2022-01-12 11:24 [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting Joachim Wiberg
2022-01-12 12:36 ` Scott Wood
@ 2022-01-14 17:49 ` Scott Wood
2022-02-15 5:26 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Scott Wood @ 2022-01-14 17:49 UTC (permalink / raw)
To: Joachim Wiberg, linuxppc-dev, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras
Cc: Tobias Waldekranz
On Wed, 2022-01-12 at 12:24 +0100, Joachim Wiberg wrote:
> From: Tobias Waldekranz <tobias@waldekranz.com>
>
> This means an idle guest won't needlessly consume an entire core on
> the host, waiting for work to show up.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
> arch/powerpc/platforms/85xx/qemu_e500.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/powerpc/platforms/85xx/qemu_e500.c
> b/arch/powerpc/platforms/85xx/qemu_e500.c
> index a4127b0b161f..4c4d577effd9 100644
> --- a/arch/powerpc/platforms/85xx/qemu_e500.c
> +++ b/arch/powerpc/platforms/85xx/qemu_e500.c
> @@ -67,4 +67,9 @@ define_machine(qemu_e500) {
> .get_irq = mpic_get_coreint_irq,
> .calibrate_decr = generic_calibrate_decr,
> .progress = udbg_progress,
> +#ifdef CONFIG_PPC64
> + .power_save = book3e_idle,
> +#else
> + .power_save = e500_idle,
> +#endif
> };
Acked-by: Scott Wood <oss@buserror.net>
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting
2022-01-12 11:24 [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting Joachim Wiberg
2022-01-12 12:36 ` Scott Wood
2022-01-14 17:49 ` Scott Wood
@ 2022-02-15 5:26 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2022-02-15 5:26 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Scott Wood, linuxppc-dev,
Michael Ellerman, Paul Mackerras, Joachim Wiberg
Cc: Tobias Waldekranz
On Wed, 12 Jan 2022 12:24:59 +0100, Joachim Wiberg wrote:
> From: Tobias Waldekranz <tobias@waldekranz.com>
>
> This means an idle guest won't needlessly consume an entire core on
> the host, waiting for work to show up.
>
>
Applied to powerpc/next.
[1/1] powerpc/e500/qemu-e500: allow core to idle without waiting
https://git.kernel.org/powerpc/c/f529edd1b69ddf832c3257dcd34e15100038d6b7
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-15 5:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 11:24 [PATCH 1/1] powerpc/e500/qemu-e500: allow core to idle without waiting Joachim Wiberg
2022-01-12 12:36 ` Scott Wood
2022-01-14 10:32 ` Joachim Wiberg
2022-01-14 17:49 ` Scott Wood
2022-02-15 5:26 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.