* [PATCH] drm/msm: Fix wrong size calculation
@ 2022-01-12 12:33 ` Xianting Tian
0 siblings, 0 replies; 4+ messages in thread
From: Xianting Tian @ 2022-01-12 12:33 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel, sumit.semwal, christian.koenig
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, linux-media,
linaro-mm-sig, Xianting Tian
For example, memory-region in .dts as below,
reg = <0x0 0x50000000 0x0 0x20000000>
We can get below values,
struct resource r;
r.start = 0x50000000;
r.end = 0x6fffffff;
So the size should be:
size = r.end - r.start + 1 = 0x20000000
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
drivers/gpu/drm/msm/msm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 892c04365..f04a2337d 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -466,7 +466,7 @@ static int msm_init_vram(struct drm_device *dev)
of_node_put(node);
if (ret)
return ret;
- size = r.end - r.start;
+ size = r.end - r.start + 1;
DRM_INFO("using VRAM carveout: %lx@%pa\n", size, &r.start);
/* if we have no IOMMU, then we need to use carveout allocator.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/msm: Fix wrong size calculation
@ 2022-01-12 12:33 ` Xianting Tian
0 siblings, 0 replies; 4+ messages in thread
From: Xianting Tian @ 2022-01-12 12:33 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel, sumit.semwal, christian.koenig
Cc: Xianting Tian, linux-arm-msm, linux-kernel, dri-devel,
linaro-mm-sig, freedreno, linux-media
For example, memory-region in .dts as below,
reg = <0x0 0x50000000 0x0 0x20000000>
We can get below values,
struct resource r;
r.start = 0x50000000;
r.end = 0x6fffffff;
So the size should be:
size = r.end - r.start + 1 = 0x20000000
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
drivers/gpu/drm/msm/msm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 892c04365..f04a2337d 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -466,7 +466,7 @@ static int msm_init_vram(struct drm_device *dev)
of_node_put(node);
if (ret)
return ret;
- size = r.end - r.start;
+ size = r.end - r.start + 1;
DRM_INFO("using VRAM carveout: %lx@%pa\n", size, &r.start);
/* if we have no IOMMU, then we need to use carveout allocator.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: Fix wrong size calculation
2022-01-12 12:33 ` Xianting Tian
@ 2022-01-25 2:06 ` Dmitry Baryshkov
-1 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-01-25 2:06 UTC (permalink / raw)
To: Xianting Tian, robdclark, sean, airlied, daniel, sumit.semwal,
christian.koenig
Cc: linux-arm-msm, linux-kernel, dri-devel, linaro-mm-sig, freedreno,
linux-media
On 12/01/2022 15:33, Xianting Tian wrote:
> For example, memory-region in .dts as below,
> reg = <0x0 0x50000000 0x0 0x20000000>
>
> We can get below values,
> struct resource r;
> r.start = 0x50000000;
> r.end = 0x6fffffff;
>
> So the size should be:
> size = r.end - r.start + 1 = 0x20000000
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Fixes: 072f1f9168ed ("drm/msm: add support for "stolen" mem")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 892c04365..f04a2337d 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -466,7 +466,7 @@ static int msm_init_vram(struct drm_device *dev)
> of_node_put(node);
> if (ret)
> return ret;
> - size = r.end - r.start;
> + size = r.end - r.start + 1;
> DRM_INFO("using VRAM carveout: %lx@%pa\n", size, &r.start);
>
> /* if we have no IOMMU, then we need to use carveout allocator.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: Fix wrong size calculation
@ 2022-01-25 2:06 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-01-25 2:06 UTC (permalink / raw)
To: Xianting Tian, robdclark, sean, airlied, daniel, sumit.semwal,
christian.koenig
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, linux-media,
linaro-mm-sig
On 12/01/2022 15:33, Xianting Tian wrote:
> For example, memory-region in .dts as below,
> reg = <0x0 0x50000000 0x0 0x20000000>
>
> We can get below values,
> struct resource r;
> r.start = 0x50000000;
> r.end = 0x6fffffff;
>
> So the size should be:
> size = r.end - r.start + 1 = 0x20000000
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Fixes: 072f1f9168ed ("drm/msm: add support for "stolen" mem")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 892c04365..f04a2337d 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -466,7 +466,7 @@ static int msm_init_vram(struct drm_device *dev)
> of_node_put(node);
> if (ret)
> return ret;
> - size = r.end - r.start;
> + size = r.end - r.start + 1;
> DRM_INFO("using VRAM carveout: %lx@%pa\n", size, &r.start);
>
> /* if we have no IOMMU, then we need to use carveout allocator.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-25 3:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 12:33 [PATCH] drm/msm: Fix wrong size calculation Xianting Tian
2022-01-12 12:33 ` Xianting Tian
2022-01-25 2:06 ` Dmitry Baryshkov
2022-01-25 2:06 ` Dmitry Baryshkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.