* [rmk-arm:zii 126/163] drivers/net/dsa/qca8k.c:1479:1: warning: conflicting types for 'qca8k_mac_config_setup_internal_delay'
@ 2022-01-12 18:32 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-01-12 18:32 UTC (permalink / raw)
To: Russell King (Oracle); +Cc: kbuild-all, linux-kernel
tree: git://git.armlinux.org.uk/~rmk/linux-arm zii
head: 75fbe1376b387397df2fa36fefb21919e1810507
commit: 0f97877cdf828e5a96b14fbb2d9d49600d54dd8e [126/163] net: dsa: qca8k: convert to use phylink_pcs
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220113/202201130250.ZSEVrxvJ-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add rmk-arm git://git.armlinux.org.uk/~rmk/linux-arm
git fetch --no-tags rmk-arm zii
git checkout 0f97877cdf828e5a96b14fbb2d9d49600d54dd8e
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/dsa/qca8k.c: In function 'qca8k_pcs_config':
drivers/net/dsa/qca8k.c:1185:3: error: implicit declaration of function 'qca8k_mac_config_setup_internal_delay' [-Werror=implicit-function-declaration]
1185 | qca8k_mac_config_setup_internal_delay(priv, cpu_port_index, reg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/qca8k.c: At top level:
>> drivers/net/dsa/qca8k.c:1479:1: warning: conflicting types for 'qca8k_mac_config_setup_internal_delay'
1479 | qca8k_mac_config_setup_internal_delay(struct qca8k_priv *priv, int cpu_port_index,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/qca8k.c:1479:1: error: static declaration of 'qca8k_mac_config_setup_internal_delay' follows non-static declaration
drivers/net/dsa/qca8k.c:1185:3: note: previous implicit declaration of 'qca8k_mac_config_setup_internal_delay' was here
1185 | qca8k_mac_config_setup_internal_delay(priv, cpu_port_index, reg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/qca8k_mac_config_setup_internal_delay +1479 drivers/net/dsa/qca8k.c
0f97877cdf828e Russell King (Oracle 2021-11-23 1477)
cef08115846e58 Ansuel Smith 2021-10-14 1478 static void
cef08115846e58 Ansuel Smith 2021-10-14 @1479 qca8k_mac_config_setup_internal_delay(struct qca8k_priv *priv, int cpu_port_index,
cef08115846e58 Ansuel Smith 2021-10-14 1480 u32 reg)
cef08115846e58 Ansuel Smith 2021-10-14 1481 {
cef08115846e58 Ansuel Smith 2021-10-14 1482 u32 delay, val = 0;
cef08115846e58 Ansuel Smith 2021-10-14 1483 int ret;
cef08115846e58 Ansuel Smith 2021-10-14 1484
cef08115846e58 Ansuel Smith 2021-10-14 1485 /* Delay can be declared in 3 different way.
cef08115846e58 Ansuel Smith 2021-10-14 1486 * Mode to rgmii and internal-delay standard binding defined
cef08115846e58 Ansuel Smith 2021-10-14 1487 * rgmii-id or rgmii-tx/rx phy mode set.
cef08115846e58 Ansuel Smith 2021-10-14 1488 * The parse logic set a delay different than 0 only when one
cef08115846e58 Ansuel Smith 2021-10-14 1489 * of the 3 different way is used. In all other case delay is
cef08115846e58 Ansuel Smith 2021-10-14 1490 * not enabled. With ID or TX/RXID delay is enabled and set
cef08115846e58 Ansuel Smith 2021-10-14 1491 * to the default and recommended value.
cef08115846e58 Ansuel Smith 2021-10-14 1492 */
fd0bb28c547f7c Ansuel Smith 2021-10-14 1493 if (priv->ports_config.rgmii_tx_delay[cpu_port_index]) {
fd0bb28c547f7c Ansuel Smith 2021-10-14 1494 delay = priv->ports_config.rgmii_tx_delay[cpu_port_index];
cef08115846e58 Ansuel Smith 2021-10-14 1495
cef08115846e58 Ansuel Smith 2021-10-14 1496 val |= QCA8K_PORT_PAD_RGMII_TX_DELAY(delay) |
cef08115846e58 Ansuel Smith 2021-10-14 1497 QCA8K_PORT_PAD_RGMII_TX_DELAY_EN;
cef08115846e58 Ansuel Smith 2021-10-14 1498 }
cef08115846e58 Ansuel Smith 2021-10-14 1499
fd0bb28c547f7c Ansuel Smith 2021-10-14 1500 if (priv->ports_config.rgmii_rx_delay[cpu_port_index]) {
fd0bb28c547f7c Ansuel Smith 2021-10-14 1501 delay = priv->ports_config.rgmii_rx_delay[cpu_port_index];
cef08115846e58 Ansuel Smith 2021-10-14 1502
cef08115846e58 Ansuel Smith 2021-10-14 1503 val |= QCA8K_PORT_PAD_RGMII_RX_DELAY(delay) |
cef08115846e58 Ansuel Smith 2021-10-14 1504 QCA8K_PORT_PAD_RGMII_RX_DELAY_EN;
cef08115846e58 Ansuel Smith 2021-10-14 1505 }
cef08115846e58 Ansuel Smith 2021-10-14 1506
cef08115846e58 Ansuel Smith 2021-10-14 1507 /* Set RGMII delay based on the selected values */
cef08115846e58 Ansuel Smith 2021-10-14 1508 ret = qca8k_rmw(priv, reg,
cef08115846e58 Ansuel Smith 2021-10-14 1509 QCA8K_PORT_PAD_RGMII_TX_DELAY_MASK |
cef08115846e58 Ansuel Smith 2021-10-14 1510 QCA8K_PORT_PAD_RGMII_RX_DELAY_MASK |
cef08115846e58 Ansuel Smith 2021-10-14 1511 QCA8K_PORT_PAD_RGMII_TX_DELAY_EN |
cef08115846e58 Ansuel Smith 2021-10-14 1512 QCA8K_PORT_PAD_RGMII_RX_DELAY_EN,
cef08115846e58 Ansuel Smith 2021-10-14 1513 val);
cef08115846e58 Ansuel Smith 2021-10-14 1514 if (ret)
cef08115846e58 Ansuel Smith 2021-10-14 1515 dev_err(priv->dev, "Failed to set internal delay for CPU port%d",
cef08115846e58 Ansuel Smith 2021-10-14 1516 cpu_port_index == QCA8K_CPU_PORT0 ? 0 : 6);
cef08115846e58 Ansuel Smith 2021-10-14 1517 }
cef08115846e58 Ansuel Smith 2021-10-14 1518
:::::: The code at line 1479 was first introduced by commit
:::::: cef08115846e581f80ff99abf7bf218da1840616 net: dsa: qca8k: set internal delay also for sgmii
:::::: TO: Ansuel Smith <ansuelsmth@gmail.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* [rmk-arm:zii 126/163] drivers/net/dsa/qca8k.c:1479:1: warning: conflicting types for 'qca8k_mac_config_setup_internal_delay'
@ 2022-01-12 18:32 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-01-12 18:32 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6115 bytes --]
tree: git://git.armlinux.org.uk/~rmk/linux-arm zii
head: 75fbe1376b387397df2fa36fefb21919e1810507
commit: 0f97877cdf828e5a96b14fbb2d9d49600d54dd8e [126/163] net: dsa: qca8k: convert to use phylink_pcs
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220113/202201130250.ZSEVrxvJ-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add rmk-arm git://git.armlinux.org.uk/~rmk/linux-arm
git fetch --no-tags rmk-arm zii
git checkout 0f97877cdf828e5a96b14fbb2d9d49600d54dd8e
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/dsa/qca8k.c: In function 'qca8k_pcs_config':
drivers/net/dsa/qca8k.c:1185:3: error: implicit declaration of function 'qca8k_mac_config_setup_internal_delay' [-Werror=implicit-function-declaration]
1185 | qca8k_mac_config_setup_internal_delay(priv, cpu_port_index, reg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/qca8k.c: At top level:
>> drivers/net/dsa/qca8k.c:1479:1: warning: conflicting types for 'qca8k_mac_config_setup_internal_delay'
1479 | qca8k_mac_config_setup_internal_delay(struct qca8k_priv *priv, int cpu_port_index,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/qca8k.c:1479:1: error: static declaration of 'qca8k_mac_config_setup_internal_delay' follows non-static declaration
drivers/net/dsa/qca8k.c:1185:3: note: previous implicit declaration of 'qca8k_mac_config_setup_internal_delay' was here
1185 | qca8k_mac_config_setup_internal_delay(priv, cpu_port_index, reg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/qca8k_mac_config_setup_internal_delay +1479 drivers/net/dsa/qca8k.c
0f97877cdf828e Russell King (Oracle 2021-11-23 1477)
cef08115846e58 Ansuel Smith 2021-10-14 1478 static void
cef08115846e58 Ansuel Smith 2021-10-14 @1479 qca8k_mac_config_setup_internal_delay(struct qca8k_priv *priv, int cpu_port_index,
cef08115846e58 Ansuel Smith 2021-10-14 1480 u32 reg)
cef08115846e58 Ansuel Smith 2021-10-14 1481 {
cef08115846e58 Ansuel Smith 2021-10-14 1482 u32 delay, val = 0;
cef08115846e58 Ansuel Smith 2021-10-14 1483 int ret;
cef08115846e58 Ansuel Smith 2021-10-14 1484
cef08115846e58 Ansuel Smith 2021-10-14 1485 /* Delay can be declared in 3 different way.
cef08115846e58 Ansuel Smith 2021-10-14 1486 * Mode to rgmii and internal-delay standard binding defined
cef08115846e58 Ansuel Smith 2021-10-14 1487 * rgmii-id or rgmii-tx/rx phy mode set.
cef08115846e58 Ansuel Smith 2021-10-14 1488 * The parse logic set a delay different than 0 only when one
cef08115846e58 Ansuel Smith 2021-10-14 1489 * of the 3 different way is used. In all other case delay is
cef08115846e58 Ansuel Smith 2021-10-14 1490 * not enabled. With ID or TX/RXID delay is enabled and set
cef08115846e58 Ansuel Smith 2021-10-14 1491 * to the default and recommended value.
cef08115846e58 Ansuel Smith 2021-10-14 1492 */
fd0bb28c547f7c Ansuel Smith 2021-10-14 1493 if (priv->ports_config.rgmii_tx_delay[cpu_port_index]) {
fd0bb28c547f7c Ansuel Smith 2021-10-14 1494 delay = priv->ports_config.rgmii_tx_delay[cpu_port_index];
cef08115846e58 Ansuel Smith 2021-10-14 1495
cef08115846e58 Ansuel Smith 2021-10-14 1496 val |= QCA8K_PORT_PAD_RGMII_TX_DELAY(delay) |
cef08115846e58 Ansuel Smith 2021-10-14 1497 QCA8K_PORT_PAD_RGMII_TX_DELAY_EN;
cef08115846e58 Ansuel Smith 2021-10-14 1498 }
cef08115846e58 Ansuel Smith 2021-10-14 1499
fd0bb28c547f7c Ansuel Smith 2021-10-14 1500 if (priv->ports_config.rgmii_rx_delay[cpu_port_index]) {
fd0bb28c547f7c Ansuel Smith 2021-10-14 1501 delay = priv->ports_config.rgmii_rx_delay[cpu_port_index];
cef08115846e58 Ansuel Smith 2021-10-14 1502
cef08115846e58 Ansuel Smith 2021-10-14 1503 val |= QCA8K_PORT_PAD_RGMII_RX_DELAY(delay) |
cef08115846e58 Ansuel Smith 2021-10-14 1504 QCA8K_PORT_PAD_RGMII_RX_DELAY_EN;
cef08115846e58 Ansuel Smith 2021-10-14 1505 }
cef08115846e58 Ansuel Smith 2021-10-14 1506
cef08115846e58 Ansuel Smith 2021-10-14 1507 /* Set RGMII delay based on the selected values */
cef08115846e58 Ansuel Smith 2021-10-14 1508 ret = qca8k_rmw(priv, reg,
cef08115846e58 Ansuel Smith 2021-10-14 1509 QCA8K_PORT_PAD_RGMII_TX_DELAY_MASK |
cef08115846e58 Ansuel Smith 2021-10-14 1510 QCA8K_PORT_PAD_RGMII_RX_DELAY_MASK |
cef08115846e58 Ansuel Smith 2021-10-14 1511 QCA8K_PORT_PAD_RGMII_TX_DELAY_EN |
cef08115846e58 Ansuel Smith 2021-10-14 1512 QCA8K_PORT_PAD_RGMII_RX_DELAY_EN,
cef08115846e58 Ansuel Smith 2021-10-14 1513 val);
cef08115846e58 Ansuel Smith 2021-10-14 1514 if (ret)
cef08115846e58 Ansuel Smith 2021-10-14 1515 dev_err(priv->dev, "Failed to set internal delay for CPU port%d",
cef08115846e58 Ansuel Smith 2021-10-14 1516 cpu_port_index == QCA8K_CPU_PORT0 ? 0 : 6);
cef08115846e58 Ansuel Smith 2021-10-14 1517 }
cef08115846e58 Ansuel Smith 2021-10-14 1518
:::::: The code at line 1479 was first introduced by commit
:::::: cef08115846e581f80ff99abf7bf218da1840616 net: dsa: qca8k: set internal delay also for sgmii
:::::: TO: Ansuel Smith <ansuelsmth@gmail.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-12 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 18:32 [rmk-arm:zii 126/163] drivers/net/dsa/qca8k.c:1479:1: warning: conflicting types for 'qca8k_mac_config_setup_internal_delay' kernel test robot
2022-01-12 18:32 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.