Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files
Date: Thu, 13 Jan 2022 03:34:14 +0800	[thread overview]
Message-ID: <202201130337.jfFCSP6H-lkp@intel.com> (raw)
In-Reply-To: <20220111121552.35679-3-andi.shyti@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 3057 bytes --]

Hi Andi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.16 next-20220112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andi-Shyti/Introduce-multitile-support/20220111-201712
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220113/202201130337.jfFCSP6H-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/67f2b5659689154c03d9cc34cbf167367c4da39e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andi-Shyti/Introduce-multitile-support/20220111-201712
        git checkout 67f2b5659689154c03d9cc34cbf167367c4da39e
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)

vim +/dev_attr_rps_act_freq_mhz +303 drivers/gpu/drm/i915/gt/sysfs_gt_pm.c

   293	
   294	#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
   295		struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
   296		struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)
   297	
   298	#define INTEL_GT_RPS_SYSFS_ATTR_RO(_name)				\
   299			INTEL_GT_RPS_SYSFS_ATTR(_name, 0444, _name##_show, NULL)
   300	#define INTEL_GT_RPS_SYSFS_ATTR_RW(_name)				\
   301			INTEL_GT_RPS_SYSFS_ATTR(_name, 0644, _name##_show, _name##_store)
   302	
 > 303	static INTEL_GT_RPS_SYSFS_ATTR_RO(act_freq_mhz);
 > 304	static INTEL_GT_RPS_SYSFS_ATTR_RO(cur_freq_mhz);
 > 305	static INTEL_GT_RPS_SYSFS_ATTR_RW(boost_freq_mhz);
 > 306	static INTEL_GT_RPS_SYSFS_ATTR_RW(max_freq_mhz);
 > 307	static INTEL_GT_RPS_SYSFS_ATTR_RW(min_freq_mhz);
   308	
   309	static DEVICE_ATTR_RO(vlv_rpe_freq_mhz);
   310	
   311	static ssize_t rps_rp_mhz_show(struct device *dev,
   312				       struct device_attribute *attr,
   313				       char *buff);
   314	
 > 315	static INTEL_GT_RPS_SYSFS_ATTR(RP0_freq_mhz, 0444, rps_rp_mhz_show, NULL);
 > 316	static INTEL_GT_RPS_SYSFS_ATTR(RP1_freq_mhz, 0444, rps_rp_mhz_show, NULL);
 > 317	static INTEL_GT_RPS_SYSFS_ATTR(RPn_freq_mhz, 0444, rps_rp_mhz_show, NULL);
   318	
   319	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org