All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Stimson, Dale B" <dale.b.stimson@intel.com>
Cc: Abdiel Janulgue <abdiel.janulgue@gmail.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
	Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	Andi Shyti <andi@etezian.org>,
	Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Prepare for multiple GTs
Date: Wed, 12 Jan 2022 20:43:48 +0200	[thread overview]
Message-ID: <Yd8hZNZvMwIas0Mb@intel.intel> (raw)
In-Reply-To: <20220111225053.GA60352@dbstims-dev.fm.intel.com>

Hi Dale,

thanks for looking into this patch,

> > +	/*
> > +	 * i915->gt[0] == &i915->gt0
> > +	 */
> > +#define I915_MAX_GT 4
> > +	struct intel_gt *gt[I915_MAX_GT];
> > +
> 
> 
> It would be nice if I915_MAX_GT was defined in a more basic header file so
> that the definition of I915_MAX_GT would be available without the necessity of
> including this heavier file i915_drv.h.  Maybe gt/intel_gt.h would be a good
> place, as that is where macro for_each_gt (a user of I915_MAX_GT) is defined.

I actually see I915_MAX_GT more suited for in drv.h as it is a
description for i915 rather than the GT singularly.

We should see the GT as a standalone elemnt not aware of the
overall properties of the entire GPU.

While for_each_gt() is more an utility from intel_gt.

Personally, I do not even like this define: I think the number
of the GTs should be read during startup and stored in
drm_i915_private or similar, but this is another discussion.

Thank you,
Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Stimson, Dale B" <dale.b.stimson@intel.com>
Cc: Abdiel Janulgue <abdiel.janulgue@gmail.com>,
	Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Prepare for multiple GTs
Date: Wed, 12 Jan 2022 20:43:48 +0200	[thread overview]
Message-ID: <Yd8hZNZvMwIas0Mb@intel.intel> (raw)
In-Reply-To: <20220111225053.GA60352@dbstims-dev.fm.intel.com>

Hi Dale,

thanks for looking into this patch,

> > +	/*
> > +	 * i915->gt[0] == &i915->gt0
> > +	 */
> > +#define I915_MAX_GT 4
> > +	struct intel_gt *gt[I915_MAX_GT];
> > +
> 
> 
> It would be nice if I915_MAX_GT was defined in a more basic header file so
> that the definition of I915_MAX_GT would be available without the necessity of
> including this heavier file i915_drv.h.  Maybe gt/intel_gt.h would be a good
> place, as that is where macro for_each_gt (a user of I915_MAX_GT) is defined.

I actually see I915_MAX_GT more suited for in drv.h as it is a
description for i915 rather than the GT singularly.

We should see the GT as a standalone elemnt not aware of the
overall properties of the entire GPU.

While for_each_gt() is more an utility from intel_gt.

Personally, I do not even like this define: I think the number
of the GTs should be read during startup and stored in
drm_i915_private or similar, but this is another discussion.

Thank you,
Andi

  reply	other threads:[~2022-01-12 18:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 12:15 [PATCH 0/2] Introduce multitile support Andi Shyti
2022-01-11 12:15 ` [Intel-gfx] " Andi Shyti
2022-01-11 12:15 ` [PATCH 1/2] drm/i915: Prepare for multiple GTs Andi Shyti
2022-01-11 12:15   ` [Intel-gfx] " Andi Shyti
2022-01-11 22:50   ` Stimson, Dale B
2022-01-11 22:50     ` [Intel-gfx] " Stimson, Dale B
2022-01-12 18:43     ` Andi Shyti [this message]
2022-01-12 18:43       ` Andi Shyti
2022-01-11 12:15 ` [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files Andi Shyti
2022-01-11 12:15   ` [Intel-gfx] " Andi Shyti
2022-01-12 17:10   ` Sundaresan, Sujaritha
2022-01-12 17:10     ` [Intel-gfx] " Sundaresan, Sujaritha
2022-01-12 18:46     ` Andi Shyti
2022-01-12 18:46       ` [Intel-gfx] " Andi Shyti
2022-01-12 19:34   ` kernel test robot
2022-01-11 15:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support Patchwork
2022-01-11 15:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-11 15:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-11 21:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd8hZNZvMwIas0Mb@intel.intel \
    --to=andi.shyti@linux.intel.com \
    --cc=abdiel.janulgue@gmail.com \
    --cc=andi@etezian.org \
    --cc=dale.b.stimson@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=sujaritha.sundaresan@intel.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.