From: John.C.Harrison@Intel.com To: IGT-Dev@Lists.FreeDesktop.Org Cc: Intel-GFX@Lists.FreeDesktop.Org Subject: [Intel-gfx] [PATCH v5 i-g-t 14/15] tests/i915/i915_hangman: Configure engine properties for quicker hangs Date: Fri, 14 Jan 2022 10:17:12 -0800 [thread overview] Message-ID: <20220114181713.1798514-15-John.C.Harrison@Intel.com> (raw) In-Reply-To: <20220114181713.1798514-1-John.C.Harrison@Intel.com> From: John Harrison <John.C.Harrison@Intel.com> Some platforms have very long timeouts configured for some engines. Some have them disabled completely. That makes for a very slow (or broken) hangman test. So explicitly configure the engines to have reasonable settings first. Signed-off-by: John Harrison <John.C.Harrison@Intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> --- tests/i915/i915_hangman.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c index e661b8ad0..23055c271 100644 --- a/tests/i915/i915_hangman.c +++ b/tests/i915/i915_hangman.c @@ -496,8 +496,12 @@ igt_main { const intel_ctx_t *ctx; igt_hang_t hang = {}; + struct gem_engine_properties saved_params[GEM_MAX_ENGINES]; + int num_engines = 0; igt_fixture { + const struct intel_execution_engine2 *e; + device = drm_open_driver(DRIVER_INTEL); igt_require_gem(device); @@ -511,6 +515,13 @@ igt_main igt_require(has_error_state(sysfs)); gem_require_mmap_device_coherent(device); + + for_each_physical_engine(device, e) { + saved_params[num_engines].engine = e; + saved_params[num_engines].preempt_timeout = 500; + saved_params[num_engines].heartbeat_interval = 1000; + gem_engine_properties_configure(device, saved_params + num_engines++); + } } igt_describe("Basic error capture"); @@ -542,6 +553,11 @@ igt_main do_tests("engine", "engine", ctx); igt_fixture { + int i; + + for (i = 0; i < num_engines; i++) + gem_engine_properties_restore(device, saved_params + i); + igt_disallow_hang(device, hang); intel_ctx_destroy(device, ctx); close(device); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: John.C.Harrison@Intel.com To: IGT-Dev@Lists.FreeDesktop.Org Cc: Intel-GFX@Lists.FreeDesktop.Org Subject: [igt-dev] [PATCH v5 i-g-t 14/15] tests/i915/i915_hangman: Configure engine properties for quicker hangs Date: Fri, 14 Jan 2022 10:17:12 -0800 [thread overview] Message-ID: <20220114181713.1798514-15-John.C.Harrison@Intel.com> (raw) In-Reply-To: <20220114181713.1798514-1-John.C.Harrison@Intel.com> From: John Harrison <John.C.Harrison@Intel.com> Some platforms have very long timeouts configured for some engines. Some have them disabled completely. That makes for a very slow (or broken) hangman test. So explicitly configure the engines to have reasonable settings first. Signed-off-by: John Harrison <John.C.Harrison@Intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> --- tests/i915/i915_hangman.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c index e661b8ad0..23055c271 100644 --- a/tests/i915/i915_hangman.c +++ b/tests/i915/i915_hangman.c @@ -496,8 +496,12 @@ igt_main { const intel_ctx_t *ctx; igt_hang_t hang = {}; + struct gem_engine_properties saved_params[GEM_MAX_ENGINES]; + int num_engines = 0; igt_fixture { + const struct intel_execution_engine2 *e; + device = drm_open_driver(DRIVER_INTEL); igt_require_gem(device); @@ -511,6 +515,13 @@ igt_main igt_require(has_error_state(sysfs)); gem_require_mmap_device_coherent(device); + + for_each_physical_engine(device, e) { + saved_params[num_engines].engine = e; + saved_params[num_engines].preempt_timeout = 500; + saved_params[num_engines].heartbeat_interval = 1000; + gem_engine_properties_configure(device, saved_params + num_engines++); + } } igt_describe("Basic error capture"); @@ -542,6 +553,11 @@ igt_main do_tests("engine", "engine", ctx); igt_fixture { + int i; + + for (i = 0; i < num_engines; i++) + gem_engine_properties_restore(device, saved_params + i); + igt_disallow_hang(device, hang); intel_ctx_destroy(device, ctx); close(device); -- 2.25.1
next prev parent reply other threads:[~2022-01-14 18:17 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-14 18:16 [Intel-gfx] [PATCH v5 i-g-t 00/15] Fixes for i915_hangman, gem_exec_capture and gem_exec_fence John.C.Harrison 2022-01-14 18:16 ` [igt-dev] " John.C.Harrison 2022-01-14 18:16 ` [Intel-gfx] [PATCH v5 i-g-t 01/15] tests/i915/i915_hangman: Add descriptions John.C.Harrison 2022-01-14 18:16 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 02/15] lib/hang: Fix igt_require_hang_ring to work with all engines John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 03/15] tests/i915/i915_hangman: Update capture test to use engine structure John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 04/15] tests/i915/i915_hangman: Explicitly test per engine reset vs full GPU reset John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 05/15] tests/i915/i915_hangman: Add uevent test & fix detector John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 06/15] tests/i915/i915_hangman: Use the correct context in hangcheck_unterminated John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 07/15] lib/store: Refactor common store code into helper function John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 08/15] tests/i915/i915_hangman: Add alive-ness test after error capture John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 09/15] tests/i915/i915_hangman: Remove reliance on context persistance John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 10/15] tests/i915/i915_hangman: Run background task on all engines John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 11/15] tests/i915/i915_hangman: Don't let background contexts cause a ban John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 12/15] tests/i915/gem_exec_fence: Configure correct context John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 13/15] lib/i915: Add helper for non-destructive engine property updates John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 18:17 ` John.C.Harrison [this message] 2022-01-14 18:17 ` [igt-dev] [PATCH v5 i-g-t 14/15] tests/i915/i915_hangman: Configure engine properties for quicker hangs John.C.Harrison 2022-01-14 18:17 ` [Intel-gfx] [PATCH v5 i-g-t 15/15] tests/i915/gem_exec_capture: Restore engines John.C.Harrison 2022-01-14 18:17 ` [igt-dev] " John.C.Harrison 2022-01-14 19:12 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes for i915_hangman, gem_exec_capture and gem_exec_fence Patchwork 2022-01-17 12:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220114181713.1798514-15-John.C.Harrison@Intel.com \ --to=john.c.harrison@intel.com \ --cc=IGT-Dev@Lists.FreeDesktop.Org \ --cc=Intel-GFX@Lists.FreeDesktop.Org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.