Re: Procedure for the send review on u-boot patch

From: Zev Weiss <zweiss@equinix.com>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	"velumanit@hcl.com" <velumanit@hcl.com>,
	logananth hcl <logananth13.hcl@gmail.com>
Subject: Re: Procedure for the send review on u-boot patch
Date: Fri, 14 Jan 2022 22:02:40 +0000	[thread overview]
Message-ID: <20220114220239.GH5754@packtop> (raw)
In-Reply-To: <YeHE3qPWS0LpmLIb@heinlein>

On Fri, Jan 14, 2022 at 10:45:50AM PST, Patrick Williams wrote:
>On Thu, Jan 13, 2022 at 10:40:40PM +0000, Joel Stanley wrote:
>> Hello,
>>
>> On Thu, 13 Jan 2022 at 08:52, logananth hcl <logananth13.hcl@gmail.com> wrote:
>> >
>> > Hai All,
>> >
>> > In openbmc/u-boot repo(branch - v2016.07-aspeed-openbmc)
>> > https://github.com/openbmc/u-boot/tree/v2016.07-aspeed-openbmc
>> >
>> > I want to send a review on this particular branch in u-boot through upstream.
>> > Is there any specific procedure to upstream it,
>> > kindly provide your suggestions.
>>
>> I strongly recommend using the newer v2019.04 based branch for any new
>> system you're bringing up.
>
>It doesn't seem like anyone is using this branch for any Aspeed system though.
>
>```
>$ git grep "v2019.04"
>meta-aspeed/recipes-bsp/u-boot/u-boot-common-aspeed-sdk_2019.04.inc:PV = "v2019.04+git${SRCPV}"
>```
>
>I think everyone doing AST2400/AST2500 work has been copying from existing
>systems and still pointing to the v2016.07 branch that we have working in the
>tree.
>

I think g200a, fp5280g2, and vegman are all using the new branch?  And
if I'm interpreting the below correctly, also any aspeed-g6 systems that
haven't overridden the defaults?

```
$ git grep 'PREFERRED_PROVIDER.*u-boot-aspeed-sdk'
meta-aspeed/conf/machine/include/aspeed.inc:PREFERRED_PROVIDER_virtual/bootloader:aspeed-g6 ?= "u-boot-aspeed-sdk"
meta-aspeed/conf/machine/include/aspeed.inc:PREFERRED_PROVIDER_u-boot:aspeed-g6 ?= "u-boot-aspeed-sdk"
meta-bytedance/meta-g220a/conf/machine/g220a.conf:PREFERRED_PROVIDER_virtual/bootloader = "u-boot-aspeed-sdk"
meta-bytedance/meta-g220a/conf/machine/g220a.conf:PREFERRED_PROVIDER_u-boot = "u-boot-aspeed-sdk"
meta-inspur/meta-fp5280g2/conf/machine/fp5280g2.conf:PREFERRED_PROVIDER_virtual/bootloader = "u-boot-aspeed-sdk"
meta-inspur/meta-fp5280g2/conf/machine/fp5280g2.conf:PREFERRED_PROVIDER_u-boot = "u-boot-aspeed-sdk"
meta-yadro/meta-vegman/conf/machine/include/vegman.inc:PREFERRED_PROVIDER_virtual/bootloader = "u-boot-aspeed-sdk"
meta-yadro/meta-vegman/conf/machine/include/vegman.inc:PREFERRED_PROVIDER_u-boot = "u-boot-aspeed-sdk"
```

FWIW, I've also got another port in the works (Delta AHE-50DC Open19
powershelf) that I'm hoping to start upstreaming in the next few weeks
that so far seems to be working well on the 2019.04 branch internally.

That said, on some other systems I've experimented with switching to the
newer branch has caused various problems (which I haven't had time to
fully track down & debug).

Zev