From: Joel Stanley <joel@jms.id.au>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
velumanit@hcl.com, logananth hcl <logananth13.hcl@gmail.com>
Subject: Re: Procedure for the send review on u-boot patch
Date: Wed, 19 Jan 2022 03:06:46 +0000 [thread overview]
Message-ID: <CACPK8Xd+TgWx8bv810LBeTO9KYOUR3CsipamEBou+RHYteZz6w@mail.gmail.com> (raw)
In-Reply-To: <Yeb7iXvJSFvWa/NP@heinlein>
On Tue, 18 Jan 2022 at 17:40, Patrick Williams <patrick@stwcx.xyz> wrote:
>
> On Mon, Jan 17, 2022 at 06:54:48AM +0000, Joel Stanley wrote:
> > On Fri, 14 Jan 2022 at 18:45, Patrick Williams <patrick@stwcx.xyz> wrote:
> > > On Thu, Jan 13, 2022 at 10:40:40PM +0000, Joel Stanley wrote:
> > > > I strongly recommend using the newer v2019.04 based branch for any new
> > > > system you're bringing up.
>
> I was under the mistaken assumption that the aspeed-sdk was not hosted and
> maintained by us. In u-boot-common-aspeed-sdk_2019.04.inc I see:
>
> HOMEPAGE = "https://github.com/AspeedTech-BMC/u-boot"
>
> ... but ...
>
> SRC_URI = "git://git@github.com/openbmc/u-boot.git;nobranch=1;protocol=https"
>
> Should we align these to avoid any confusion? I assume we should adjust the
> HOMEPAGE to point at our repository?
The upstream for our branch is that homepage URL. Ideally we would put
all of our patches into the SDK (I often send Aspeed pull requests to
do this), and un-fork the repository.
If you found the homepage URL confusing we could add a note to
explain, and change it. I'll leave it to you.
prev parent reply other threads:[~2022-01-19 3:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 8:52 Procedure for the send review on u-boot patch logananth hcl
2022-01-13 22:40 ` Joel Stanley
2022-01-14 18:45 ` Patrick Williams
2022-01-14 22:02 ` Zev Weiss
2022-01-14 22:21 ` Patrick Williams
2022-01-17 5:36 ` Lei Yu
2022-01-17 6:54 ` Joel Stanley
2022-01-17 12:00 ` Joel Stanley
2022-01-18 17:40 ` Patrick Williams
2022-01-19 3:06 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xd+TgWx8bv810LBeTO9KYOUR3CsipamEBou+RHYteZz6w@mail.gmail.com \
--to=joel@jms.id.au \
--cc=logananth13.hcl@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick@stwcx.xyz \
--cc=velumanit@hcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.