All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ti-sgx-ddk-um: avoid unnecessary dependency on -dev package
@ 2022-01-14 12:52 Matthias Schiffer
  2022-01-14 22:15 ` [meta-ti] " Denys Dmytriyenko
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Schiffer @ 2022-01-14 12:52 UTC (permalink / raw)
  To: meta-ti; +Cc: Michael.Krummsdorf, Matthias Schiffer

ti-sgx-ddk-um's do_install creates a symlink libGLESv2.so.1 to
libGLESv2.so. As this symlink will be installed to ti-sgx-ddk-um, but
its target libGLESv2.so is in ti-sgx-ddk-um-dev, the automated
dependency analysis will add ti-sgx-ddk-um-dev to ti-sgx-ddk-um's
RDEPENDS. This will pull in a large number of other -dev packages
through RDEPENDS and RRECOMMENDS in turn.

Avoid this by having libGLESv2.so.1 point to libGLESv2.so.2 instead of
libGLESv2.so, so the symlink's target is in ti-sgx-ddk-um as well.

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
index 9d55122c..e4243a2b 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -56,7 +56,7 @@ S = "${WORKDIR}/git"
 
 do_install () {
     oe_runmake install DESTDIR=${D} TARGET_PRODUCT=${TARGET_PRODUCT}
-    ln -sf libGLESv2.so ${D}${libdir}/libGLESv2.so.1
+    ln -sf libGLESv2.so.2 ${D}${libdir}/libGLESv2.so.1
 
     chown -R root:root ${D}
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-ti] [PATCH] ti-sgx-ddk-um: avoid unnecessary dependency on -dev package
  2022-01-14 12:52 [PATCH] ti-sgx-ddk-um: avoid unnecessary dependency on -dev package Matthias Schiffer
@ 2022-01-14 22:15 ` Denys Dmytriyenko
  0 siblings, 0 replies; 2+ messages in thread
From: Denys Dmytriyenko @ 2022-01-14 22:15 UTC (permalink / raw)
  To: Matthias Schiffer; +Cc: meta-ti, Michael.Krummsdorf

On Fri, Jan 14, 2022 at 01:52:18PM +0100, Matthias Schiffer wrote:
> ti-sgx-ddk-um's do_install creates a symlink libGLESv2.so.1 to
> libGLESv2.so. As this symlink will be installed to ti-sgx-ddk-um, but
> its target libGLESv2.so is in ti-sgx-ddk-um-dev, the automated
> dependency analysis will add ti-sgx-ddk-um-dev to ti-sgx-ddk-um's
> RDEPENDS. This will pull in a large number of other -dev packages
> through RDEPENDS and RRECOMMENDS in turn.
> 
> Avoid this by having libGLESv2.so.1 point to libGLESv2.so.2 instead of
> libGLESv2.so, so the symlink's target is in ti-sgx-ddk-um as well.

Makes sense, thanks!


> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>


> ---
>  recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index 9d55122c..e4243a2b 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -56,7 +56,7 @@ S = "${WORKDIR}/git"
>  
>  do_install () {
>      oe_runmake install DESTDIR=${D} TARGET_PRODUCT=${TARGET_PRODUCT}
> -    ln -sf libGLESv2.so ${D}${libdir}/libGLESv2.so.1
> +    ln -sf libGLESv2.so.2 ${D}${libdir}/libGLESv2.so.1
>  
>      chown -R root:root ${D}
>  }
> -- 
> 2.25.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-14 22:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 12:52 [PATCH] ti-sgx-ddk-um: avoid unnecessary dependency on -dev package Matthias Schiffer
2022-01-14 22:15 ` [meta-ti] " Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.