* [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-15 9:35 ` Alexander Stein 0 siblings, 0 replies; 20+ messages in thread From: Alexander Stein @ 2022-01-15 9:35 UTC (permalink / raw) To: Jerome Brunet, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: Alexander Stein, devicetree, linux-amlogic Bindings amlogic,axg-fifo.txt mandates that reset-names is a required property. Add it. Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> --- This is essentially a preparation for YAML conversion to fix the warnings. arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index 3f5254eeb47b..b14175e2f1d6 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -1333,6 +1333,7 @@ toddr_a: audio-controller@100 { interrupts = <GIC_SPI 84 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_TODDR_A>; resets = <&arb AXG_ARB_TODDR_A>; + reset-names = "arb"; amlogic,fifo-depth = <512>; status = "disabled"; }; @@ -1345,6 +1346,7 @@ toddr_b: audio-controller@140 { interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_TODDR_B>; resets = <&arb AXG_ARB_TODDR_B>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; @@ -1357,6 +1359,7 @@ toddr_c: audio-controller@180 { interrupts = <GIC_SPI 86 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_TODDR_C>; resets = <&arb AXG_ARB_TODDR_C>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; @@ -1369,6 +1372,7 @@ frddr_a: audio-controller@1c0 { interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; resets = <&arb AXG_ARB_FRDDR_A>; + reset-names = "arb"; amlogic,fifo-depth = <512>; status = "disabled"; }; @@ -1381,6 +1385,7 @@ frddr_b: audio-controller@200 { interrupts = <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_FRDDR_B>; resets = <&arb AXG_ARB_FRDDR_B>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; @@ -1393,6 +1398,7 @@ frddr_c: audio-controller@240 { interrupts = <GIC_SPI 90 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_FRDDR_C>; resets = <&arb AXG_ARB_FRDDR_C>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-15 9:35 ` Alexander Stein 0 siblings, 0 replies; 20+ messages in thread From: Alexander Stein @ 2022-01-15 9:35 UTC (permalink / raw) To: Jerome Brunet, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: Alexander Stein, devicetree, linux-amlogic Bindings amlogic,axg-fifo.txt mandates that reset-names is a required property. Add it. Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> --- This is essentially a preparation for YAML conversion to fix the warnings. arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index 3f5254eeb47b..b14175e2f1d6 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -1333,6 +1333,7 @@ toddr_a: audio-controller@100 { interrupts = <GIC_SPI 84 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_TODDR_A>; resets = <&arb AXG_ARB_TODDR_A>; + reset-names = "arb"; amlogic,fifo-depth = <512>; status = "disabled"; }; @@ -1345,6 +1346,7 @@ toddr_b: audio-controller@140 { interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_TODDR_B>; resets = <&arb AXG_ARB_TODDR_B>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; @@ -1357,6 +1359,7 @@ toddr_c: audio-controller@180 { interrupts = <GIC_SPI 86 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_TODDR_C>; resets = <&arb AXG_ARB_TODDR_C>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; @@ -1369,6 +1372,7 @@ frddr_a: audio-controller@1c0 { interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; resets = <&arb AXG_ARB_FRDDR_A>; + reset-names = "arb"; amlogic,fifo-depth = <512>; status = "disabled"; }; @@ -1381,6 +1385,7 @@ frddr_b: audio-controller@200 { interrupts = <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_FRDDR_B>; resets = <&arb AXG_ARB_FRDDR_B>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; @@ -1393,6 +1398,7 @@ frddr_c: audio-controller@240 { interrupts = <GIC_SPI 90 IRQ_TYPE_EDGE_RISING>; clocks = <&clkc_audio AUD_CLKID_FRDDR_C>; resets = <&arb AXG_ARB_FRDDR_C>; + reset-names = "arb"; amlogic,fifo-depth = <256>; status = "disabled"; }; -- 2.34.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml 2022-01-15 9:35 ` Alexander Stein @ 2022-01-15 9:35 ` Alexander Stein -1 siblings, 0 replies; 20+ messages in thread From: Alexander Stein @ 2022-01-15 9:35 UTC (permalink / raw) To: Jerome Brunet, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: Alexander Stein, devicetree, linux-amlogic Convert Amlogic FIFO controller documentation to yaml format. Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> --- Things to note: First of, Jerome, sorry for adding you as maintainer, but 1) it's mandatory 2) your are the (only) author of amlogic,axg-fifo.txt Please add your Signed-off-by if that is okay with you. License is mandated by checkpath, not my choice. I'm not so sure about the compatible check. Essentially it is either * 'amlogic,axg-frddr' OR * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr' (or 'sm1' instead of 'g12a') Same goes for *-toddr. Is this schema correct in that regard? At least I got no warnings on existing device trees. .../bindings/sound/amlogic,axg-fifo.txt | 34 ------- .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++ 2 files changed, 97 insertions(+), 34 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt deleted file mode 100644 index fa4545ed81ca..000000000000 --- a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt +++ /dev/null @@ -1,34 +0,0 @@ -* Amlogic Audio FIFO controllers - -Required properties: -- compatible: 'amlogic,axg-toddr' or - 'amlogic,axg-toddr' or - 'amlogic,g12a-frddr' or - 'amlogic,g12a-toddr' or - 'amlogic,sm1-frddr' or - 'amlogic,sm1-toddr' -- reg: physical base address of the controller and length of memory - mapped region. -- interrupts: interrupt specifier for the fifo. -- clocks: phandle to the fifo peripheral clock provided by the audio - clock controller. -- resets: list of reset phandle, one for each entry reset-names. -- reset-names: should contain the following: - * "arb" : memory ARB line (required) - * "rst" : dedicated device reset line (optional) -- #sound-dai-cells: must be 0. -- amlogic,fifo-depth: The size of the controller's fifo in bytes. This - is useful for determining certain configuration such - as the flush threshold of the fifo - -Example of FRDDR A on the A113 SoC: - -frddr_a: audio-controller@1c0 { - compatible = "amlogic,axg-frddr"; - reg = <0x0 0x1c0 0x0 0x1c>; - #sound-dai-cells = <0>; - interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; - clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; - resets = <&arb AXG_ARB_FRDDR_A>; - fifo-depth = <512>; -}; diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml new file mode 100644 index 000000000000..54bc073591f4 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/amlogic,axg-fifo.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Audio FIFO controllers + +maintainers: + - Jerome Brunet <jbrunet@baylibre.com> + +allOf: + - $ref: name-prefix.yaml# + +properties: + $nodename: + pattern: "^audio-controller@.*" + + "#sound-dai-cells": + const: 0 + + compatible: + oneOf: + - items: + - enum: + - amlogic,g12a-frddr + - amlogic,sm1-frddr + - const: amlogic,axg-frddr + - const: amlogic,axg-frddr + - items: + - enum: + - amlogic,g12a-toddr + - amlogic,sm1-toddr + - const: amlogic,axg-toddr + - const: amlogic,axg-toddr + + reg: + items: + - description: physical base address of the controller + + interrupts: + items: + - description: FIFO interrupt + + clocks: + items: + - description: FIFO peripheral clock provided by the audio clock controller + + resets: + minItems: 1 + items: + - description: memory ARB line + - description: optional device reset line + + reset-names: + minItems: 1 + items: + - const: arb + - const: rst + + amlogic,fifo-depth: + description: > + The size of the controller's fifo in bytes. This + is useful for determining certain configuration such + as the flush threshold of the fifo + $ref: /schemas/types.yaml#/definitions/uint32 + + sound-name-prefix: true + +required: + - compatible + - reg + - interrupts + - clocks + - resets + - reset-names + - '#sound-dai-cells' + - amlogic,fifo-depth + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/axg-audio-clkc.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/reset/amlogic,meson-axg-audio-arb.h> + + frddr_a: audio-controller@1c0 { + compatible = "amlogic,axg-frddr"; + reg = <0x1c0 0x1c>; + #sound-dai-cells = <0>; + interrupts = <88 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; + resets = <&arb AXG_ARB_FRDDR_A>; + reset-names = "arb"; + amlogic,fifo-depth = <512>; + }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml @ 2022-01-15 9:35 ` Alexander Stein 0 siblings, 0 replies; 20+ messages in thread From: Alexander Stein @ 2022-01-15 9:35 UTC (permalink / raw) To: Jerome Brunet, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: Alexander Stein, devicetree, linux-amlogic Convert Amlogic FIFO controller documentation to yaml format. Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> --- Things to note: First of, Jerome, sorry for adding you as maintainer, but 1) it's mandatory 2) your are the (only) author of amlogic,axg-fifo.txt Please add your Signed-off-by if that is okay with you. License is mandated by checkpath, not my choice. I'm not so sure about the compatible check. Essentially it is either * 'amlogic,axg-frddr' OR * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr' (or 'sm1' instead of 'g12a') Same goes for *-toddr. Is this schema correct in that regard? At least I got no warnings on existing device trees. .../bindings/sound/amlogic,axg-fifo.txt | 34 ------- .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++ 2 files changed, 97 insertions(+), 34 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt deleted file mode 100644 index fa4545ed81ca..000000000000 --- a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt +++ /dev/null @@ -1,34 +0,0 @@ -* Amlogic Audio FIFO controllers - -Required properties: -- compatible: 'amlogic,axg-toddr' or - 'amlogic,axg-toddr' or - 'amlogic,g12a-frddr' or - 'amlogic,g12a-toddr' or - 'amlogic,sm1-frddr' or - 'amlogic,sm1-toddr' -- reg: physical base address of the controller and length of memory - mapped region. -- interrupts: interrupt specifier for the fifo. -- clocks: phandle to the fifo peripheral clock provided by the audio - clock controller. -- resets: list of reset phandle, one for each entry reset-names. -- reset-names: should contain the following: - * "arb" : memory ARB line (required) - * "rst" : dedicated device reset line (optional) -- #sound-dai-cells: must be 0. -- amlogic,fifo-depth: The size of the controller's fifo in bytes. This - is useful for determining certain configuration such - as the flush threshold of the fifo - -Example of FRDDR A on the A113 SoC: - -frddr_a: audio-controller@1c0 { - compatible = "amlogic,axg-frddr"; - reg = <0x0 0x1c0 0x0 0x1c>; - #sound-dai-cells = <0>; - interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; - clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; - resets = <&arb AXG_ARB_FRDDR_A>; - fifo-depth = <512>; -}; diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml new file mode 100644 index 000000000000..54bc073591f4 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/amlogic,axg-fifo.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Audio FIFO controllers + +maintainers: + - Jerome Brunet <jbrunet@baylibre.com> + +allOf: + - $ref: name-prefix.yaml# + +properties: + $nodename: + pattern: "^audio-controller@.*" + + "#sound-dai-cells": + const: 0 + + compatible: + oneOf: + - items: + - enum: + - amlogic,g12a-frddr + - amlogic,sm1-frddr + - const: amlogic,axg-frddr + - const: amlogic,axg-frddr + - items: + - enum: + - amlogic,g12a-toddr + - amlogic,sm1-toddr + - const: amlogic,axg-toddr + - const: amlogic,axg-toddr + + reg: + items: + - description: physical base address of the controller + + interrupts: + items: + - description: FIFO interrupt + + clocks: + items: + - description: FIFO peripheral clock provided by the audio clock controller + + resets: + minItems: 1 + items: + - description: memory ARB line + - description: optional device reset line + + reset-names: + minItems: 1 + items: + - const: arb + - const: rst + + amlogic,fifo-depth: + description: > + The size of the controller's fifo in bytes. This + is useful for determining certain configuration such + as the flush threshold of the fifo + $ref: /schemas/types.yaml#/definitions/uint32 + + sound-name-prefix: true + +required: + - compatible + - reg + - interrupts + - clocks + - resets + - reset-names + - '#sound-dai-cells' + - amlogic,fifo-depth + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/axg-audio-clkc.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/reset/amlogic,meson-axg-audio-arb.h> + + frddr_a: audio-controller@1c0 { + compatible = "amlogic,axg-frddr"; + reg = <0x1c0 0x1c>; + #sound-dai-cells = <0>; + interrupts = <88 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; + resets = <&arb AXG_ARB_FRDDR_A>; + reset-names = "arb"; + amlogic,fifo-depth = <512>; + }; -- 2.34.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml 2022-01-15 9:35 ` Alexander Stein @ 2022-01-15 15:16 ` Jerome Brunet -1 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-15 15:16 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote: > Convert Amlogic FIFO controller documentation to yaml format. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Things to note: > First of, Jerome, sorry for adding you as maintainer, but > 1) it's mandatory > 2) your are the (only) author of amlogic,axg-fifo.txt > > Please add your Signed-off-by if that is okay with you. > > License is mandated by checkpath, not my choice. > > I'm not so sure about the compatible check. Essentially it is either > * 'amlogic,axg-frddr' OR > * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr' > (or 'sm1' instead of 'g12a') > > Same goes for *-toddr. Is this schema correct in that regard? At least I > got no warnings on existing device trees. > There has already been a submission of this. It should answer your questions. You've also missed some constraints regarding resets. Please check: https://patchwork.kernel.org/project/linux-amlogic/list/?series=246453&state=%2A&archive=both > .../bindings/sound/amlogic,axg-fifo.txt | 34 ------- > .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++ > 2 files changed, 97 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > deleted file mode 100644 > index fa4545ed81ca..000000000000 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -* Amlogic Audio FIFO controllers > - > -Required properties: > -- compatible: 'amlogic,axg-toddr' or > - 'amlogic,axg-toddr' or > - 'amlogic,g12a-frddr' or > - 'amlogic,g12a-toddr' or > - 'amlogic,sm1-frddr' or > - 'amlogic,sm1-toddr' > -- reg: physical base address of the controller and length of memory > - mapped region. > -- interrupts: interrupt specifier for the fifo. > -- clocks: phandle to the fifo peripheral clock provided by the audio > - clock controller. > -- resets: list of reset phandle, one for each entry reset-names. > -- reset-names: should contain the following: > - * "arb" : memory ARB line (required) > - * "rst" : dedicated device reset line (optional) > -- #sound-dai-cells: must be 0. > -- amlogic,fifo-depth: The size of the controller's fifo in bytes. This > - is useful for determining certain configuration such > - as the flush threshold of the fifo > - > -Example of FRDDR A on the A113 SoC: > - > -frddr_a: audio-controller@1c0 { > - compatible = "amlogic,axg-frddr"; > - reg = <0x0 0x1c0 0x0 0x1c>; > - #sound-dai-cells = <0>; > - interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; > - clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > - resets = <&arb AXG_ARB_FRDDR_A>; > - fifo-depth = <512>; > -}; > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > new file mode 100644 > index 000000000000..54bc073591f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/amlogic,axg-fifo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Audio FIFO controllers > + > +maintainers: > + - Jerome Brunet <jbrunet@baylibre.com> > + > +allOf: > + - $ref: name-prefix.yaml# > + > +properties: > + $nodename: > + pattern: "^audio-controller@.*" > + > + "#sound-dai-cells": > + const: 0 > + > + compatible: > + oneOf: > + - items: > + - enum: > + - amlogic,g12a-frddr > + - amlogic,sm1-frddr > + - const: amlogic,axg-frddr > + - const: amlogic,axg-frddr > + - items: > + - enum: > + - amlogic,g12a-toddr > + - amlogic,sm1-toddr > + - const: amlogic,axg-toddr > + - const: amlogic,axg-toddr > + > + reg: > + items: > + - description: physical base address of the controller > + > + interrupts: > + items: > + - description: FIFO interrupt > + > + clocks: > + items: > + - description: FIFO peripheral clock provided by the audio clock controller > + > + resets: > + minItems: 1 > + items: > + - description: memory ARB line > + - description: optional device reset line > + > + reset-names: > + minItems: 1 > + items: > + - const: arb > + - const: rst > + > + amlogic,fifo-depth: > + description: > > + The size of the controller's fifo in bytes. This > + is useful for determining certain configuration such > + as the flush threshold of the fifo > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + sound-name-prefix: true > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - resets > + - reset-names > + - '#sound-dai-cells' > + - amlogic,fifo-depth > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/axg-audio-clkc.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/reset/amlogic,meson-axg-audio-arb.h> > + > + frddr_a: audio-controller@1c0 { > + compatible = "amlogic,axg-frddr"; > + reg = <0x1c0 0x1c>; > + #sound-dai-cells = <0>; > + interrupts = <88 IRQ_TYPE_EDGE_RISING>; > + clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > + resets = <&arb AXG_ARB_FRDDR_A>; > + reset-names = "arb"; > + amlogic,fifo-depth = <512>; > + }; ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml @ 2022-01-15 15:16 ` Jerome Brunet 0 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-15 15:16 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote: > Convert Amlogic FIFO controller documentation to yaml format. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Things to note: > First of, Jerome, sorry for adding you as maintainer, but > 1) it's mandatory > 2) your are the (only) author of amlogic,axg-fifo.txt > > Please add your Signed-off-by if that is okay with you. > > License is mandated by checkpath, not my choice. > > I'm not so sure about the compatible check. Essentially it is either > * 'amlogic,axg-frddr' OR > * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr' > (or 'sm1' instead of 'g12a') > > Same goes for *-toddr. Is this schema correct in that regard? At least I > got no warnings on existing device trees. > There has already been a submission of this. It should answer your questions. You've also missed some constraints regarding resets. Please check: https://patchwork.kernel.org/project/linux-amlogic/list/?series=246453&state=%2A&archive=both > .../bindings/sound/amlogic,axg-fifo.txt | 34 ------- > .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++ > 2 files changed, 97 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > deleted file mode 100644 > index fa4545ed81ca..000000000000 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -* Amlogic Audio FIFO controllers > - > -Required properties: > -- compatible: 'amlogic,axg-toddr' or > - 'amlogic,axg-toddr' or > - 'amlogic,g12a-frddr' or > - 'amlogic,g12a-toddr' or > - 'amlogic,sm1-frddr' or > - 'amlogic,sm1-toddr' > -- reg: physical base address of the controller and length of memory > - mapped region. > -- interrupts: interrupt specifier for the fifo. > -- clocks: phandle to the fifo peripheral clock provided by the audio > - clock controller. > -- resets: list of reset phandle, one for each entry reset-names. > -- reset-names: should contain the following: > - * "arb" : memory ARB line (required) > - * "rst" : dedicated device reset line (optional) > -- #sound-dai-cells: must be 0. > -- amlogic,fifo-depth: The size of the controller's fifo in bytes. This > - is useful for determining certain configuration such > - as the flush threshold of the fifo > - > -Example of FRDDR A on the A113 SoC: > - > -frddr_a: audio-controller@1c0 { > - compatible = "amlogic,axg-frddr"; > - reg = <0x0 0x1c0 0x0 0x1c>; > - #sound-dai-cells = <0>; > - interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; > - clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > - resets = <&arb AXG_ARB_FRDDR_A>; > - fifo-depth = <512>; > -}; > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > new file mode 100644 > index 000000000000..54bc073591f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/amlogic,axg-fifo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Audio FIFO controllers > + > +maintainers: > + - Jerome Brunet <jbrunet@baylibre.com> > + > +allOf: > + - $ref: name-prefix.yaml# > + > +properties: > + $nodename: > + pattern: "^audio-controller@.*" > + > + "#sound-dai-cells": > + const: 0 > + > + compatible: > + oneOf: > + - items: > + - enum: > + - amlogic,g12a-frddr > + - amlogic,sm1-frddr > + - const: amlogic,axg-frddr > + - const: amlogic,axg-frddr > + - items: > + - enum: > + - amlogic,g12a-toddr > + - amlogic,sm1-toddr > + - const: amlogic,axg-toddr > + - const: amlogic,axg-toddr > + > + reg: > + items: > + - description: physical base address of the controller > + > + interrupts: > + items: > + - description: FIFO interrupt > + > + clocks: > + items: > + - description: FIFO peripheral clock provided by the audio clock controller > + > + resets: > + minItems: 1 > + items: > + - description: memory ARB line > + - description: optional device reset line > + > + reset-names: > + minItems: 1 > + items: > + - const: arb > + - const: rst > + > + amlogic,fifo-depth: > + description: > > + The size of the controller's fifo in bytes. This > + is useful for determining certain configuration such > + as the flush threshold of the fifo > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + sound-name-prefix: true > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - resets > + - reset-names > + - '#sound-dai-cells' > + - amlogic,fifo-depth > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/axg-audio-clkc.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/reset/amlogic,meson-axg-audio-arb.h> > + > + frddr_a: audio-controller@1c0 { > + compatible = "amlogic,axg-frddr"; > + reg = <0x1c0 0x1c>; > + #sound-dai-cells = <0>; > + interrupts = <88 IRQ_TYPE_EDGE_RISING>; > + clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > + resets = <&arb AXG_ARB_FRDDR_A>; > + reset-names = "arb"; > + amlogic,fifo-depth = <512>; > + }; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml 2022-01-15 9:35 ` Alexander Stein @ 2022-01-15 17:22 ` Rob Herring -1 siblings, 0 replies; 20+ messages in thread From: Rob Herring @ 2022-01-15 17:22 UTC (permalink / raw) To: Alexander Stein Cc: Jerome Brunet, Neil Armstrong, devicetree, Liam Girdwood, Mark Brown, Rob Herring, Kevin Hilman, Martin Blumenstingl, linux-amlogic On Sat, 15 Jan 2022 10:35:57 +0100, Alexander Stein wrote: > Convert Amlogic FIFO controller documentation to yaml format. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Things to note: > First of, Jerome, sorry for adding you as maintainer, but > 1) it's mandatory > 2) your are the (only) author of amlogic,axg-fifo.txt > > Please add your Signed-off-by if that is okay with you. > > License is mandated by checkpath, not my choice. > > I'm not so sure about the compatible check. Essentially it is either > * 'amlogic,axg-frddr' OR > * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr' > (or 'sm1' instead of 'g12a') > > Same goes for *-toddr. Is this schema correct in that regard? At least I > got no warnings on existing device trees. > > .../bindings/sound/amlogic,axg-fifo.txt | 34 ------- > .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++ > 2 files changed, 97 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1580333 audio-controller@100: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@140: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@180: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@1c0: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@200: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@240: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml @ 2022-01-15 17:22 ` Rob Herring 0 siblings, 0 replies; 20+ messages in thread From: Rob Herring @ 2022-01-15 17:22 UTC (permalink / raw) To: Alexander Stein Cc: Jerome Brunet, Neil Armstrong, devicetree, Liam Girdwood, Mark Brown, Rob Herring, Kevin Hilman, Martin Blumenstingl, linux-amlogic On Sat, 15 Jan 2022 10:35:57 +0100, Alexander Stein wrote: > Convert Amlogic FIFO controller documentation to yaml format. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Things to note: > First of, Jerome, sorry for adding you as maintainer, but > 1) it's mandatory > 2) your are the (only) author of amlogic,axg-fifo.txt > > Please add your Signed-off-by if that is okay with you. > > License is mandated by checkpath, not my choice. > > I'm not so sure about the compatible check. Essentially it is either > * 'amlogic,axg-frddr' OR > * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr' > (or 'sm1' instead of 'g12a') > > Same goes for *-toddr. Is this schema correct in that regard? At least I > got no warnings on existing device trees. > > .../bindings/sound/amlogic,axg-fifo.txt | 34 ------- > .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++ > 2 files changed, 97 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1580333 audio-controller@100: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@140: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@180: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@1c0: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@200: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml audio-controller@240: 'reset-names' is a required property arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml 2022-01-15 9:35 ` Alexander Stein @ 2022-01-15 17:29 ` Rob Herring -1 siblings, 0 replies; 20+ messages in thread From: Rob Herring @ 2022-01-15 17:29 UTC (permalink / raw) To: Alexander Stein Cc: Jerome Brunet, Liam Girdwood, Mark Brown, Neil Armstrong, Kevin Hilman, Martin Blumenstingl, devicetree, open list:ARM/Amlogic Meson... On Sat, Jan 15, 2022 at 3:36 AM Alexander Stein <alexander.stein@mailbox.org> wrote: > > Convert Amlogic FIFO controller documentation to yaml format. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Things to note: > First of, Jerome, sorry for adding you as maintainer, but > 1) it's mandatory > 2) your are the (only) author of amlogic,axg-fifo.txt > > Please add your Signed-off-by if that is okay with you. That's not how Signed-off-by works. 'Acked-by' would be correct. But as the only author, I don't think that's required here. > > License is mandated by checkpath, not my choice. checkpatch doesn't mandate anything. It is guidance. If you copy the existing binding, then you inherit the default license (GPL-2.0). But if Jerome is okay with relicensing, that would be nice. Rob ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml @ 2022-01-15 17:29 ` Rob Herring 0 siblings, 0 replies; 20+ messages in thread From: Rob Herring @ 2022-01-15 17:29 UTC (permalink / raw) To: Alexander Stein Cc: Jerome Brunet, Liam Girdwood, Mark Brown, Neil Armstrong, Kevin Hilman, Martin Blumenstingl, devicetree, open list:ARM/Amlogic Meson... On Sat, Jan 15, 2022 at 3:36 AM Alexander Stein <alexander.stein@mailbox.org> wrote: > > Convert Amlogic FIFO controller documentation to yaml format. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Things to note: > First of, Jerome, sorry for adding you as maintainer, but > 1) it's mandatory > 2) your are the (only) author of amlogic,axg-fifo.txt > > Please add your Signed-off-by if that is okay with you. That's not how Signed-off-by works. 'Acked-by' would be correct. But as the only author, I don't think that's required here. > > License is mandated by checkpath, not my choice. checkpatch doesn't mandate anything. It is guidance. If you copy the existing binding, then you inherit the default license (GPL-2.0). But if Jerome is okay with relicensing, that would be nice. Rob _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property 2022-01-15 9:35 ` Alexander Stein @ 2022-01-15 15:04 ` Jerome Brunet -1 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-15 15:04 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote: > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required > property. Add it. Binginds *mandates* ?? the bindings you are adding mandates that, not the previous doc, nor the driver. Modifying drivers and DT to accomodate made-up bindings requirement is disturbing. The bindings should not require that because the driver does not, as it stands. The driver requires the arb reset to be provided, not the name. Please fix the bindings. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > This is essentially a preparation for YAML conversion to fix the > warnings. > > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 3f5254eeb47b..b14175e2f1d6 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -1333,6 +1333,7 @@ toddr_a: audio-controller@100 { > interrupts = <GIC_SPI 84 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_TODDR_A>; > resets = <&arb AXG_ARB_TODDR_A>; > + reset-names = "arb"; > amlogic,fifo-depth = <512>; > status = "disabled"; > }; > @@ -1345,6 +1346,7 @@ toddr_b: audio-controller@140 { > interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_TODDR_B>; > resets = <&arb AXG_ARB_TODDR_B>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; > @@ -1357,6 +1359,7 @@ toddr_c: audio-controller@180 { > interrupts = <GIC_SPI 86 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_TODDR_C>; > resets = <&arb AXG_ARB_TODDR_C>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; > @@ -1369,6 +1372,7 @@ frddr_a: audio-controller@1c0 { > interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > resets = <&arb AXG_ARB_FRDDR_A>; > + reset-names = "arb"; > amlogic,fifo-depth = <512>; > status = "disabled"; > }; > @@ -1381,6 +1385,7 @@ frddr_b: audio-controller@200 { > interrupts = <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_FRDDR_B>; > resets = <&arb AXG_ARB_FRDDR_B>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; > @@ -1393,6 +1398,7 @@ frddr_c: audio-controller@240 { > interrupts = <GIC_SPI 90 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_FRDDR_C>; > resets = <&arb AXG_ARB_FRDDR_C>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-15 15:04 ` Jerome Brunet 0 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-15 15:04 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote: > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required > property. Add it. Binginds *mandates* ?? the bindings you are adding mandates that, not the previous doc, nor the driver. Modifying drivers and DT to accomodate made-up bindings requirement is disturbing. The bindings should not require that because the driver does not, as it stands. The driver requires the arb reset to be provided, not the name. Please fix the bindings. > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > This is essentially a preparation for YAML conversion to fix the > warnings. > > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 3f5254eeb47b..b14175e2f1d6 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -1333,6 +1333,7 @@ toddr_a: audio-controller@100 { > interrupts = <GIC_SPI 84 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_TODDR_A>; > resets = <&arb AXG_ARB_TODDR_A>; > + reset-names = "arb"; > amlogic,fifo-depth = <512>; > status = "disabled"; > }; > @@ -1345,6 +1346,7 @@ toddr_b: audio-controller@140 { > interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_TODDR_B>; > resets = <&arb AXG_ARB_TODDR_B>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; > @@ -1357,6 +1359,7 @@ toddr_c: audio-controller@180 { > interrupts = <GIC_SPI 86 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_TODDR_C>; > resets = <&arb AXG_ARB_TODDR_C>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; > @@ -1369,6 +1372,7 @@ frddr_a: audio-controller@1c0 { > interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > resets = <&arb AXG_ARB_FRDDR_A>; > + reset-names = "arb"; > amlogic,fifo-depth = <512>; > status = "disabled"; > }; > @@ -1381,6 +1385,7 @@ frddr_b: audio-controller@200 { > interrupts = <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_FRDDR_B>; > resets = <&arb AXG_ARB_FRDDR_B>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; > @@ -1393,6 +1398,7 @@ frddr_c: audio-controller@240 { > interrupts = <GIC_SPI 90 IRQ_TYPE_EDGE_RISING>; > clocks = <&clkc_audio AUD_CLKID_FRDDR_C>; > resets = <&arb AXG_ARB_FRDDR_C>; > + reset-names = "arb"; > amlogic,fifo-depth = <256>; > status = "disabled"; > }; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property 2022-01-15 15:04 ` Jerome Brunet @ 2022-01-16 9:49 ` Alexander Stein -1 siblings, 0 replies; 20+ messages in thread From: Alexander Stein @ 2022-01-16 9:49 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl, Jerome Brunet Cc: devicetree, linux-amlogic Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: > > On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote: > > > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required > > property. Add it. > > Binginds *mandates* ?? the bindings you are adding mandates that, not the > previous doc, nor the driver. Well, under required properties 'reset-names' is listed as well as 'arb' is required, only 'rst' is optional. So when creating the .yaml accordingly this leads to warnings this patch is about to fix. > Modifying drivers and DT to accomodate made-up bindings requirement is > disturbing. > > The bindings should not require that because the driver does not, as it > stands. The driver requires the arb reset to be provided, not the name. > Please fix the bindings. Nothing is made up. When creating the .yaml file I took the .txt documentation for granted. How should I know the bindings documentation is apparently wrong? When using your older bindings conversion [1] I'm fine with dropping this one. Best regards, Alexander [1] https://patchwork.kernel.org/project/linux-amlogic/list/? series=246453&state=%2A&archive=both ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-16 9:49 ` Alexander Stein 0 siblings, 0 replies; 20+ messages in thread From: Alexander Stein @ 2022-01-16 9:49 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl, Jerome Brunet Cc: devicetree, linux-amlogic Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: > > On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote: > > > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required > > property. Add it. > > Binginds *mandates* ?? the bindings you are adding mandates that, not the > previous doc, nor the driver. Well, under required properties 'reset-names' is listed as well as 'arb' is required, only 'rst' is optional. So when creating the .yaml accordingly this leads to warnings this patch is about to fix. > Modifying drivers and DT to accomodate made-up bindings requirement is > disturbing. > > The bindings should not require that because the driver does not, as it > stands. The driver requires the arb reset to be provided, not the name. > Please fix the bindings. Nothing is made up. When creating the .yaml file I took the .txt documentation for granted. How should I know the bindings documentation is apparently wrong? When using your older bindings conversion [1] I'm fine with dropping this one. Best regards, Alexander [1] https://patchwork.kernel.org/project/linux-amlogic/list/? series=246453&state=%2A&archive=both _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property 2022-01-16 9:49 ` Alexander Stein @ 2022-01-16 17:30 ` Jerome Brunet -1 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-16 17:30 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Sun 16 Jan 2022 at 10:49, Alexander Stein <alexander.stein@mailbox.org> wrote: > Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: >> >> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> > wrote: >> >> > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required >> > property. Add it. >> >> Binginds *mandates* ?? the bindings you are adding mandates that, not the >> previous doc, nor the driver. > > Well, under required properties 'reset-names' is listed as well as 'arb' is > required, only 'rst' is optional. I think there is a misunderstanding then. The arb reset is required, the "reset-names" is not - as long as there is single reset. > So when creating the .yaml accordingly this leads to warnings this patch is > about to fix. > >> Modifying drivers and DT to accomodate made-up bindings requirement is >> disturbing. >> >> The bindings should not require that because the driver does not, as it >> stands. The driver requires the arb reset to be provided, not the name. >> Please fix the bindings. > > Nothing is made up. When creating the .yaml file I took the .txt documentation > for granted. How should I know the bindings documentation is apparently wrong? > > When using your older bindings conversion [1] I'm fine with dropping this one. > > Best regards, > Alexander > > [1] https://patchwork.kernel.org/project/linux-amlogic/list/? > series=246453&state=%2A&archive=both ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-16 17:30 ` Jerome Brunet 0 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-16 17:30 UTC (permalink / raw) To: Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Sun 16 Jan 2022 at 10:49, Alexander Stein <alexander.stein@mailbox.org> wrote: > Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: >> >> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> > wrote: >> >> > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required >> > property. Add it. >> >> Binginds *mandates* ?? the bindings you are adding mandates that, not the >> previous doc, nor the driver. > > Well, under required properties 'reset-names' is listed as well as 'arb' is > required, only 'rst' is optional. I think there is a misunderstanding then. The arb reset is required, the "reset-names" is not - as long as there is single reset. > So when creating the .yaml accordingly this leads to warnings this patch is > about to fix. > >> Modifying drivers and DT to accomodate made-up bindings requirement is >> disturbing. >> >> The bindings should not require that because the driver does not, as it >> stands. The driver requires the arb reset to be provided, not the name. >> Please fix the bindings. > > Nothing is made up. When creating the .yaml file I took the .txt documentation > for granted. How should I know the bindings documentation is apparently wrong? > > When using your older bindings conversion [1] I'm fine with dropping this one. > > Best regards, > Alexander > > [1] https://patchwork.kernel.org/project/linux-amlogic/list/? > series=246453&state=%2A&archive=both _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property 2022-01-16 17:30 ` Jerome Brunet @ 2022-01-17 9:49 ` Neil Armstrong -1 siblings, 0 replies; 20+ messages in thread From: Neil Armstrong @ 2022-01-17 9:49 UTC (permalink / raw) To: Jerome Brunet, Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic Hi, On 16/01/2022 18:30, Jerome Brunet wrote: > > On Sun 16 Jan 2022 at 10:49, Alexander Stein <alexander.stein@mailbox.org> wrote: > >> Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: >>> >>> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> >> wrote: >>> >>>> Bindings amlogic,axg-fifo.txt mandates that reset-names is a required >>>> property. Add it. >>> >>> Binginds *mandates* ?? the bindings you are adding mandates that, not the >>> previous doc, nor the driver. >> >> Well, under required properties 'reset-names' is listed as well as 'arb' is >> required, only 'rst' is optional. > > I think there is a misunderstanding then. > The arb reset is required, the "reset-names" is not - as long as there > is single reset. To be fair, it's not explicit in the .txt bindings at all: -- reset-names: should contain the following: - * "arb" : memory ARB line (required) - * "rst" : dedicated device reset line (optional) Anyway, this should be solved, it's pretty common to have reset-names mandatory even for a single reset if a second one is optional. > >> So when creating the .yaml accordingly this leads to warnings this patch is >> about to fix. >> >>> Modifying drivers and DT to accomodate made-up bindings requirement is >>> disturbing. >>> >>> The bindings should not require that because the driver does not, as it >>> stands. The driver requires the arb reset to be provided, not the name. >>> Please fix the bindings. >> >> Nothing is made up. When creating the .yaml file I took the .txt documentation >> for granted. How should I know the bindings documentation is apparently wrong? >> >> When using your older bindings conversion [1] I'm fine with dropping this one. >> >> Best regards, >> Alexander >> >> [1] https://patchwork.kernel.org/project/linux-amlogic/list/? >> series=246453&state=%2A&archive=both > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-17 9:49 ` Neil Armstrong 0 siblings, 0 replies; 20+ messages in thread From: Neil Armstrong @ 2022-01-17 9:49 UTC (permalink / raw) To: Jerome Brunet, Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic Hi, On 16/01/2022 18:30, Jerome Brunet wrote: > > On Sun 16 Jan 2022 at 10:49, Alexander Stein <alexander.stein@mailbox.org> wrote: > >> Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: >>> >>> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> >> wrote: >>> >>>> Bindings amlogic,axg-fifo.txt mandates that reset-names is a required >>>> property. Add it. >>> >>> Binginds *mandates* ?? the bindings you are adding mandates that, not the >>> previous doc, nor the driver. >> >> Well, under required properties 'reset-names' is listed as well as 'arb' is >> required, only 'rst' is optional. > > I think there is a misunderstanding then. > The arb reset is required, the "reset-names" is not - as long as there > is single reset. To be fair, it's not explicit in the .txt bindings at all: -- reset-names: should contain the following: - * "arb" : memory ARB line (required) - * "rst" : dedicated device reset line (optional) Anyway, this should be solved, it's pretty common to have reset-names mandatory even for a single reset if a second one is optional. > >> So when creating the .yaml accordingly this leads to warnings this patch is >> about to fix. >> >>> Modifying drivers and DT to accomodate made-up bindings requirement is >>> disturbing. >>> >>> The bindings should not require that because the driver does not, as it >>> stands. The driver requires the arb reset to be provided, not the name. >>> Please fix the bindings. >> >> Nothing is made up. When creating the .yaml file I took the .txt documentation >> for granted. How should I know the bindings documentation is apparently wrong? >> >> When using your older bindings conversion [1] I'm fine with dropping this one. >> >> Best regards, >> Alexander >> >> [1] https://patchwork.kernel.org/project/linux-amlogic/list/? >> series=246453&state=%2A&archive=both > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property 2022-01-17 9:49 ` Neil Armstrong @ 2022-01-17 10:08 ` Jerome Brunet -1 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-17 10:08 UTC (permalink / raw) To: Neil Armstrong, Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Mon 17 Jan 2022 at 10:49, Neil Armstrong <narmstrong@baylibre.com> wrote: > Hi, > > On 16/01/2022 18:30, Jerome Brunet wrote: >> >> On Sun 16 Jan 2022 at 10:49, Alexander Stein <alexander.stein@mailbox.org> wrote: >> >>> Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: >>>> >>>> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> >>> wrote: >>>> >>>>> Bindings amlogic,axg-fifo.txt mandates that reset-names is a required >>>>> property. Add it. >>>> >>>> Binginds *mandates* ?? the bindings you are adding mandates that, not the >>>> previous doc, nor the driver. >>> >>> Well, under required properties 'reset-names' is listed as well as 'arb' is >>> required, only 'rst' is optional. >> >> I think there is a misunderstanding then. >> The arb reset is required, the "reset-names" is not - as long as there >> is single reset. > > To be fair, it's not explicit in the .txt bindings at all: > - resets: list of reset phandle, one for each entry reset-names. > -- reset-names: should contain the following: > - * "arb" : memory ARB line (required) > - * "rst" : dedicated device reset line (optional) That was fairly usual way to describe clocks and reset with txt files but I agree it could have been interpreted the other way around > > Anyway, this should be solved, it's pretty common to have reset-names mandatory even > for a single reset if a second one is optional. Binding should not decribe what's common but how the binding is supposed to be used. Fact is the usage was defined by the first and only user which is linux driver. This driver does not care if the arb name is present or not. Mandating something which is unused makes no sense. If we want to be precise, then it just cares it is the first reset is the arb one (and yes, this constraint is not described either). The reason for that is simple, there was no 'rst' line on first version of the IP, and it was 'fairly usual' to not have 'reset-names' when there is a single reset. If you think the 'arb' name should be made mandatory, that's fine by me but one should be able to rely on the name so the driver should be updated to use it. > >> >>> So when creating the .yaml accordingly this leads to warnings this patch is >>> about to fix. >>> >>>> Modifying drivers and DT to accomodate made-up bindings requirement is >>>> disturbing. >>>> >>>> The bindings should not require that because the driver does not, as it >>>> stands. The driver requires the arb reset to be provided, not the name. >>>> Please fix the bindings. >>> >>> Nothing is made up. When creating the .yaml file I took the .txt documentation >>> for granted. How should I know the bindings documentation is apparently wrong? >>> >>> When using your older bindings conversion [1] I'm fine with dropping this one. >>> >>> Best regards, >>> Alexander >>> >>> [1] https://patchwork.kernel.org/project/linux-amlogic/list/? >>> series=246453&state=%2A&archive=both >> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property @ 2022-01-17 10:08 ` Jerome Brunet 0 siblings, 0 replies; 20+ messages in thread From: Jerome Brunet @ 2022-01-17 10:08 UTC (permalink / raw) To: Neil Armstrong, Alexander Stein, Liam Girdwood, Mark Brown, Rob Herring, Kevin Hilman, Martin Blumenstingl Cc: devicetree, linux-amlogic On Mon 17 Jan 2022 at 10:49, Neil Armstrong <narmstrong@baylibre.com> wrote: > Hi, > > On 16/01/2022 18:30, Jerome Brunet wrote: >> >> On Sun 16 Jan 2022 at 10:49, Alexander Stein <alexander.stein@mailbox.org> wrote: >> >>> Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet: >>>> >>>> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> >>> wrote: >>>> >>>>> Bindings amlogic,axg-fifo.txt mandates that reset-names is a required >>>>> property. Add it. >>>> >>>> Binginds *mandates* ?? the bindings you are adding mandates that, not the >>>> previous doc, nor the driver. >>> >>> Well, under required properties 'reset-names' is listed as well as 'arb' is >>> required, only 'rst' is optional. >> >> I think there is a misunderstanding then. >> The arb reset is required, the "reset-names" is not - as long as there >> is single reset. > > To be fair, it's not explicit in the .txt bindings at all: > - resets: list of reset phandle, one for each entry reset-names. > -- reset-names: should contain the following: > - * "arb" : memory ARB line (required) > - * "rst" : dedicated device reset line (optional) That was fairly usual way to describe clocks and reset with txt files but I agree it could have been interpreted the other way around > > Anyway, this should be solved, it's pretty common to have reset-names mandatory even > for a single reset if a second one is optional. Binding should not decribe what's common but how the binding is supposed to be used. Fact is the usage was defined by the first and only user which is linux driver. This driver does not care if the arb name is present or not. Mandating something which is unused makes no sense. If we want to be precise, then it just cares it is the first reset is the arb one (and yes, this constraint is not described either). The reason for that is simple, there was no 'rst' line on first version of the IP, and it was 'fairly usual' to not have 'reset-names' when there is a single reset. If you think the 'arb' name should be made mandatory, that's fine by me but one should be able to rely on the name so the driver should be updated to use it. > >> >>> So when creating the .yaml accordingly this leads to warnings this patch is >>> about to fix. >>> >>>> Modifying drivers and DT to accomodate made-up bindings requirement is >>>> disturbing. >>>> >>>> The bindings should not require that because the driver does not, as it >>>> stands. The driver requires the arb reset to be provided, not the name. >>>> Please fix the bindings. >>> >>> Nothing is made up. When creating the .yaml file I took the .txt documentation >>> for granted. How should I know the bindings documentation is apparently wrong? >>> >>> When using your older bindings conversion [1] I'm fine with dropping this one. >>> >>> Best regards, >>> Alexander >>> >>> [1] https://patchwork.kernel.org/project/linux-amlogic/list/? >>> series=246453&state=%2A&archive=both >> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2022-01-17 10:28 UTC | newest] Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-01-15 9:35 [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Alexander Stein 2022-01-15 9:35 ` Alexander Stein 2022-01-15 9:35 ` [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml Alexander Stein 2022-01-15 9:35 ` Alexander Stein 2022-01-15 15:16 ` Jerome Brunet 2022-01-15 15:16 ` Jerome Brunet 2022-01-15 17:22 ` Rob Herring 2022-01-15 17:22 ` Rob Herring 2022-01-15 17:29 ` Rob Herring 2022-01-15 17:29 ` Rob Herring 2022-01-15 15:04 ` [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Jerome Brunet 2022-01-15 15:04 ` Jerome Brunet 2022-01-16 9:49 ` Alexander Stein 2022-01-16 9:49 ` Alexander Stein 2022-01-16 17:30 ` Jerome Brunet 2022-01-16 17:30 ` Jerome Brunet 2022-01-17 9:49 ` Neil Armstrong 2022-01-17 9:49 ` Neil Armstrong 2022-01-17 10:08 ` Jerome Brunet 2022-01-17 10:08 ` Jerome Brunet
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.