* [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55
@ 2022-01-15 10:39 Slark Xiao
2022-01-17 7:53 ` Manivannan Sadhasivam
0 siblings, 1 reply; 3+ messages in thread
From: Slark Xiao @ 2022-01-15 10:39 UTC (permalink / raw)
To: mani, hemantk; +Cc: mhi, linux-arm-msm, linux-kernel, Slark Xiao
For default mechanism, product would use default MRU 3500 if
they didn't define it. But for Foxconn SDX55, there is a known
issue which MRU 3500 would lead to data connection lost.
So we align it with Qualcomm default MRU settings.
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
drivers/bus/mhi/pci_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 3a258a677df8..74e8fc342cfd 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
.config = &modem_foxconn_sdx55_config,
.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
.dma_data_width = 32,
+ .mru_default = 32768,
.sideband_wake = false,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55
2022-01-15 10:39 [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55 Slark Xiao
@ 2022-01-17 7:53 ` Manivannan Sadhasivam
2022-01-17 8:20 ` Slark Xiao
0 siblings, 1 reply; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-01-17 7:53 UTC (permalink / raw)
To: Slark Xiao; +Cc: hemantk, mhi, linux-arm-msm, linux-kernel
On Sat, Jan 15, 2022 at 06:39:12PM +0800, Slark Xiao wrote:
> For default mechanism, product would use default MRU 3500 if
> they didn't define it. But for Foxconn SDX55, there is a known
> issue which MRU 3500 would lead to data connection lost.
> So we align it with Qualcomm default MRU settings.
>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
You need to add Fixes tag so that I can queue this patch for v5.17 RCs.
Thanks,
Mani
> ---
> drivers/bus/mhi/pci_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 3a258a677df8..74e8fc342cfd 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
> .config = &modem_foxconn_sdx55_config,
> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> .dma_data_width = 32,
> + .mru_default = 32768,
> .sideband_wake = false,
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re:Re: [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55
2022-01-17 7:53 ` Manivannan Sadhasivam
@ 2022-01-17 8:20 ` Slark Xiao
0 siblings, 0 replies; 3+ messages in thread
From: Slark Xiao @ 2022-01-17 8:20 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: hemantk, mhi, linux-arm-msm, linux-kernel
At 2022-01-17 15:53:23, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>On Sat, Jan 15, 2022 at 06:39:12PM +0800, Slark Xiao wrote:
>> For default mechanism, product would use default MRU 3500 if
>> they didn't define it. But for Foxconn SDX55, there is a known
>> issue which MRU 3500 would lead to data connection lost.
>> So we align it with Qualcomm default MRU settings.
>>
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
>Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
>You need to add Fixes tag so that I can queue this patch for v5.17 RCs.
>
>Thanks,
>Mani
>
Hi Mani,
New patch is committed. Please help do a check again.
Thanks!
>> ---
>> drivers/bus/mhi/pci_generic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
>> index 3a258a677df8..74e8fc342cfd 100644
>> --- a/drivers/bus/mhi/pci_generic.c
>> +++ b/drivers/bus/mhi/pci_generic.c
>> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
>> .config = &modem_foxconn_sdx55_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> .dma_data_width = 32,
>> + .mru_default = 32768,
>> .sideband_wake = false,
>> };
>>
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-17 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-15 10:39 [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55 Slark Xiao
2022-01-17 7:53 ` Manivannan Sadhasivam
2022-01-17 8:20 ` Slark Xiao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.