* [PATCH] ksmbd: uninitialized variable in create_socket()
@ 2022-01-15 11:49 Dan Carpenter
2022-01-16 12:47 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-01-15 11:49 UTC (permalink / raw)
To: Namjae Jeon
Cc: Sergey Senozhatsky, Steve French, Hyunchul Lee, Ronnie Sahlberg,
linux-cifs, kernel-janitors
The "ksmbd_socket" variable is not initialized on this error path.
Cc: stable@vger.kernel.org
Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/ksmbd/transport_tcp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
index c14320e03b69..82a1429bbe12 100644
--- a/fs/ksmbd/transport_tcp.c
+++ b/fs/ksmbd/transport_tcp.c
@@ -404,7 +404,7 @@ static int create_socket(struct interface *iface)
&ksmbd_socket);
if (ret) {
pr_err("Can't create socket for ipv4: %d\n", ret);
- goto out_error;
+ goto out_clear;
}
sin.sin_family = PF_INET;
@@ -462,6 +462,7 @@ static int create_socket(struct interface *iface)
out_error:
tcp_destroy_socket(ksmbd_socket);
+out_clear:
iface->ksmbd_socket = NULL;
return ret;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ksmbd: uninitialized variable in create_socket()
2022-01-15 11:49 [PATCH] ksmbd: uninitialized variable in create_socket() Dan Carpenter
@ 2022-01-16 12:47 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2022-01-16 12:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sergey Senozhatsky, Steve French, Hyunchul Lee, Ronnie Sahlberg,
linux-cifs, kernel-janitors
2022-01-15 20:49 GMT+09:00, Dan Carpenter <dan.carpenter@oracle.com>:
> The "ksmbd_socket" variable is not initialized on this error path.
>
> Cc: stable@vger.kernel.org
> Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and
> tranport layers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-16 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-15 11:49 [PATCH] ksmbd: uninitialized variable in create_socket() Dan Carpenter
2022-01-16 12:47 ` Namjae Jeon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.