All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: add mapping for MSI MPG X570S Carbon Max Wifi.
@ 2022-01-15 14:02 ` Johannes Schickel
  0 siblings, 0 replies; 4+ messages in thread
From: Johannes Schickel @ 2022-01-15 14:02 UTC (permalink / raw)
  To: alsa-devel
  Cc: Johannes Schickel, Jaroslav Kysela, Takashi Iwai, Andrea Fagiani,
	Timo Gurr, linux-kernel

The USB audio device 0db0:419c based on the Realtek ALC4080 chip exposes
all playback volume controls as "PCM". This is makes distinguishing the
individual functions hard.

The added mapping distinguishes all playback volume controls as their
respective function:
 - Speaker              - for back panel output
 - Frontpanel Headphone - for front panel output
 - IEC958               - for digital output on the back panel

This clarifies the individual volume control functions for users.

Signed-off-by: Johannes Schickel <lordhoto@gmail.com>
---
 sound/usb/mixer_maps.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
index 5d391f62351b..96991ddf5055 100644
--- a/sound/usb/mixer_maps.c
+++ b/sound/usb/mixer_maps.c
@@ -431,6 +431,14 @@ static const struct usbmix_name_map aorus_master_alc1220vb_map[] = {
 	{}
 };
 
+/* MSI MPG X570S Carbon Max Wifi with ALC4080  */
+static const struct usbmix_name_map msi_mpg_x570s_carbon_max_wifi_alc4080_map[] = {
+	{ 29, "Speaker Playback" },
+	{ 30, "Front Headphone Playback" },
+	{ 32, "IEC958 Playback" },
+	{}
+};
+
 /*
  * Control map entries
  */
@@ -577,6 +585,10 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = {
 		.map = trx40_mobo_map,
 		.connector_map = trx40_mobo_connector_map,
 	},
+	{	/* MSI MPG X570S Carbon Max Wifi */
+		.id = USB_ID(0x0db0, 0x419c),
+		.map = msi_mpg_x570s_carbon_max_wifi_alc4080_map,
+	},
 	{	/* MSI TRX40 */
 		.id = USB_ID(0x0db0, 0x543d),
 		.map = trx40_mobo_map,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ALSA: usb-audio: add mapping for MSI MPG X570S Carbon Max Wifi.
@ 2022-01-15 14:02 ` Johannes Schickel
  0 siblings, 0 replies; 4+ messages in thread
From: Johannes Schickel @ 2022-01-15 14:02 UTC (permalink / raw)
  To: alsa-devel
  Cc: Andrea Fagiani, Takashi Iwai, linux-kernel, Johannes Schickel, Timo Gurr

The USB audio device 0db0:419c based on the Realtek ALC4080 chip exposes
all playback volume controls as "PCM". This is makes distinguishing the
individual functions hard.

The added mapping distinguishes all playback volume controls as their
respective function:
 - Speaker              - for back panel output
 - Frontpanel Headphone - for front panel output
 - IEC958               - for digital output on the back panel

This clarifies the individual volume control functions for users.

Signed-off-by: Johannes Schickel <lordhoto@gmail.com>
---
 sound/usb/mixer_maps.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
index 5d391f62351b..96991ddf5055 100644
--- a/sound/usb/mixer_maps.c
+++ b/sound/usb/mixer_maps.c
@@ -431,6 +431,14 @@ static const struct usbmix_name_map aorus_master_alc1220vb_map[] = {
 	{}
 };
 
+/* MSI MPG X570S Carbon Max Wifi with ALC4080  */
+static const struct usbmix_name_map msi_mpg_x570s_carbon_max_wifi_alc4080_map[] = {
+	{ 29, "Speaker Playback" },
+	{ 30, "Front Headphone Playback" },
+	{ 32, "IEC958 Playback" },
+	{}
+};
+
 /*
  * Control map entries
  */
@@ -577,6 +585,10 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = {
 		.map = trx40_mobo_map,
 		.connector_map = trx40_mobo_connector_map,
 	},
+	{	/* MSI MPG X570S Carbon Max Wifi */
+		.id = USB_ID(0x0db0, 0x419c),
+		.map = msi_mpg_x570s_carbon_max_wifi_alc4080_map,
+	},
 	{	/* MSI TRX40 */
 		.id = USB_ID(0x0db0, 0x543d),
 		.map = trx40_mobo_map,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: usb-audio: add mapping for MSI MPG X570S Carbon Max Wifi.
  2022-01-15 14:02 ` Johannes Schickel
@ 2022-01-16  8:29   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-01-16  8:29 UTC (permalink / raw)
  To: Johannes Schickel
  Cc: alsa-devel, Jaroslav Kysela, Takashi Iwai, Andrea Fagiani,
	Timo Gurr, linux-kernel

On Sat, 15 Jan 2022 15:02:57 +0100,
Johannes Schickel wrote:
> 
> The USB audio device 0db0:419c based on the Realtek ALC4080 chip exposes
> all playback volume controls as "PCM". This is makes distinguishing the
> individual functions hard.
> 
> The added mapping distinguishes all playback volume controls as their
> respective function:
>  - Speaker              - for back panel output
>  - Frontpanel Headphone - for front panel output
>  - IEC958               - for digital output on the back panel
> 
> This clarifies the individual volume control functions for users.
> 
> Signed-off-by: Johannes Schickel <lordhoto@gmail.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: usb-audio: add mapping for MSI MPG X570S Carbon Max Wifi.
@ 2022-01-16  8:29   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-01-16  8:29 UTC (permalink / raw)
  To: Johannes Schickel
  Cc: Andrea Fagiani, alsa-devel, Takashi Iwai, linux-kernel, Timo Gurr

On Sat, 15 Jan 2022 15:02:57 +0100,
Johannes Schickel wrote:
> 
> The USB audio device 0db0:419c based on the Realtek ALC4080 chip exposes
> all playback volume controls as "PCM". This is makes distinguishing the
> individual functions hard.
> 
> The added mapping distinguishes all playback volume controls as their
> respective function:
>  - Speaker              - for back panel output
>  - Frontpanel Headphone - for front panel output
>  - IEC958               - for digital output on the back panel
> 
> This clarifies the individual volume control functions for users.
> 
> Signed-off-by: Johannes Schickel <lordhoto@gmail.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-16  8:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-15 14:02 [PATCH] ALSA: usb-audio: add mapping for MSI MPG X570S Carbon Max Wifi Johannes Schickel
2022-01-15 14:02 ` Johannes Schickel
2022-01-16  8:29 ` Takashi Iwai
2022-01-16  8:29   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.