* [PATCH 0/2] linux-user: Two minor patches
@ 2022-01-16 20:44 Warner Losh
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
2022-01-16 20:44 ` [PATCH 2/2] linxu-user: Change return type of queue_signal to void Warner Losh
0 siblings, 2 replies; 7+ messages in thread
From: Warner Losh @ 2022-01-16 20:44 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, richard.henderson, f4bug, Warner Losh, Laurent Vivier
There's two, almost trivial patches that arose out of the review of bsd-user.
There's a chance that one or both of these were submitted already...
Warner Losh (2):
linx-user: Remove MAX_SIGQUEUE_SIZE
linxu-user: Change return type of queue_signal to void
linux-user/qemu.h | 2 --
linux-user/signal-common.h | 4 ++--
linux-user/signal.c | 5 ++---
3 files changed, 4 insertions(+), 7 deletions(-)
--
2.33.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE
2022-01-16 20:44 [PATCH 0/2] linux-user: Two minor patches Warner Losh
@ 2022-01-16 20:44 ` Warner Losh
2022-01-16 21:16 ` Philippe Mathieu-Daudé via
` (2 more replies)
2022-01-16 20:44 ` [PATCH 2/2] linxu-user: Change return type of queue_signal to void Warner Losh
1 sibling, 3 replies; 7+ messages in thread
From: Warner Losh @ 2022-01-16 20:44 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, richard.henderson, f4bug, Warner Losh, Laurent Vivier
It's been unused for 7 years since 907f5fddaa67 when linux-user stopped
queueing any signals.
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
linux-user/qemu.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 5c713fa8ab2..7910ce59cc8 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -89,8 +89,6 @@ struct vm86_saved_state {
#include "nwfpe/fpa11.h"
#endif
-#define MAX_SIGQUEUE_SIZE 1024
-
struct emulated_sigtable {
int pending; /* true if signal is pending */
target_siginfo_t info;
--
2.33.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] linxu-user: Change return type of queue_signal to void
2022-01-16 20:44 [PATCH 0/2] linux-user: Two minor patches Warner Losh
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
@ 2022-01-16 20:44 ` Warner Losh
2022-01-16 21:44 ` Peter Maydell
1 sibling, 1 reply; 7+ messages in thread
From: Warner Losh @ 2022-01-16 20:44 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, richard.henderson, f4bug, Warner Losh, Laurent Vivier
queue_signal always returns 1, and nobody checks it. This is better
expressed as a void function return type.
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
linux-user/signal-common.h | 4 ++--
linux-user/signal.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/linux-user/signal-common.h b/linux-user/signal-common.h
index 42aa479080b..2113165a758 100644
--- a/linux-user/signal-common.h
+++ b/linux-user/signal-common.h
@@ -59,8 +59,8 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
void process_pending_signals(CPUArchState *cpu_env);
void signal_init(void);
-int queue_signal(CPUArchState *env, int sig, int si_type,
- target_siginfo_t *info);
+void queue_signal(CPUArchState *env, int sig, int si_type,
+ target_siginfo_t *info);
void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info);
void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo);
int target_to_host_signal(int sig);
diff --git a/linux-user/signal.c b/linux-user/signal.c
index f813b4f18e4..eddc95e87df 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -780,8 +780,8 @@ static void QEMU_NORETURN dump_core_and_abort(int target_sig)
/* queue a signal so that it will be send to the virtual CPU as soon
as possible */
-int queue_signal(CPUArchState *env, int sig, int si_type,
- target_siginfo_t *info)
+void queue_signal(CPUArchState *env, int sig, int si_type,
+ target_siginfo_t *info)
{
CPUState *cpu = env_cpu(env);
TaskState *ts = cpu->opaque;
@@ -794,7 +794,6 @@ int queue_signal(CPUArchState *env, int sig, int si_type,
ts->sync_signal.pending = sig;
/* signal that a new signal is pending */
qatomic_set(&ts->signal_pending, 1);
- return 1; /* indicates that the signal was queued */
}
--
2.33.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
@ 2022-01-16 21:16 ` Philippe Mathieu-Daudé via
2022-01-16 21:45 ` Peter Maydell
2022-01-18 11:45 ` Laurent Vivier
2 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-16 21:16 UTC (permalink / raw)
To: Warner Losh, qemu-devel; +Cc: richard.henderson, Peter Maydell, Laurent Vivier
On 16/1/22 21:44, Warner Losh wrote:
> It's been unused for 7 years since 907f5fddaa67 when linux-user stopped
> queueing any signals.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> linux-user/qemu.h | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] linxu-user: Change return type of queue_signal to void
2022-01-16 20:44 ` [PATCH 2/2] linxu-user: Change return type of queue_signal to void Warner Losh
@ 2022-01-16 21:44 ` Peter Maydell
0 siblings, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2022-01-16 21:44 UTC (permalink / raw)
To: Warner Losh; +Cc: Laurent Vivier, richard.henderson, qemu-devel, f4bug
On Sun, 16 Jan 2022 at 20:44, Warner Losh <imp@bsdimp.com> wrote:
>
> queue_signal always returns 1, and nobody checks it. This is better
> expressed as a void function return type.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> linux-user/signal-common.h | 4 ++--
> linux-user/signal.c | 5 ++---
> 2 files changed, 4 insertions(+), 5 deletions(-
This one's a dup of patch 3 from my series from Friday:
https://patchew.org/QEMU/20220114153732.3767229-1-peter.maydell@linaro.org/20220114153732.3767229-4-peter.maydell@linaro.org/
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
2022-01-16 21:16 ` Philippe Mathieu-Daudé via
@ 2022-01-16 21:45 ` Peter Maydell
2022-01-18 11:45 ` Laurent Vivier
2 siblings, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2022-01-16 21:45 UTC (permalink / raw)
To: Warner Losh; +Cc: Laurent Vivier, richard.henderson, qemu-devel, f4bug
On Sun, 16 Jan 2022 at 20:44, Warner Losh <imp@bsdimp.com> wrote:
>
> It's been unused for 7 years since 907f5fddaa67 when linux-user stopped
> queueing any signals.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
Typo in subject (should be 'linux-user'); otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
2022-01-16 21:16 ` Philippe Mathieu-Daudé via
2022-01-16 21:45 ` Peter Maydell
@ 2022-01-18 11:45 ` Laurent Vivier
2 siblings, 0 replies; 7+ messages in thread
From: Laurent Vivier @ 2022-01-18 11:45 UTC (permalink / raw)
To: Warner Losh, qemu-devel
Cc: qemu-trivial, Peter Maydell, richard.henderson, f4bug
Le 16/01/2022 à 21:44, Warner Losh a écrit :
> It's been unused for 7 years since 907f5fddaa67 when linux-user stopped
> queueing any signals.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> linux-user/qemu.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 5c713fa8ab2..7910ce59cc8 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -89,8 +89,6 @@ struct vm86_saved_state {
> #include "nwfpe/fpa11.h"
> #endif
>
> -#define MAX_SIGQUEUE_SIZE 1024
> -
> struct emulated_sigtable {
> int pending; /* true if signal is pending */
> target_siginfo_t info;
Applied to my trivial-patches branch.
(typo fixed)
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-18 11:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-16 20:44 [PATCH 0/2] linux-user: Two minor patches Warner Losh
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
2022-01-16 21:16 ` Philippe Mathieu-Daudé via
2022-01-16 21:45 ` Peter Maydell
2022-01-18 11:45 ` Laurent Vivier
2022-01-16 20:44 ` [PATCH 2/2] linxu-user: Change return type of queue_signal to void Warner Losh
2022-01-16 21:44 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.